linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Michael DeGuzis <mdeguzis@gmail.com>, linux-mm@kvack.org
Cc: trivial@kernel.org
Subject: Re: [PATCH] Correct spelling and grammar for notification text
Date: Wed, 17 May 2017 08:35:11 -0700	[thread overview]
Message-ID: <d55eeeee-76ed-b171-d1df-643b36bb17b9@infradead.org> (raw)
In-Reply-To: <20170517133842.5733-1-mdeguzis@gmail.com>

On 05/17/17 06:38, Michael DeGuzis wrote:
> From: professorkaos64 <mdeguzis@gmail.com>
> 
> This patch fixes up some grammar and spelling in the information
> block for huge_memory.c.

Missing Signed-off-by: <real name and email address>

> ---
>  mm/huge_memory.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index a84909cf20d3..af137fc0ca09 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -38,12 +38,12 @@
>  #include "internal.h"
>  
>  /*
> - * By default transparent hugepage support is disabled in order that avoid
> - * to risk increase the memory footprint of applications without a guaranteed
> - * benefit. When transparent hugepage support is enabled, is for all mappings,
> - * and khugepaged scans all mappings.
> + * By default, transparent hugepage support is disabled in order to avoid
> + * risking an increased memory footprint for applications that are not 
> + * guaranteed to benefit from it. When transparent hugepage support is 
> + * enabled, it is for all mappings, and khugepaged scans all mappings.
>   * Defrag is invoked by khugepaged hugepage allocations and by page faults
> - * for all hugepage allocations.
> + * for all hugepage allocations. 

Several of the new (+) patch lines end with a space character. Not good.

>   */
>  unsigned long transparent_hugepage_flags __read_mostly =
>  #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
> 


-- 
~Randy

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-05-17 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 13:38 Michael DeGuzis
2017-05-17 15:35 ` Randy Dunlap [this message]
2017-05-17 17:23   ` mikey d

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d55eeeee-76ed-b171-d1df-643b36bb17b9@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=mdeguzis@gmail.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox