From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 286DBC0218F for ; Fri, 31 Jan 2025 10:56:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 917DC280299; Fri, 31 Jan 2025 05:56:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C6F52800EF; Fri, 31 Jan 2025 05:56:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 719F2280299; Fri, 31 Jan 2025 05:56:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 536E82800EF for ; Fri, 31 Jan 2025 05:56:17 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0A285A0B2E for ; Fri, 31 Jan 2025 10:56:12 +0000 (UTC) X-FDA: 83067442584.23.E303130 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 8A41EA0002 for ; Fri, 31 Jan 2025 10:56:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SsH01pe0; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738320969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q3RpfUrdZBCMnrOyM0k8HuSUcAta7Y636lLqMrYrWx8=; b=ukw+Xt19r1+5cADCNMbcqUORBQFxQ6SObaRnQAX8OZYcNNryVUsY2ncDCXsJtyC9zOxmqs egtkEMFpzVoMgOwRODFQ5yj9HbZxaVBOGqtmYkQQLlXS3YV587rqyJsDSI2vGHf8O4ghvZ lEs3bq5dw/3M3CsWdE6Gfg9fhULqd2k= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SsH01pe0; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738320969; a=rsa-sha256; cv=none; b=HEbY8asJfwkVAkA5lqU32z91Fnytj3pI7IsJ9cYNu6BgyAVKLxLMs5+7b2NZe2SMCO8T3K bwSbB1SM/HefjjqU3K0kYmBPVjT4nAQvTG8395Sbb0mx2hXKvE0BEbTwxAjmcldwoKghg5 WAiv7YIwogbZLChNgf5ppOSCn6HCzn4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738320969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q3RpfUrdZBCMnrOyM0k8HuSUcAta7Y636lLqMrYrWx8=; b=SsH01pe0MxZrQQJDVXTOY7/itGqNZ24qhWI2Xt63e9OrFkxxjSGN6dIEJ7tXlZXWN3Pu10 nNGngeCtGyxOlZSnfHLd8i6xSH6HX2kb27GsKQ22jWtk49R018NUeYU3A6bZB4WQ8J33QM xQKmiDC2BrCRD5bIA0X0m9czMScTDOg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-6yPWGTIZOai8jlydIW2mcg-1; Fri, 31 Jan 2025 05:56:07 -0500 X-MC-Unique: 6yPWGTIZOai8jlydIW2mcg-1 X-Mimecast-MFC-AGG-ID: 6yPWGTIZOai8jlydIW2mcg Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38a873178f2so817126f8f.1 for ; Fri, 31 Jan 2025 02:56:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738320966; x=1738925766; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q3RpfUrdZBCMnrOyM0k8HuSUcAta7Y636lLqMrYrWx8=; b=EQte9+sPMZ5CSWBGfts2j8ixxmOHaoXP9seo8oXX+zWz2JNv7yXxX8wr46y2zkdaUD vCRmFb2VDFP/LXu5g0SZbRdROQVVW7jDhWDQsozf6rNhw8PJpIP03lMcfgN4kHQqEz+s 02DsuowqJtAdtYYkq64QYKSHxZ5B6IdifkbPvnmbs6Whq/8yLDK0xn1fobd2ZEe2L+5o BDHD3GdfddWrqLhHzR92IzjWeuUaUaFGFCrNpw/lbkrdAz9m77Nv9x3cSFqj6O7FeXZR CP8RVKIIt+w3WtHXRu9osMhZDIye0BmivEy9+/LHVOOegHdMx8wisaZ8ZiEHcOu7Mirr Rekw== X-Forwarded-Encrypted: i=1; AJvYcCVQTZTXDL047tOgZnos/kWC41ngdrrw+E3sbW8TyIx1nzr6Vb7UZL4SmnS0GKe8jjBqRoUBVQaWnw==@kvack.org X-Gm-Message-State: AOJu0Yy35ZfzJNecexYFS/GVjmxcoOKPP2RNMN9zUnskv7QZTOP+cF3R lI4BsoU0P7BjUUBLOmgw+7yzATKa0tYQxo53CY4r2K0cLMaBvP+K0NwQPx9hOKHDNN1MC35+PT/ xV1QedH3pmw4rWnIvrOkISFYeODKx3H4RKMoRC4xYmIEQQSAQ X-Gm-Gg: ASbGncsQl86pdlARCfCUrgg5Q7MA0YYrybdU/M8WZM3kPJXvEPzvFzrmntYMtSOXJNq B0qhRbmiyvFUvr2hJCuoLTbzbtG9qYima2X73FiIuCX55lixKhxUz13LbVsRpjDMBHFRE1gZ/Wg s0nBAfIDYdkD5PhV6ncHsCP0xshKyeEjtCHEPBjpCPDnm8jWYJcpGCVa2t7Bbv1HGfwI5DgXtjg qfqw/Hea3ShsiwWxe+Lq+LK1yPPxJfbGdKBTynM68pWmFPUAzr9T06TkEvUMkezjVjhfMXJSFI+ iv7LzjwcaTF+Ry/J1P9fbqgPZudPDwWVf0yE4INC95k+El2d6zWyTUInvUU1lLqUrQiAGNGvkub JBrezoSACRfat2C+PeSnF8Mpt0swUem3x X-Received: by 2002:a05:6000:1a8b:b0:385:f47b:1501 with SMTP id ffacd0b85a97d-38c5195fd82mr8250979f8f.32.1738320965941; Fri, 31 Jan 2025 02:56:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+I+ynCeZEHXX+6WrhMhXHSL94RRp5D9nLI6LDBxYzej6H/Ex/I2OwQyT0gbWRqDVNDvdr0w== X-Received: by 2002:a05:6000:1a8b:b0:385:f47b:1501 with SMTP id ffacd0b85a97d-38c5195fd82mr8250948f8f.32.1738320965490; Fri, 31 Jan 2025 02:56:05 -0800 (PST) Received: from ?IPV6:2003:cb:c70a:1c00:b8d4:bc62:e7ed:ec0e? (p200300cbc70a1c00b8d4bc62e7edec0e.dip0.t-ipconnect.de. [2003:cb:c70a:1c00:b8d4:bc62:e7ed:ec0e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c102fcasm4451251f8f.38.2025.01.31.02.55.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jan 2025 02:55:58 -0800 (PST) Message-ID: Date: Fri, 31 Jan 2025 11:55:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 05/12] mm/memory: detect writability in restore_exclusive_pte() through can_change_pte_writable() To: Alistair Popple , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Jason Gunthorpe References: <20250129115411.2077152-1-david@redhat.com> <20250129115411.2077152-6-david@redhat.com> <2670f65f-e973-483e-aed6-526d00125ad7@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QOFDI4axaTmC2R7vWpx_st8VK92ZpGoLG71m8uXJDvY_1738320966 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8A41EA0002 X-Stat-Signature: dqbqd1kznnxjps1eh5dpujdiw7jm7b4k X-Rspam-User: X-HE-Tag: 1738320969-795872 X-HE-Meta: U2FsdGVkX1+dVrHOmqLNNUnmePhL9LxL1cH69Dfj/Njzthay7lyEkyLWzqJVTA24GtpoBRFMYS3NhPWcRi9RetiNm58+hyWDOFNyKw8KpExnOETXeF1vbWDtpAcZ0QgAQfhEkEu5s/QkMz2gOO09wPhPI8Xs/reJdScrMmNk6j0swB7Zd6Ae5Yh6rSmpdovyokXKnmnFKLgorsI94eGCxVqGeJNlX9HZJLMn9zIDpphrCoafEakAcGgVdSvDtGnmNw0gpCPjlNe25Cz8EorkUGhL2+9EroEapALdcuTk9V9BNln2VCWleChDsFG8X6Dl3K23sOGyx+IbXHRNPVPCo4AZENUKPOh0xA5IR+5xo8Yhy6O+a6O9+OwpVUKlDsEuvdHcIx0ohrzbt6CvU9SjQFMowusCCuw2Bbo9ZPQHxwyMGNIyPSHcuHWy4bNHNNSuf+0OWueycnZD0zbZRxd79U9TjkhTmei1pF/DCVlnO8AH7o4r71JQ6KkfOrHPH9zfHTCPSJ6AWuKUO3nY3Lcg5LXSbEeMaXnBe/mKa3UUZi8Eyqxd6W9SxZYoFWsr/GsgpVo0+TrGouoNVvWENDhTVUHVzIYwwAIW8LCodBpbTRbWKVXiJim4sWmy322rJO89EfMGEDm6+A8tI84MnCW999fp4X0G+5pE/kFzEjNVTZ5NDviyziQySUzn05q6HGn3yMBzkIG0me0YTsRrVPCr0SvEPNetFK400RQOTcibMB68+a+3IvG3eHK8cI2nxNafnEZgodN5IBiteVLwVXGt6RusZGm3r+875lOhV48TovPUcrBvAPgAqGEaPqtSc8oH9wt/xSjlNX1VHsAwJvOBuUzZD6jHEysqUjR9wmfpRWDV0NppRDRKx2fYL95yXwWtqNxpo+x0ZL2f/FSJYxF4ZXZCpDZ/R/bqNOkEQ/rdJGZdTev3y1xeYswTD1MJzbIgtUHYKNgG/4xx7yt9X+L 9JC+ZW2Y Snu0SHE5WZ3M3Fvdxq2ffUq8PvROPOVJN4GavBko6obG7y5N+dXgNdiCmU13Cisz2CQCaBhA3Dnrnf0rasFtOlzkQvJNP0aWdSclhcnrxZc1slCITxFexePqEc3JZ+U0+7SJYUhZIZV85IpCZ62ZJwmKyIOWeWAnGGS9QYxX2Uj0BkP2252VA65lQk1akGbZ/SzU0md86kiI3tQv341M+GB7/tEc0ZiItwUvhn3PQxmRUMpeqKGQblgitQ0fcRRV6Q8dfgAYMkN8b61sMfwcKx+5fPg36a/jYLQyVrBdPEzLJDx1zNDDNSIIKI3bsCojHLWXObFePlWk7bbRqJ9eHmiX3+8pK53GdlMdfMEQlEXroSpl1Xouz33/PoR3s3F6l/hsYVUBv9xlezSKNiXN9zwcaaL+ZXH6eDbniU7CYQyDrsYUCKkYWiYrvut1XGIZKGFiE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.01.25 00:06, Alistair Popple wrote: > On Thu, Jan 30, 2025 at 02:03:42PM +0100, Simona Vetter wrote: >> On Thu, Jan 30, 2025 at 10:58:51AM +0100, David Hildenbrand wrote: >>> On 30.01.25 10:51, Simona Vetter wrote: >>>> On Wed, Jan 29, 2025 at 12:54:03PM +0100, David Hildenbrand wrote: >>>>> Let's do it just like mprotect write-upgrade or during NUMA-hinting >>>>> faults on PROT_NONE PTEs: detect if the PTE can be writable by using >>>>> can_change_pte_writable(). >>>>> >>>>> Set the PTE only dirty if the folio is dirty: we might not >>>>> necessarily have a write access, and setting the PTE writable doesn't >>>>> require setting the PTE dirty. >>>> >>>> Not sure whether there's much difference in practice, since a device >>>> exclusive access means a write, so the folio better be dirty (unless we >>>> aborted halfway through). But then I couldn't find the code in nouveau to >>>> do that, so now I'm confused. >>> >>> That confused me as well. Requiring the PTE to be writable does not imply >>> that it is dirty. >>> >>> So something must either set the PTE or the folio dirty. >> >> Yeah I'm not finding that something. >> >>> ( In practice, most anonymous folios are dirty most of the time ... ) >> >> And yup that's why I think it hasn't blown up yet. >> >>> If we assume that "device-exclusive entries" are always dirty, then it >>> doesn't make sense to set the folio dirty when creating device-exclusive >>> entries. We'd always have to set the PTE dirty when restoring the exclusive >>> pte. >> >> I do agree with your change, I think it's correct to put this >> responsibility onto drivers. It's just that nouveau seems to not be >> entirely correct. > > Yeah, agree it should be a driver responsibility but also can't see how nouveau > is correct there either. I might see if I can get it to blow up... (in context of the rmap walkers) The question is, how do we consider device-exclusive entries: (1) dirty? Not from a CPU perspective. (2) referenced? Not from a CPU perspective. If the answer is always "no" to all questions, then memory notifiers must handle it, because we'd be answering the question from the CPU point of view. If the answer is always "yes", there is a problem: we can only make it clean/young by converting it to an ordinary PTE first (requiring MMU notifiers etc.), which makes it quite nasty. Mixed answers are not possible, because we don't know just from staring at the entry. -- Cheers, David / dhildenb