From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A529BC25B75 for ; Thu, 23 May 2024 20:40:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DFFB6B0099; Thu, 23 May 2024 16:40:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 190AE6B009A; Thu, 23 May 2024 16:40:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 009816B009B; Thu, 23 May 2024 16:40:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D59146B0099 for ; Thu, 23 May 2024 16:40:33 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9144B806EA for ; Thu, 23 May 2024 20:40:33 +0000 (UTC) X-FDA: 82150828746.22.230B210 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 7A5AD14000C for ; Thu, 23 May 2024 20:40:31 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ENHvKpTL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716496831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HMRwhM4rpgDOdhtnbcfTstE8zL3QawjuI32cVW7/W+w=; b=SCu+NHPF1+uqD9t6wugo59CQfQ6GB4j4W3cxaHAHmgjPi6h8fxQrn4flXULDpkZot5x/uS sLmMv8OX8GeX+SEX9DroM0xIScOYlEfYvVF/ts0yVRiR3JB7VGyYNjarhUQsF7lUZBojTk ZhIux5iZgTRNU+rEqxCLgclouZczNtg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ENHvKpTL; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716496831; a=rsa-sha256; cv=none; b=7L2Dvj3znfCPpzc3pYyEHTbBVxu7Nmp9Bh1x5Op0pb5kNBJ4XsU3pwHAVAEHjV6nUlDOrq /4gJFv7jgdbKAFp6/pDf4p5M+/91HQ4oNROjfwKdDSNYnSUDacMfVRTICIhvC0nu2AxKj2 H+olxQ+Fvrfz2U/fvLLT7j52/V6Ef+0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716496830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HMRwhM4rpgDOdhtnbcfTstE8zL3QawjuI32cVW7/W+w=; b=ENHvKpTLd0bouzPVkZIYjYu4+jFmt4WnWQqiEeCXcXHGCsAYcJfRw+5FsPn0oGI83CL+ga lNd9EHqfg6wNX+yr3PEyuleD1gIBxeeoRnbx9Ah+LnRoTr5c1SUM9qatgKOVSJOmkm9zIu AX3j15klDOcYhbnx4QdsFLa0mftc8sc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-6ACisBR3MXy_dZGAdDCpYA-1; Thu, 23 May 2024 16:40:29 -0400 X-MC-Unique: 6ACisBR3MXy_dZGAdDCpYA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-35559d305e3so25026f8f.2 for ; Thu, 23 May 2024 13:40:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716496828; x=1717101628; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HMRwhM4rpgDOdhtnbcfTstE8zL3QawjuI32cVW7/W+w=; b=eZJC8Q5eE9hEJBCZ+RJZ256DwrERHOfF/Na39ek3fHN8t/3cil49s/p/HKEHam21Wu /QncVvuwc+u+IUsgHVlfte4MOBvnGdZxntI2lGfX4z3Mhd/yABtrqYDyZbNqZ1esYthh ncfy/eq2amqY2TrouuQiC4lmVJvd5aX9b9tyJ3mDkWuAwg4qIlEyGbDeCcQc+6EFGTyi GkDnFwlSbAhiMdDQbPVomsHNXZRt6Fsj9OdcytgwvUEcJ4mU806SYnM7ahbs7anv17VU 7nlpHOSXyqF4ct4WEkkjnN2UmhcwSMXZ/TSG7LlHnxkmqiDtVvsCYMiHqh9yDxdOEfAe +aQQ== X-Forwarded-Encrypted: i=1; AJvYcCWrU4XGZC0nBWGD9rQfpsx/KB8DlFy/HbaJ7XPAE1e1PQfwQpfB7GrGAQf5P5CFRgkbunWYNjqjno9RBlDIDAdgnzI= X-Gm-Message-State: AOJu0YzLwJXVUCtNPU+zHREFPddoc8mYuS8HmhlxgNVepyHsuTqqF8qa 7hmyiTKl1RSeFTjE3Ddbm1tqS+cXL3VMo8z5MCmWGQ+DibhCSJkVTfgsUhCZlG9kCmuoqYguyIt rg+1W4k8f6IPps52SUHiZIsD9EtzguF2rx53pgFTuluyWqhT9 X-Received: by 2002:adf:f183:0:b0:354:f5f2:198b with SMTP id ffacd0b85a97d-3552fdc828bmr88019f8f.46.1716496827866; Thu, 23 May 2024 13:40:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIlHlYs/IzRViA3Kqxz4toDkVk96XetDA5NIaYKisMefLa6AGLghVkkUDvpvwpKUhwSEnXaA== X-Received: by 2002:adf:f183:0:b0:354:f5f2:198b with SMTP id ffacd0b85a97d-3552fdc828bmr88004f8f.46.1716496827449; Thu, 23 May 2024 13:40:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c717:5f00:c949:6700:cce1:e60b? (p200300cbc7175f00c9496700cce1e60b.dip0.t-ipconnect.de. [2003:cb:c717:5f00:c949:6700:cce1:e60b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-355049af3d9sm514554f8f.76.2024.05.23.13.40.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 May 2024 13:40:27 -0700 (PDT) Message-ID: Date: Thu, 23 May 2024 22:40:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages() To: Andrew Morton , Donet Tom Cc: Shuah Khan , Matthew Wilcox , Tony Battersby , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ritesh Harjani , Mike Rapoport , Muchun Song , stable@vger.kernel.org References: <20240523063905.3173-1-donettom@linux.ibm.com> <20240523121344.6a67a109e0af2ba70973b34b@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240523121344.6a67a109e0af2ba70973b34b@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7A5AD14000C X-Stat-Signature: qp8x1o7xd6ffurgbrwautm4kwgitsbf6 X-HE-Tag: 1716496831-616049 X-HE-Meta: U2FsdGVkX1/Gknie6Msy1sNUW73VJwExwKZayZKTVUcfcLiOCAxSy2WfwEmXdyqPaiM7ruPUsyG0HtsDfES1mtBGziPXLojAu6+vFaRjnh/lbqM9SPNJpawacU+thM2omKzzYIxrBkR2c9qlaTAjrtyYI+TMN6wgaGTY124VVQ327VQz5cEcgV8t/kDcL2VulCY2LI6CaKbqq2tBKZvww1BcUNU0mjNwGojU68cvMLMqqWJwTZmkKZiGWRDoPebm6M0ugkaDFTyhGJgmIhSJPGjMl61ZqQAfHUE2+D+C6JVQxX2NbFhwmnKCeGeXKp9UQHnxy/v1gW7nkD4cQzZXf82xiTT9qev8dWylHj+7uRX2aAyo6MgpVm6ckxrwuGI6QVEsHtsS5gUnH5QVXEJS1c9uJ6VGi1gmJFlcIlZLh3ArcGYfZagY356DKOkfd95DcBLLqiY/vO9bdlb4T2WLkYI2dU2Ajp8WGcwVqEG45Vp8OqqlgkgDUAebbyQkPQ2C3PD3w/V3uqleeV56Pc5hHykpV9nd4H/Ooubs2aurYyOzAMldh6uPAtJlF3A0zJzZSnUbJ7516q0PPNewIR44Ymq+Y+aWehbKPV/F9yMwosljQPzJC6jrfclAgX3n75JnGsTXqYggN1+GUowEZPPU1zK3xESyun6lptxyq3brWvetEFcZonL9m72mIPDTyaqNEk2rn/C9hMxmbKHxj+9Da95Qe5W5pOqd1BEhq7q3eb3lwg/fWNIdV5XixbsS1G81SXD5EGrAhZPRXlGOU4UK/yowd5+rqPZUd9dhp1yYzO+2Dv/Z4lYIJ5plhVF5s1gpmmz8BN8Qi6vC923dg2JPjVWvQ+FFhTjtmY1Op+Mp6d0pZg4jpyV2W4aT1g77k9d/jZI5rbfl9IuoU+viqX41115big92Vq1AgKp/lvvtmYFElUijZpDTv+GRS6Jynj7f12mSw29z7KMvBqOOQu1 ZUfi/5yx upTR6a6EQGkCIx0q6U7lEFF/T72SESkHEd33rjZX75Vowdp/komLmul8Gy4XsQTANkTzPsmq7djTsKeFNyLVhjIV/UsBXg56k68bHtJiKRqGFJQlExN6DL5a1hGpKxu+gmuszNzTWnA0xQI2h8TMVu1xHa3/53v7rYmUvstoM4BGBhRA5xIn8lgwH0rgrbZXhrogbDMUADf3Sph5vqNoHmGmDEtD2dudrQXnTh6U8jBVXP4k6rhmQI5Jjs7Dj6XZCg2VPmRXsKKDNCQ6v90X14ZBARQlbHsxSEz/A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.05.24 21:13, Andrew Morton wrote: > On Thu, 23 May 2024 01:39:05 -0500 Donet Tom wrote: > >> Commit 1b151e2435fc ("block: Remove special-casing of compound >> pages") caused a change in behaviour when releasing the pages >> if the buffer does not start at the beginning of the page. This >> was because the calculation of the number of pages to release >> was incorrect. >> This was fixed by commit 38b43539d64b ("block: Fix page refcounts >> for unaligned buffers in __bio_release_pages()"). >> >> We pin the user buffer during direct I/O writes. If this buffer is a >> hugepage, bio_release_page() will unpin it and decrement all references >> and pin counts at ->bi_end_io. However, if any references to the hugepage >> remain post-I/O, the hugepage will not be freed upon unmap, leading >> to a memory leak. >> >> This patch verifies that a hugepage, used as a user buffer for DIO >> operations, is correctly freed upon unmapping, regardless of whether >> the offsets are aligned or unaligned w.r.t page boundary. >> > Two SOF, is there a Co-developed-by: missing? > You have stable@vger.kernel.org in the mail headers, so I assume you're > proposing this for backporting. When doing this, please include > > Cc: > > in the changelog footers and also include a Fixes: target. I'm > assuming the suitable Fixes: target for this patch is 38b43539d64b? This adds a new selfest to make sure what was fixed (and backported to stable) remains fixed. -- Cheers, David / dhildenb