From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D4B2C433EF for ; Tue, 23 Nov 2021 08:42:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C1036B0073; Tue, 23 Nov 2021 03:41:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0707F6B0074; Tue, 23 Nov 2021 03:41:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7A996B0075; Tue, 23 Nov 2021 03:41:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id D9EA96B0073 for ; Tue, 23 Nov 2021 03:41:56 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A00E01849B256 for ; Tue, 23 Nov 2021 08:41:46 +0000 (UTC) X-FDA: 78839551812.04.BFDDF2E Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf12.hostedemail.com (Postfix) with ESMTP id 58B1110000AB for ; Tue, 23 Nov 2021 08:41:46 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id c4so37509943wrd.9 for ; Tue, 23 Nov 2021 00:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=g0d3QqsCZsAQe09AQzK3FGjRTfaWx8wJ4QGwqSaUY0s=; b=Mw62+XRWvlT8qzBeQZ/h0IBf67LqzhudM5xDapZFn6GgfYhCFcPBmka7Oj1ocwxvUQ /cNvmDmqTcYcrSyuuxeDgHc0xFZUqCTComJMB86gBn2KEDpFumMcEqIXhxSwB6YMjubD lt3NXPRM2NtOwMMqJs0LE8AhzdddiT36Z6qT5lxRIodNyCjTuauigZnaHO1DCx5GVDql epdOGzox9iGOjYi+i7ugyfur4oshX7Ze5oXbADgUgZ+gz+Z0B8y4Vn5a0HN+V8Nh+J7S HwMyR5sLcNaGdSCjB99j7FaSlB31s+kjOffJkUhXlpnG/VQ5xi3wdnNC3HpGS7PAxaV6 VRrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=g0d3QqsCZsAQe09AQzK3FGjRTfaWx8wJ4QGwqSaUY0s=; b=GHm/8fQedasyLb11GN5Dgp/VGFNXwnMIFKlxMecIWs02MoSBBXzfHWZTbFbxLwg+Gw T7pzOGW7oALuFEPkLs23v6Bv5wRXhep/Cu3rkqfvjo9C511PD3qo4ia6hG4BegMdcH9k 73a7F4gfVJzKpLudwsSJgZiKshENuJrJF0TBLvXa1Jn5tRPww3fZ4UxqSp3OwKfPiYYO l70FwIiA6rqxIHIVWxnFCKS3cybYchQk3IdIsbHgLmzuApXKWE0D4j5DQzO/QClgbssi dkzWIcgOhaG6529gbTd3ii+dQ7dIgCq/MQSAYf7JCzE10Q7FWN06nnm3C3GVP4xvye4U 69vA== X-Gm-Message-State: AOAM5302TF4vt07wJ+N4n4RogrxpxtD6f2AbXbKzFJm3r70OJ1Ct9R3B upsgSkyTzfkiZ9Psm27AAk0= X-Google-Smtp-Source: ABdhPJwvHgZSqW8ZEVCAO/5N69oBusE0Bm0f9EvZzy4r53G0pOj/QfdnMwTLqTwvVRJp7btLIQMB3Q== X-Received: by 2002:adf:cd02:: with SMTP id w2mr5046687wrm.269.1637656904964; Tue, 23 Nov 2021 00:41:44 -0800 (PST) Received: from ?IPV6:2001:b07:add:ec09:c399:bc87:7b6c:fb2a? ([2001:b07:add:ec09:c399:bc87:7b6c:fb2a]) by smtp.googlemail.com with ESMTPSA id p27sm348736wmi.28.2021.11.23.00.41.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Nov 2021 00:41:44 -0800 (PST) Message-ID: Date: Tue, 23 Nov 2021 09:41:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [RFC v2 PATCH 04/13] KVM: Add fd-based memslot data structure and utils Content-Language: en-US To: Chao Peng , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, qemu-devel@nongnu.org Cc: Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, john.ji@intel.com, susie.li@intel.com, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com References: <20211119134739.20218-1-chao.p.peng@linux.intel.com> <20211119134739.20218-5-chao.p.peng@linux.intel.com> From: Paolo Bonzini In-Reply-To: <20211119134739.20218-5-chao.p.peng@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 58B1110000AB X-Stat-Signature: q1i4938tqowixg9mrazbxsfu9arbskqk Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Mw62+XRW; spf=pass (imf12.hostedemail.com: domain of paolo.bonzini@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=paolo.bonzini@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) X-HE-Tag: 1637656906-494176 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/19/21 14:47, Chao Peng wrote: > For fd-based memslot store the file references for shared fd and the > private fd (if any) in the memslot structure. Since there is no 'hva' > concept we cannot call hva_to_pfn() to get a pfn, instead kvm_memfd_ops > is added to get_pfn/put_pfn from the memory backing stores that provide > these fds. > > Signed-off-by: Yu Zhang > Signed-off-by: Chao Peng > --- What about kvm_read/write_guest? Maybe the proposal which kept userspace_addr for the shared fd is more doable (it would be great to ultimately remove the mandatory userspace mapping for the shared fd, but I think KVM is not quite ready for that). Paolo