From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE2A1C25B4F for ; Mon, 6 May 2024 18:35:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B1F76B0083; Mon, 6 May 2024 14:35:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 461AB6B0087; Mon, 6 May 2024 14:35:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3023B6B0088; Mon, 6 May 2024 14:35:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0DFD86B0083 for ; Mon, 6 May 2024 14:35:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C84C7A0FA5 for ; Mon, 6 May 2024 18:35:48 +0000 (UTC) X-FDA: 82088824776.19.7739545 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 835C11C0002 for ; Mon, 6 May 2024 18:35:46 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hzbmk7uu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715020546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+39y8W7bsu1hCnW4m16/3q+glmJjCJshByFNqIk6Vk=; b=UosiD9I4MEcGC29BEj+hO139luSvLhkwF7fBWmukBwmAIl6d7kYx4h3cuXgx6/9De45kMR 1g0+XzbiZiE/dX/aA64ehTCaKlBxuEY8b0bQ7/LA3RVJ2GuEQG42tO+/Q4KUFlwq5T/awb toEQpIUyBxzbd8dXkG4UMHEHapCtgF8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715020546; a=rsa-sha256; cv=none; b=3/4pfVdjv0ChkQIi20OWsPQLV9k6Qsw7kntcnFB4RusCeN+N88B2JhZ0/WWBMpG9bw8fpx uIAYsYym31M+xdOkMC5n4h/JR3SBmAfb5eppP+ztLlR/SwwKEL9ogLm0NvD7MpbbsxDiZp SNYkZJtsvoSGd8mZYVuozKZhEy3+YCs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hzbmk7uu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715020545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Y+39y8W7bsu1hCnW4m16/3q+glmJjCJshByFNqIk6Vk=; b=Hzbmk7uuWBPo8Pn92vBWe4MTuE/KDEULclK5iHYSdOmZgE226IgkjVM2P4f8/8sxn2hNFG YeYTJIeWLrLUf23Gq+V7UldrmuzSDGm824gPRxHgR1Mx/znNKLujL3fjzZmQD6wsRCOLh8 VaPYfmQKfd2uwJUaHM4cNrKrhAljjyM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-J11U3l6JOoilTeUMc5w_og-1; Mon, 06 May 2024 14:35:42 -0400 X-MC-Unique: J11U3l6JOoilTeUMc5w_og-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-41dc9c831acso23167905e9.0 for ; Mon, 06 May 2024 11:35:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715020541; x=1715625341; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Y+39y8W7bsu1hCnW4m16/3q+glmJjCJshByFNqIk6Vk=; b=peIZWjB5tVqmK+jqy+Hy6CdkdTWqVCQEPj1X9mG7YE4ndorW+W6Uc8MDGQkHQQlZYs CZcJbzQDaqn+EvBP3LO+E0yM5PbNRg3Q3uMOxgIE26R25mqU1N1lh8RlHugbEkahlegD iUmwLOpz3RFY2GZiydD5K3CkF7kss3aVOkxaIcu/QGlTnCgc6xwFEdc8pvg87PovqAy3 2EGF2GePfAJLlwF1xdwXKBfbqm/fg/WJ6i6RhcTFqTI9mSRYvqpLUvxv+FtfVRWuFQZW YMahpVhctf/1irOyusviegdRTQqZTeBqmMrp2g3NoWBs980qJ6AdRpdjciy3l16QsmBR kuGQ== X-Forwarded-Encrypted: i=1; AJvYcCUP4/UFVYvtEsCdBP23cg1NB21uQXOB2SbmuuziLoYp1sQw5j/RhJK8XGfoEvBAmziMXRdqqyIRc+s48pTw2iMXgkY= X-Gm-Message-State: AOJu0Yw7vL/e17vNx6RoBI1POMuelyL5YpOGtaEn6Cjn6I/oRFKnZAYY WuMhJJf216WL1uUV8+3CSOFlEsTKGqv5wpiwkFIIfdpWIeI+dvqcRIGgrTwvORaY5Noe0LFGY30 +JVewMwn7zptsW0b7GDG41XlXp0uWoaCUWs/i9MclDwp7hP9t X-Received: by 2002:a05:600c:5128:b0:418:3ea8:46c0 with SMTP id 5b1f17b1804b1-41f2da2d4bcmr4054805e9.13.1715020541364; Mon, 06 May 2024 11:35:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2E7Ba0oxJpZZi2hopWvMu8kafXg3cs2sCZQKS4ImBu+OW4F3n5S7V9fMwBMfDy8QCe49/QA== X-Received: by 2002:a05:600c:5128:b0:418:3ea8:46c0 with SMTP id 5b1f17b1804b1-41f2da2d4bcmr4054605e9.13.1715020540974; Mon, 06 May 2024 11:35:40 -0700 (PDT) Received: from [192.168.3.108] (p5b0c6c2e.dip0.t-ipconnect.de. [91.12.108.46]) by smtp.gmail.com with ESMTPSA id k5-20020a05600c1c8500b0041bab13cd74sm16901414wms.17.2024.05.06.11.35.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 May 2024 11:35:40 -0700 (PDT) Message-ID: Date: Mon, 6 May 2024 20:35:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: do not update memcg stats for NR_{FILE/SHMEM}_PMDMAPPED To: Yosry Ahmed , Andrew Morton Cc: Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+9319a4268a640e26b72b@syzkaller.appspotmail.com References: <20240506170024.202111-1-yosryahmed@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240506170024.202111-1-yosryahmed@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 835C11C0002 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: gy8grwbqu3fenfx7djz6umgoirwqec9g X-HE-Tag: 1715020546-165075 X-HE-Meta: U2FsdGVkX1/gykAb+vOVe3R8xfUYeXgdXUUt1LoIhg7S0dyjqpBHlSVljVoT6yjXzf3oG5Dh556QavKGMnfdAf5iWyv56zsYOyzVOUFzy0zTkcj1+S8SCIdb3xJhqRt4eN8V0V/mK7QnMjyxvVHziLZQ5rruebTwd9vIYM61QGaypmKrf3uLxxgKcNnD9OvAxVfpiDVAmy/QfwQhIL+kjRo5mqYmV8Sje7dw20ml5gbC6HspY8P+pA9wZocRcz9XPPlRAQxkzu/QQESooS5a8GkMBhtCrTOWFaWPNhemcmQfqlAPFjOBwDAjsHh9LtYtnH3kcCwidkVBJP9Wq2ImjXdcHBnFd9dQJuHZsfc1xqWXeLuPAmwr6XaHidPMV52zIBBSaCWwCGao6RPlCAPChNPEJsZGw5o4m3tDrAzLimNO6o1wJGnc2rNYFiYByYi2M1tnKxkoD+bu2KwHQwaqmBKLiUFeN6JOckQenvHlq396sYS2noekdU2VC4l1xC8nyATcJd0GPZY+1zS7zDbK/nB0zAOBh2LqTKWJwyNMCZ88vRhSYeXoZFlst3O3NxaBlJvrvpLgLLu2PHuZI5QtWRsmiby7paAXOj7OeufuB40cD3YX+9VmNExReV9+sSkSck1Zdk5UpF23OnDZnSxkzQmX3TAQZOO7KHKLxYK2kL/61pAm9ct7DUG+JdtVAJ8E/jJO4+pEt4GrYx3wax87ScRvyiGpsWFwgTYj5DZPrE3cfFoHuK1OvN7de1y3dalxERGn6LQbk8mGwVTlShNg8CdjEzU5mIXDVvW35RIA+AU47GvZDcXTLBFh3vguaD+HrytYMC8KGLMw7paLkcE1E/3BqZ1NejJBsIbNUUwuAwB6T2966zmZPHWw8pp5bryzD0h10mH72GkAjXUXY9E6r1rkMtfIZsfOGKIM4DjY3u0WMNe2692wjg4a4Wo9i/DVWhtz/7NvpkbruDrzbVg ICVEn8bD gi2dQaw7XkvRMc2FE51VsdlpqfwRTRXqD2uVv1tUXbOaXJFNB5pRoMZzjmHf1EWyfdmwSR24Q2iWwDFvRuvHxFTB4N/u1C2GfPfDO1jfbG80zQIBhhEfZYFiyLYzZ0RuGGRcJSkGhMn7RIyIUBu1lihmKiKOOHj+OVuTDQ2gfKRla09h6mTPOl7y9EMIesn0RnWFZDVzc33AM/OYQ+e/BUlfGywrCoyg+MLspA0M9SY0kxUuDfm1l55xzmGZ5xsOUkF0btWzI5lyc2cvrVLHi3/7kL9Bnb8pgP+HCHL+Yc4c9wcsC7VPToQ1BKLJ22Zojs+QZ+/Gzeee4V65jjt9jGDSWG2r7nmwRHrHT65nXdWDGecduAkJPbzUBOSfsqd8Q9/ZqqZ6opYkhVhfRrLXYzcE0B1sbc8HiOc7Li4Itqzg6ghQCc6ARUMBLsJmkNo2vfoILhN2FWTF+G4FKBR+Z16rdkkdxFtqmSBnEeB93Wsz65ZRp90OBYdhIGWsbRbEh/ZP0VFWep71L9r0k9eF7Rz82kICMbY1vSjdIM847uwXaH584vASgqb7TMw4NuTpMgeTW+ecvUac1Yju2qP/GXeU5IMRviUcBAUFrM+WqzjsjObXmp2nnNs1QfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.05.24 19:00, Yosry Ahmed wrote: > Do not use __lruvec_stat_mod_folio() when updating NR_FILE_PMDMAPPED and > NR_SHMEM_PMDMAPPED as these stats are not maintained per-memcg. Use > __mod_node_page_state() instead, which updates the global per-node stats > only. What's the effect of this? IIUC, it's been that way forever, no? Fixes: ? Do we want to CC stable? -- Cheers, David / dhildenb