From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA19AC369DC for ; Tue, 29 Apr 2025 09:40:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 219246B000C; Tue, 29 Apr 2025 05:40:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A5896B000E; Tue, 29 Apr 2025 05:40:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01BD06B0011; Tue, 29 Apr 2025 05:40:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D44776B000C for ; Tue, 29 Apr 2025 05:40:27 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CBDED1C9FB6 for ; Tue, 29 Apr 2025 09:40:27 +0000 (UTC) X-FDA: 83386586094.27.3215C21 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf27.hostedemail.com (Postfix) with ESMTP id 087B240009 for ; Tue, 29 Apr 2025 09:40:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VuJOu1iL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of hughd@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745919626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=887j+HuJAg3GAFJi8re61kxKscTlK+O7RQ0PqOMN3wo=; b=wATkEeXhamhdBisda3v4WzaSzB+MJfDUGOe/vXp/HgQYkUzFjKC72Af3yRWhUkDI9/E4np G9ZGLCPOKBx0oWzXX3BU6RjbQ3N1XWNBjNQJrBMvfo4pZe/ZO6IC5SfWFVXZub6j2bKgCN lXlFwm89q1cIiOHEoqCsS1xv/hBo9SY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745919626; a=rsa-sha256; cv=none; b=59UpU8nHaY98g+Tz6Qq2cRv8n4+t3c0V8kbNKDh8UkTjuBOSoR7HinMVtn4Sc+dkLawe5g kPkiDriYUtqHCXogHH0biBI1Dsi52OiFlM+4EVvq1z2br5jAaH8cJzLQscFL5p208NqoPM kG2gZHnGMqJMrIbT8yQw/OzLRdObSB8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VuJOu1iL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of hughd@google.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=hughd@google.com Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-22c33e5013aso68332925ad.0 for ; Tue, 29 Apr 2025 02:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745919625; x=1746524425; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=887j+HuJAg3GAFJi8re61kxKscTlK+O7RQ0PqOMN3wo=; b=VuJOu1iLl39mZ5bOuccO1pFonYU7DE13PGQvnAdc/cipDEqkRMuAzu/MdtWdcx0LaH VqlijZawJAioq+EA/jxLOEjL6jmoagJ7a3VWqrA1Y2zaxp7rXYQKhBVrjji8UqT6/YYY IeKKWkFS7PBc8EEekezkrwqH1CsgVeGF1IZ3TAB5HmdU5aPcENFotSBMSE1OsjNa7KcN 8xevpn2vPoa2KvxSA7jkmnIk/Qd6kzSsi84912Hg5k4HHwTeuhSj6bOu9H1QO3cCbtpv /TFt7j+B7MyunOHohcrUQh+8JBk4ps9trxatGpLNJ/wTiNDg889XuwZRXiQc84BsWyX7 zaCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745919625; x=1746524425; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=887j+HuJAg3GAFJi8re61kxKscTlK+O7RQ0PqOMN3wo=; b=HdLMPzSGlu4cAQ2K0yk1HXGaze8qjNYUhumm87Fa1XTbTC0RxDUJPeMk88w8JlwQL2 4zrU60IB1hmYtDA7T/YTFxno//fYTOI7h0awpKPmVc1jL1rj9ZylQaSWKH8WqCT91XUs MXd1PaIKIcg5QJZAcizxawx2OoZIwR3y+I5wCbnXQMY7jQDGxZzXueQ/Rh8so5k3NSIg dX2oNCGsGfacBH9ZY+JqyBkbAHWhUFGvsf59vl3/rxYuPhGJVEowLOoxsQ0smz74wnU9 hDLlF0PUbrp/Rul8ltCB7RXcbB7FUo4lqku6zrGM2XHAx5EELuoelcr9vAYAkuF+hDPj Si5w== X-Forwarded-Encrypted: i=1; AJvYcCV6QXwynq99qxP0UTfe+u13OSi74f3hJiQNz5Vrhl+ox9iuaeTUC1yUuStBvTRm2FaYUmtL/frEQw==@kvack.org X-Gm-Message-State: AOJu0Yw1EA8uKIOKPmqxfkzC8PzrdJAIJgJKJ+100t4OKhrHLJFY9vgZ 8EyFRupWCTnuXGEP8ZeEX0T0gFWtVdM+2F9yEEAbWBy1f+Ah9wTwyrYOR0DyLw== X-Gm-Gg: ASbGnctsgqNzPA5e/rz/vCBMaAy2BkQEa5SUNMjtDVS7OgtcRMUxhNcrvxse4HE4hqj 6i2h2EHmSO3NpWyekNYaExmLoti2X92zAmxiFY4NMIKDwtpffaRnowmEfOMGiu8Mu/uCAPZKAQS FVL+6ReHqxmmgTTvvh4DQbUcxKPcz5AEt6PFSC6jqO887fOjHUX1RTdK6J+yEl2gVt7XYFH9DdG X2Oy1XWMZKDcFlRNbREA4SV9Wn303XUtU5Knca8yJAxBF5FaZfoiKV97FxBIzNzHVzHTqoqc7nx PgkUFPKLeuYSGoTtrpA5svWEyt0JLAie7d6u4l39jOohi7sR5kf/+UWCsidPc/3xJzM3RAj6tET ZU0L1AD0ktBij4mg1BMLnf0xs X-Google-Smtp-Source: AGHT+IGJzRx+E9AYOKH3V9G8U9AElamVc69ogYXshkqnP91KceEEIHQZBBI1Oddf93pxjy3KZrE5dQ== X-Received: by 2002:a17:903:2bce:b0:223:4c09:20b8 with SMTP id d9443c01a7336-22dc6a6c91emr166079865ad.37.1745919624658; Tue, 29 Apr 2025 02:40:24 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db50e7cf2sm98181285ad.154.2025.04.29.02.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 02:40:23 -0700 (PDT) Date: Tue, 29 Apr 2025 02:40:07 -0700 (PDT) From: Hugh Dickins To: Andrew Morton , Shakeel Butt cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Jakub Kicinski , Eric Dumazet , Soheil Hassas Yeganeh , linux-mm@kvack.org, cgroups@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: multi-memcg percpu charge cache In-Reply-To: Message-ID: References: <20250416180229.2902751-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 087B240009 X-Rspam-User: X-Stat-Signature: 3zuxp7tnot4pi76jhw9tokyra9i9myo9 X-HE-Tag: 1745919625-119768 X-HE-Meta: U2FsdGVkX1+gl8UkTDdlMXRunbxrrMiJVz338PwXbUf2JzNsn4keWnjNOdscbfwuH+TE9OiuI9pv4oU4wvGdE8eWwHfIbtteB/xvZLR7W7LWqUaaZ9YITbXFfJ4vWKmRQwILZI21oKmcxZfoPERZyeqJZbhBDaBlRnZAjpaxDSsTHJXSiFFmCb/LuJLnczkJS67MUiGSaBR4PyNkkKwcJEP4wadgg7cXd9IYsglbO+sULUXLvGsFJQLLZd/s4UQ9tG90amwBYxMPv1/ObED9llscy/EH4utrANj5nMV+cL7qVH5/EjYaDXliaYfBjG+NeEr9BQr9IEkV4YmFALq1H1ZepdcQA0CdBJD1VPv8742NpGuuFivulngbE8rh7k40Tfb0oqqW7WVaQR/a8NHKJqtjWsGQl3I+GvNImBSTFq837DxKuHAt1g4OzIP9gOT9oOGSX21CvqisegTaE2U+/D3DUJuaHoTBgoZUe5MSLjJlJW8n++aMoXtZE1bV2uMU8zEYew6fGeQFM0z2SeDhEK+NJ5NUjdQdMiL0+QfTx3UwnAF77MikuPAG50soHf2z+jhZdrqs8x3C48E3rqRZlHt2uSmh9hzVX83zXHLsH4fdK+jwHAftDogTg52vMUR+n/r3m5527Lgr0xqAU1/qyOc1wVna4cOubn54eIYT10VzZ5YJ8ODiw5LemPpPGoWWbbrk5DV59Ea3cl47OWjdiL/m7IYrDXa76z20DDolCxgmWToTl3dDwwbq7X1MYI2B6QVm2o+TO+O8n/ijKAoiGPOkO3fzN+7+pSd2271Ps/abIa3MxbyBAFLoCSi76bRzMvt07NIpnAOuG7zkx/oTvzNAMoEvyhls/6yTvlf/HfcYVtJDOwxIe1628krGRenwfdLj2uTs8g4+rIJp1yAzqWI4wK1NR9ooTBGHhIsjlIYS6DQxeaouJstAdOZEZp2zUFgxDLmIbDT4t3sIjNn AcAJM0Z+ aI0KiBRBImvflvXm2JuyvGrl81FUwbz5vnOrRwP5Fo5Jpi1gOQpM0X8YFaOhjG7eZc8/bU4DRYfxxCKdIk+WiccsKf6fdWzsjT8cxOB/S0e0ShYaG/8J/hlhDqfT4DcuDt0KS90P2VWpuy4ZHeaqWs9rBcoWbzAdrgfUIlP++cyOOOOX5EEpC+5P/rjjtHnYXZaMzOYaPP/gW9JwFTe361zkFIIoOdFk3n1l3Qt5B5IXnUObodYC/T+dGl+N0YcbL6CrR7qlXO6wLmlaQsAdiZI97DSwLsXqQDI9eMeDrXpaj6J/Mfu7zByaLshGxWumISU2dJS36EfFefIE9lMxwlK4b/5wE18SGUNgX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [PATCH mm-unstable] memcg: multi-memcg percpu charge cache - fix 3 Fix 2 has been giving me lots of memcg OOM kills not seen before: it's better to stock nr_pages than the uninitialized stock_pages. Signed-off-by: Hugh Dickins --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 178d79e68107..02c6f553dc53 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1952,7 +1952,7 @@ static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) } css_get(&memcg->css); WRITE_ONCE(stock->cached[i], memcg); - WRITE_ONCE(stock->nr_pages[i], stock_pages); + WRITE_ONCE(stock->nr_pages[i], nr_pages); } local_unlock_irqrestore(&memcg_stock.stock_lock, flags);