From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452CDC4332F for ; Mon, 7 Feb 2022 22:49:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3B576B0073; Mon, 7 Feb 2022 17:49:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC20A6B0075; Mon, 7 Feb 2022 17:49:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93B7D6B0078; Mon, 7 Feb 2022 17:49:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 7F99B6B0073 for ; Mon, 7 Feb 2022 17:49:49 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 41049918AB for ; Mon, 7 Feb 2022 22:49:49 +0000 (UTC) X-FDA: 79117477698.13.F9F0E95 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf27.hostedemail.com (Postfix) with ESMTP id 9415D40005 for ; Mon, 7 Feb 2022 22:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644274188; x=1675810188; h=message-id:date:mime-version:to:cc:references:from: subject:in-reply-to:content-transfer-encoding; bh=kCrDIOrEFsaqkXzsZbh8yWB/DwYaGsvCXUnA57EV60o=; b=LlqUYr32VITGxoE8SLtNJhrPFN4DQ46wt3dMIdwzjhSXZNwuyXz/N2jF KOTCk4szkS1gq8XZn75j6qmyNH/l9Vy/GKJsq14LylUVCPPmdbHE1KtPP Kv2Cnex897quxuAmNR9OzWFFCh+D8ifJGhHw4QPOcuvMPJCsMwNH2P4VN 3EqGeA9zYuSLGPoqmtK6KPWp3Q5r0WBFmFRpQm88MlfbyoJxPCeWArb7T XHhz2NXE3M3Q1DygpWmouUEBIW5OLOA6qswOEiBBPZc0Zp6hRxJPvZS7K s0iWg6iMpg76wDb/WOE36cF503CyDyg3IBa0iOSdm32ebgILitjbQip9L g==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="273348608" X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="273348608" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 14:49:47 -0800 X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="525309179" Received: from hgrunes-mobl1.amr.corp.intel.com (HELO [10.251.3.57]) ([10.251.3.57]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 14:49:45 -0800 Message-ID: Date: Mon, 7 Feb 2022 14:49:45 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V . Shankar" , Dave Martin , Weijiang Yang , "Kirill A . Shutemov" , joao.moreira@intel.com, John Allen , kcc@google.com, eranian@google.com Cc: Yu-cheng Yu References: <20220130211838.8382-1-rick.p.edgecombe@intel.com> <20220130211838.8382-5-rick.p.edgecombe@intel.com> From: Dave Hansen Subject: Re: [PATCH 04/35] x86/cpufeatures: Introduce CPU setup and option parsing for CET In-Reply-To: <20220130211838.8382-5-rick.p.edgecombe@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9415D40005 X-Stat-Signature: n9o7efok163nb7oppwabgjjdxuncsi7j Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LlqUYr32; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf27.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=dave.hansen@intel.com X-HE-Tag: 1644274188-660176 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > * Some CPU features depend on higher CPUID levels, which may not always > * be available due to CPUID level capping or broken virtualization > @@ -1261,6 +1269,9 @@ static void __init cpu_parse_early_param(void) > if (cmdline_find_option_bool(boot_command_line, "noxsaves")) > setup_clear_cpu_cap(X86_FEATURE_XSAVES); > > + if (cmdline_find_option_bool(boot_command_line, "no_user_shstk")) > + setup_clear_cpu_cap(X86_FEATURE_SHSTK); Given this: https://lore.kernel.org/all/20220127115626.14179-2-bp@alien8.de/ I'd probably yank the command-line option out of this series, or stick it in a separate patch that you tack on to the end.