From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B9BC47071 for ; Thu, 16 Nov 2023 06:00:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DFF880024; Thu, 16 Nov 2023 01:00:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 790896B041A; Thu, 16 Nov 2023 01:00:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E3F380024; Thu, 16 Nov 2023 01:00:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4FF666B0419 for ; Thu, 16 Nov 2023 01:00:25 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D6D5B1A0BF5 for ; Thu, 16 Nov 2023 06:00:24 +0000 (UTC) X-FDA: 81462767568.30.25E8E55 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf08.hostedemail.com (Postfix) with ESMTP id 6BEEE160023 for ; Thu, 16 Nov 2023 06:00:22 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=CJZdVpVl; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf08.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700114422; a=rsa-sha256; cv=none; b=g8FgbqeZ7C2vkPhEZQAIugD/bMM7bz2nGA4uMcIGr4ysaO+3hagHtkC+mGFUqngnAF3ffz ugKrZ0pGnqDOej5kBkXLz6vdbkZEhtrHzvCqACXLpCH5HHUo2puTg9mfKMwDkRVwUcFdH4 hcxmYyFSteu++5PeOfuphr2fH263UCw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=CJZdVpVl; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf08.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700114422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4RUl4sy6K/1DgzRhv01u8hafszHwGqxmAcX/EgXwkro=; b=8UORN4ZYsnGZPUrz1oSOQ7XTU1PmRf9Hb6yEbqd7Uqj5kI7ZcL+DUtJcJ6ZJZbmffDTPrQ tfnCnwYc4fKwlaYv6xFGvtt+ry7TlWpRjMaE1zQUa44JHUuS6OgVVhhY8UX16+ff2stS+Q /vM+8TI8OY9/TJ4rm7d7+1p2VrMtU2M= Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AG3m9u9031688; Thu, 16 Nov 2023 06:00:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=4RUl4sy6K/1DgzRhv01u8hafszHwGqxmAcX/EgXwkro=; b=CJZdVpVlx2zod3bnYkTlNWJqsHSHYfY5xeD96BSPjt4mHw6ogO/7gLYsqkq0IGfVqewS cKNQmhzVYxddoMLHSA0QNPklMyYmMLB29SocVuB7zNcdGOoeET1ebjY32Ch0nbnJCcQ1 KvOdoHVPb/v5cKRZ+muP31C6lzu3Q3w3rXLRVzeQatoEQpE3tc5Y7nFqXyhtwD0r/xe4 jgSc132yFUyuqNmIH1Xec5X1LeQljG8uQRo5y0uJXN/z66vy0iC5k0tftSrr8pU7vp/Q gF2Vcag2pXjWDcvF32gW/QOdxivfVT+UGPFeP972SOUKi9IyYTP1MID2BG4B8D5Hq9tl Vw== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ud6ecgrpg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Nov 2023 06:00:20 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AG60JON009028 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 Nov 2023 06:00:19 GMT Received: from [10.216.59.111] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 15 Nov 2023 22:00:07 -0800 Message-ID: Date: Thu, 16 Nov 2023 11:30:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 3/3] mm: page_alloc: drain pcp lists before oom kill To: Michal Hocko CC: , , , , , , , References: <5c7f25f9-f86b-8e15-8603-e212b9911cac@quicinc.com> <342a8854-eef5-f68a-15e5-275de70e3f01@quicinc.com> Content-Language: en-US From: Charan Teja Kalla In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: FbcWDlCEUs_vcDK-G8m6qmzP3zEpVgNb X-Proofpoint-ORIG-GUID: FbcWDlCEUs_vcDK-G8m6qmzP3zEpVgNb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-16_03,2023-11-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 mlxlogscore=847 bulkscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311160044 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6BEEE160023 X-Stat-Signature: 1psd6ts8cabsdc8tfq34u1pq97nsq1cs X-HE-Tag: 1700114422-773268 X-HE-Meta: U2FsdGVkX19nCrfnayJJHwgcPbYoMSGSQmZTrElhiWG+5DYR9JmpL2UVMaZpdKwb0OBR6Jsu6UbhZJCrXcHxp/aTCdaaqDbD6pkZjiaJ+HOZ8PH4cvT2Qe1heiKLlCf4EZVzW02NHcBjdJRQe0+6/yjROIgPmE87goRLombtfG2+kDDeU8jKrawuMT/KzoX2Gmc7O599QvRXioAeUp7vLQfFsvlLe5zUAWfzaXMhUM0F7Jn9qCiZTNj79aPM2AbpPBc0IO8ifDfe9PqYzpxbF4HoAyRW/5FprjCtuim72i19X8iIzGm+2ARlUehwLg0WZk8b6RQ43QeyXnSe3HU/LdgqoJF++kufYRtZfuDh8GL73/wCuEIoVm8bUnrOgZIjpQR+QE2i2kdhFQw0rx1uUveWEhAgRgn247HbYw2S2GEcJ9c9JEfjRCHzd06UoleN/xEz/4SzdT2lWXYYxUITdBW1ZTLB46JHMAZ/IUYrxPBBfLz5oEHQanH2+mPzHMUIsQ5yRCr9Yx/x37G58QKaLhXXzonCFoPQjlJgHjoYrBsmiSGgYKyLb91pd2KCg3tT3x4/Y1jkx5qBLnmnbkifW+CKiSbuxroxQxMKIBLUWV7rK09yFtRPXHU/hKJDJz6JuOu218J5GWYyQlu1Wu5KSNJoGiLRxUJIBYUc0yZgMS3XAJvFhiDhLDzpGrMKwu7DgNiRYzaQvenFENxrHCHzyy+d7viWehr//0MsYqadeMDDVl6HkmH1AU+3UbdrrRg6kYxFizGBri6SjO5O9f+cRcEmDT7gv775Q/ASQUAi6V89QqNOnoAFf67/X6L4RPU3Cd96CN3PajiEE11/9CKwke+ZbwhN9pHxUWeyP2idK2qduxKGbhCwq9bBo8LK0OuSRSjMI0GEE/O1YYKig2BRAhf1htMmxv4tl5bP6c8bPBrQF7N5bAc2h9LUulkfKiOzFwWBsRcCiuLsTOd/HRE t+tfh0Mf 6pvbO/fjC/46Za/vE9exhnrppzNAltj/CvolCxRLMfhpVOPjGtXJXYreOFLnK7UGrE4TeMk8wsugeFOY/Qgt/mXzECLI6AT4Qzxr3A8pIYmQnse7kMnoL06z2iFrnc8oXPdXhlmmkSFzexcQYov6NoQlXsel9yAHCpM+3LoKr6FYgbbbviTNOMX308EcNxxkItU09FABzJ/NqYjgqSqMQfB8ISViDOFfSigdnN67KJ69FEpJQtE+ugyeb9rC6rYvib4hUM12xCjuzx7dNs3zqjPPCzcyInYpkghgE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks Michal. On 11/15/2023 7:39 PM, Michal Hocko wrote: >> Also If you have any comments on [PATCH V2 2/3] mm: page_alloc: correct >> high atomic reserve calculations will help me. > I do not have a strong opinion on that one to be honest. I am not even > sure that reserving a full page block (4MB) on small systems as > presented is really a good use of memory. May be other way to look at that patch is comment is really not being reflected in the code. It says, " Limit the number reserved to 1 pageblock or roughly 1% of a zone.", but the current code is making it 2 pageblocks. So, for 4M block size, it is > 1%. A second patch, that I will post, like not reserving the high atomic page blocks on small systems -- But how to define the meaning of small systems is not sure. Instead will let the system administrators chose this through either: a) command line param, high_atomic_reserves=off, on by default -- Another knob, so admins may really not like this? b) CONFIG_HIGH_ATOMIC_RESERVES, which if not defined, will not reserve. Please lmk If you have any more suggestions here? Also, I am thinking to request Andrew to pick [PATCH V2 1/3] patch and take these discussions separately in a separate thread. Thanks, Charan