From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AB96E732E9 for ; Fri, 29 Sep 2023 10:17:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE88A8D00EA; Fri, 29 Sep 2023 06:17:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C98018D0023; Fri, 29 Sep 2023 06:17:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B38E78D00EA; Fri, 29 Sep 2023 06:17:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A5A198D0023 for ; Fri, 29 Sep 2023 06:17:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7CE8640B57 for ; Fri, 29 Sep 2023 10:17:17 +0000 (UTC) X-FDA: 81289232514.21.0AF7216 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id 86DC110000C for ; Fri, 29 Sep 2023 10:17:15 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XzS9mEvG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of jlayton@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695982635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P0eff07RhtpS5UOcz3JkNsf+Ld6yeT/W26VJM0WDCPo=; b=Jn0wFyTxjen9T1YUni6Tr8j7PnKcOYzSkAc+Ph1E1HG7cwHn8whh8HRwPsx1lI4f74xw5t bQMS+22LU2SBvtl5YNe/PmLb3AyyLzKtYOLE2L303s7LK+Wn5HqTED8f9Z53vF8t/6uuWl himriQbIU+gdoIThklOl+w5myXV5XEw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XzS9mEvG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of jlayton@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695982635; a=rsa-sha256; cv=none; b=RzcbOFLkYRWR+5jyQa26LPIScD3EdA7+XW+DQGlNULEJTwyG4ZTOrbRG3X2QZnnjG9l9fj DyJBsQDEMVDbMQOjdpkFtqF+mT1H6xtiNLbDA5E/Oh2SuuGcrDqLwDdzKIDyslZyBV3wJk xwEzrVNI2zBiRdrupqZF7zwZt1iruIA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8BAA9B81E85; Fri, 29 Sep 2023 10:17:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C55EAC433C7; Fri, 29 Sep 2023 10:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695982632; bh=P0eff07RhtpS5UOcz3JkNsf+Ld6yeT/W26VJM0WDCPo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=XzS9mEvGo34Ng6IbV0phy7oFkBghevr6TXQtKuvgCZiNk6sipSIK1ybdV8fiZNmJi ryG2oocKEqZZKJ0Qpanb9xZf3XPiR4Bq6wmT9EMmf0fleXLKV9fNEg9/bkdRQXUeb0 6CCRA5VO7ZThmTCkkfWYanznw4Z3cZqE/s5mMA3tjLRXwYn9bn1bqt+qj2Mv3mg9Lj pTssK95Hwcb1T8QjlazVp2JhItPwZmMqN2Vq1pnJqTnlHDG5dK0bcBFAZ33vjsFaWl leIqxKSfZkutf2lGQF/4jFFb0IVmQg0er/lH6TmX4JwaSuIbh4XkLnYFCd3nLSRRA6 40ODyX835zJVA== Message-ID: Subject: Re: [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers From: Jeff Layton To: Christian Brauner Cc: Arnd Bergmann , Alexander Viro , Linus Torvalds , David Sterba , Amir Goldstein , Theodore Ts'o , "Eric W. Biederman" , Kees Cook , Jeremy Kerr , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Mattia Dongili , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Hans de Goede , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Mark Gross , Jiri Slaby , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J . Wysocki" , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Christoph Hellwig , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , Jan Kara , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Sergey Senozhatsky , Phillip Lougher , Steven Rostedt , Masami Hiramatsu , Evgeniy Dushistov , Chandan Babu R , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-rdma@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, gfs2@lists.linux.dev, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, Netdev , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Date: Fri, 29 Sep 2023 06:16:57 -0400 In-Reply-To: <20230929-yuppie-unzweifelhaft-434bf13bc964@brauner> References: <20230928110554.34758-1-jlayton@kernel.org> <20230928110554.34758-2-jlayton@kernel.org> <6020d6e7-b187-4abb-bf38-dc09d8bd0f6d@app.fastmail.com> <20230929-yuppie-unzweifelhaft-434bf13bc964@brauner> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: 86DC110000C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: fywnb197i1sn48qthqcp6ri49xar97zb X-HE-Tag: 1695982635-314112 X-HE-Meta: U2FsdGVkX18i9Oc51LXjzO7xpEl4jPUifgqQ8vNKDPhDaaaDRhqi4diZOUD86iaAUkwn6MN+xT2hsXKTIDWqx+gVxf6U8N9iJlI6t+xW+9FMykW76zV0dePSybnyU/QHKLHspT/e2KmYWao2GomxREIouGr01KNHm4QYkeHxaK+jQ7FvdBBy0eHYZ2lEsN01o6cPl7NE3Ks99O8fxdIQVhMc2lsbiaQepuQiFNG0TCshemud+W5S1i1+g/xq+6zPsuyy/khJzz41X5fbQ3JwBNkNjZNrgMJMmcS+Ix8XRWf0M7oQotSHlAXFc7U5HDCjZ8H+PrB68D3C7NVRz0xTQ8qgKFUmgrVZNbJBdP46+nfAJmfm5brPrw7GFWzMeIk7YlZQygtW5eOkFiD6KZwNDQbthHm968Mx8QDnfrzUqYnL7xdxN1aEg9d2DZVMjWUvtDej8IkQkZOGcnFlErH9kGyVejiFH9cFMJC4kgoxOhNHvl+WkqJ1aOeTnnHZ4u+afTk5Pb+w7ilUwnuzUuNhy3DEKLZbEuVQsEeXurZsWU5iBa3rhA/6yZsTKDERQMW2L5UV7oavjn0Eat0OfZDL4JDxW5HsI3lzyWr+Y5dXQ+qjtfgIzbzhr8UwMosA5l8CWDna89QgLn83DbcsFonsdG+9Ures18HgnBDNMQIYNL6kNT8dmMrpahgGo4m0H6NIgnTrw7MdzXzd6vsYBdgwQkElH41A5tteKnXu257+FDHiUQuRyWP16hfVIEWIuT33/X/18NSsBs4U+S9ePngjh9T7RqY2V7RzmtQNqOZ93n7yPp7d1SvlMTZ9SKT+5stlkNpic7mLZcf2aun7LKmwrmiST360suQXRQ40pYIm3d5M2hA5hz4BzY2k7mfv2ztTe3nFmoqbgCLeZqxz/HtinyzsYlzp7TITYCmFuI71WEPFJsxPfivIvR2bUvGl5/ZWFQUV/C3ZfLO3lrcbjxJ gzTSaSSA deFX2J6qItgLoJNMxh2FKFCBhtjXcu0ewmR5pbewzGXtMCwB2BVcysJo4OuDFw9ofyREoOwJ+dgYlDPHUrNPSsggcT8h2FRu6WXbkRdijC2/ab+B8LO9M2u8xlUHzjzqrwduv0H9YFKVEPRO9uXaB+eDVdecJYM42zKV86uoCPQ6YfHuoguzIuLS+feniWUsd6F3FiPNZVRfHaE6QuH8wQ6uye/QW0szfK7Xls1a3hpbveBeqwibQdForG+KLdBmNK3YwbKFNMkQXwfQ2BBQfqRCQLfHEGpznMLAU5GgxFsJ1tQta5/iG34TzwOGj/4GbvWUybl5pxMd5cuzWHoUAEq+z3aUtjYficyGDB5xofN//4Ci6A6zivT8OQ7opTB9YdEzzCBGa5D4kZeK0qbUdTpUp2H1jGBT4cqinaeGt1JelnWFdf6nhFzI/AkgVedr2tl26zYpb41NgCrh6IAcZEOMkYg1XX77fcgZgUVSM2JNIvX1IDajjUB2Vp8QsZwKNjWlWvGcDz63zU80RBkClswvJB1vYKwaARhTDkwCoKzvAK8+eZhZoYNXQ61MiNsyvuelDOtQc2RlqQL3lVbqNOYBKT44jKtm95HlCug3wCQWl5HX6TH/ToA72T2NG7VpawwzjGKU3S6K9FlMIPgTiM29QePMmByOQ75KnW301cI+GX8fqMzcX1x3Km9LGR2VdhJiW3HfN+sPkBaf9Fr61Iw3ulH2rtLNTj1FrQawYn9Y1zsx7G4GPvqcOZNY8fLBWfJiRcc3HJM8l62tsV7ZNoKtdzW3x62oIdxo+qXJTkhf6TYNicgFtPjgLiKfo9CuYys7NQgOZ5Y5uC+8wbdbyt//BA9X6X4mrpTuOqI9jh41tu2HwTfn7Ygj2N4GOR4kVm5kkunUkU9Hg8Js8DlLuwZGB8M+QZux+5YhxlkiMjjuhMlPeQNlYEtUAxavjVhjid8VdJDbE7nbzcy/NsAQOyNWn/tiZ Gk7SUQ+8 Rb9/EX11V5pS2A/Jos957xqljUHyMOCdldHr6orW4fNtR5CX6ZlfQ6XVSHAjk9Dv35qYDsi5xRNNWkZZ/ToXwAkRt5pF8llsk1bZ5pl7JfXbtOGIjk333kYg2BLM9YqvOUwpw3TvPulS+P4u7IBK4R5gR+YuPUGHLSB4nbEPEBLMcSl7X0gUFVTApJUygCjjQpq+i4JCFwjq+uc9ndijytgm54uVhQjI6a5MCNBcz8sf/GOsJtW6ZjTzls+f3e6vDqD9u5JSPMxhG/uYWBXg6ORJPxCZySqUQLpwbnxwrSW2asBWyhwGmglNh48g35U5iRBpGi/vIjb1da6TyUu5jWNPlv/0ZuSqSH/fLE1EajlHfayLbMIRcsLO/TnmoUO4Hgu3ihBQ1mTmWfSLyqqlB19MhO2xprQ8bO2OGZSy43e0+zyiyl0uKIBLoXhtPy0rm6vOhs5vpkVLyIufDW5L1tPdhjIslDP+izNf40wT5GdpdmiCHUdj+1dA6air9C+ddccTnXDZYPg1G75g+3EmUMwmksEvUW56mNmsBlpuwzkPMoG57fL1nvun5qSH7Eqhp6PTHjBiEWu9BxRu8XIbB7gYF05lbDvY1xF2J3wU9uUxjaqIk9td98SKAZtlIfyBmID2RjxYgHvxdE2PZWFti61Kjc/UcNLufx7QJlmNHNNkTo7eHNOL7xrl350hbs9f1RglwP9dAMx4YOYeoSiFgdwj7W7dT4BW1wsIuNieaTScAdKhbk7NgyrZYTfTfeYqRNukx8GpCGFhH8xAWxlzUDVWXWQaDpE4m3jo6HiKrbeFjk5CrzACk/1FA/0m/o9AHxL5kgCTF8XzAebiFU+eHpaZ9fMe99FgopghWP0KYuT2naeTrTJP2YsMr7YaW9I1YbLAfG8WYcgp84ws69NosyC2/Ar6n7zeSD5fsJQNNjFt7gEO9Q2v4k1F+cDAm1ATr2zhgd7T1nVe8p8se4pHoNTGtjDdd 1oLyB38e OQSuy5YQmhme8uKY49cIkLBZuoKkx0X096lZCZp1phjIObjNZB/yrzkafJWgLlZ04Rch+ZBLpzod9Y+KiJ07esCTsM3JTkRSc/9iT86N+JoybGTMp5WqYN3qjDzkCl4Pq41SA1LmAMMaosqvy5E+Lhp1Gmigj14TMVGb1zgY1D+ugBCmB50Hi1rrdAKHMgFlch9Ry3ByZQMT3yQHpjtHD80fArTDBRl1EVlZdq5FUGExgnkVmaajMvqYRZ7FQ9EgWkliGYzHWtxkMNB+IJef4m/PgqXG7dVFWEDvxd4F5Vja/nGAxbxdwUG0ri3uPz1mOaZ1zkrPO1ZqL2ON1xrzetRxHPVVwjPjb6r5+pVAQVMxci1h/AahTQB7QK0ZuMezs+nhFcnjhM0q7lVcoexAgP4bmCLhNQZandaQ/jjRf7EcVEDxd4rPAJfeqh1BSRoyMxHZi7AWxsaBYFTqiePbO25ZqgbUIFCCHVM6XDXA8eJZdJBmE4MT+C2exZO3AFosR0dG8vYVEOwVAR4k3WwOlrLUKrwcYieO5jbNmQwr8i6mSRiXANp06842mb3NjfYT9N1X+IRLIpy5bTRg+MhsConG8q8AC3TjtOn1pGE4vttiPC4IROgcqEEkFaOFrwNmOSgNUkFIgha1yp53QviX4vdiJJx132obViNT/8Q8gs8jiocj1xbD6ZWNOt5PrqRC+7RygRTBKVCgJ9N5wCV1hegWYvN6g09aVu6I2mC00iwLa87e3f9J8vjLBvfj0xqrImAYM6rtGeok8djksyaSQ4HI/fl5xM92SGx5AkZgSKqveT5jitW9eEIoFWQZlz3vOVlW4Lokba5a2y4pwG/dLpsmMyDjTt7sUl6wNQ1r28qSxgGkQUaqx56EvQxJpWHZZAPHaKDa2GSocepC0tsd3VtRzEdPhp/3hshow5gAN8SdEqk5NfAR8+PwJU2qEmAyVHng1bytZnT+HWKiy4U1ut/5S5oK4 ofnZ00mV r+mZXIeTids+xbTvLXusr1Lri7ye76Mr4a/VpBoYfv41DVIIoD+lB1Lp5VIxVjVRwXLfRnIytEwXCmyDZrWKzcaQffgvXCO4kKtUHNM3ppdN5MnswVdx1HbUsO03BLMWB1VAIuEsgugpX6VugS4HjwL0/417IlESAWGXyC28Ix4/n1qMgd2uWFx1hcwZmQdePTmH2uXR98qiLg0sOpYGeGDwT9ZebeV+dQ+k1VujAaTCXzWq5GjdZhPFNUQgjxBsCamTgTHTjXZsxF3iXotfkSX0i9ZAWMMgxCLvmyGiWCGyMMxgpS8HwnnE9KdxYf6GEicvnatNulvcrabJpOBuAx9eWw5hm9a81V9o+/o4AO7/zEE8ejdUnK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-09-29 at 11:44 +0200, Christian Brauner wrote: > > It is a lot of churn though. >=20 > I think that i_{a,c,m}time shouldn't be accessed directly by > filesystems same as no filesystem should really access i_{g,u}id which > we also provide i_{g,u}id_{read,write}() accessors for. The mode is > another example where really most often should use helpers because of all > the set*id stripping that we need to do (and the bugs that we had > because of this...). >=20 > The interdependency between ctime and mtime is enough to hide this in > accessors. The other big advantage is simply grepability. So really I > would like to see this change even without the type switch. >=20 > In other words, there's no need to lump the two changes together. Do the > conversion part and we can argue about the switch to discrete integers > separately. >=20 > The other adavantage is that we have a cycle to see any possible > regression from the conversion. >=20 > Thoughts anyone? That works for me, and sort of what I was planning anyway. I mostly just did the change to timestamp storage to see what it would look like afterward. FWIW, I'm planning to do a v2 patchbomb early next week, with the changes that Chuck suggested (specific helpers for fetching the _sec and _nsec fields). For now, I'll drop the change from timespec64 to discrete fields. We can do that in a separate follow-on set. --=20 Jeff Layton