From: Balbir Singh <balbirs@nvidia.com>
To: Shakeel Butt <shakeel.butt@linux.dev>, Tejun Heo <tj@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>
Cc: "Michal Hocko" <mhocko@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Muchun Song" <muchun.song@linux.dev>,
"Michal Koutný" <mkoutny@suse.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Meta kernel team" <kernel-team@meta.com>
Subject: Re: [PATCH] memcg: add hierarchical effective limits for v2
Date: Thu, 6 Feb 2025 09:33:22 +1100 [thread overview]
Message-ID: <d51bab17-b3d4-410b-be2a-e1d9150fa57d@nvidia.com> (raw)
In-Reply-To: <20250205222029.2979048-1-shakeel.butt@linux.dev>
On 2/6/25 09:20, Shakeel Butt wrote:
> Memcg-v1 exposes hierarchical_[memory|memsw]_limit counters in its
> memory.stat file which applications can use to get their effective limit
> which is the minimum of limits of itself and all of its ancestors. This
> is pretty useful in environments where cgroup namespace is used and the
> application does not have access to the full view of the cgroup
> hierarchy. Let's expose effective limits for memcg v2 as well.
>
> Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
Even without namespaces, in a hierarchy the application might be restricted
in reading the parent cgroup information (read permission removed for example)
Otherwise looks good to me
Reviewed-by: Balbir Singh <balbirs@nvidia.com>
next prev parent reply other threads:[~2025-02-05 22:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 22:20 Shakeel Butt
2025-02-05 22:33 ` Balbir Singh [this message]
2025-02-06 15:57 ` Michal Koutný
2025-02-06 19:09 ` Shakeel Butt
2025-02-06 19:37 ` T.J. Mercier
2025-02-10 16:24 ` Michal Koutný
2025-02-10 18:34 ` Shakeel Butt
2025-02-10 22:52 ` Johannes Weiner
2025-02-11 4:55 ` Roman Gushchin
2025-02-12 1:08 ` Shakeel Butt
2025-02-17 17:57 ` Michal Koutný
2025-02-26 21:13 ` Shakeel Butt
2025-02-27 3:51 ` Johannes Weiner
2025-03-17 1:12 ` Andrew Morton
2025-03-17 18:06 ` Tejun Heo
2025-02-06 22:24 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d51bab17-b3d4-410b-be2a-e1d9150fa57d@nvidia.com \
--to=balbirs@nvidia.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox