From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54CBDC4167B for ; Fri, 30 Dec 2022 09:03:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66E8A8E0002; Fri, 30 Dec 2022 04:03:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61E408E0001; Fri, 30 Dec 2022 04:03:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E5E18E0002; Fri, 30 Dec 2022 04:03:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 405068E0001 for ; Fri, 30 Dec 2022 04:03:20 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 09C2B14049E for ; Fri, 30 Dec 2022 09:03:20 +0000 (UTC) X-FDA: 80298383760.30.DB90721 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf11.hostedemail.com (Postfix) with ESMTP id AA4B840002 for ; Fri, 30 Dec 2022 09:03:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672390998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=je3TOIYFickhpMMZRsySSEMYQVOZaaCmN17UdzQLo38=; b=GlSBM7UnrxFoEKj2iaXGQZgSdW9M6CzBu63UcV3RoFoN0eQ4PankScIl1cvxYC/6hMtNt6 uM22p7fe9jetyIK0AWh5DMr4xLtESRA7SAkNVcOiq1LqC44ZDWjKqMfpemMRauBM2wrCuI ViYjmePcc4oB25LTfKnYGCnzxhStqd4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672390998; a=rsa-sha256; cv=none; b=AAs16kczGoYzDbejkIaUgT9vyajW+dgR8MBFKLIuEzNv52Epv7OZZ3/u7APbhnr4zju+JP WiMXNfOnTEcxPO+yjTbBMdaVgbDI8yflfTNWnGE9FDZ2qCqqPFiDdkxvoyrXuijTJOwq0P tqOrirFhPo/u5M7JliY0G4u7jrTSybg= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Njzlb6VJdzRqHP; Fri, 30 Dec 2022 17:01:47 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 30 Dec 2022 17:03:12 +0800 Message-ID: Date: Fri, 30 Dec 2022 17:03:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] mm: huge_memory: convert split_huge_pages_all() to use a folio Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , References: <20221229122503.149083-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AA4B840002 X-Stat-Signature: wfp1x86yfrcx1xf5i9itnig69jdkre81 X-HE-Tag: 1672390996-564851 X-HE-Meta: U2FsdGVkX18pFP7MqpDc306zucqCn3uTJt16uOZVixvZuCswKi77O9Q+3ApD0QxhKTcgH6jMegdap4Loo7yQA9H7O4AsNfNMbVIc22Ta8fcQAMwZZc5dD36ck1OvBiuTrlV4upgc8nYTi7QTCdO7WD9RhnkgwkZlNjtIuK+tAKLF5AD50ju2zz8/ui7/mwcnDI0uRD2CTJemSP1X6VowX0LYkvdegMHN+oJorSqNyzCOXh0yQfIzTk7ZU33Vrxn7mtC94pEC5uCydiIs+YyrequmVdBlm+fJogVxhrP3b8Fnc5UGtcYPmIK8t+mLE8w8noqFtmkfjchZ50K0fmmjY0dEoSIMNsxZrbKsQUcm2xtKE+R+lOjspCLqs/3U9uQoA6wvUhEJWHaE6oRFvNAlb7QF1auJmQJ0XcykwQld/ZllueGb4hRk2jTpLlW0ceQjCI1KHxZpV6KVjXU5f6m8D10QTcRIBgF+D9ulrNChSiLEe7s7tqGM6qroIFCziKTN6wfjgQ6Iw/6AlJkqnwyfEQWN7ynaX7WA17pZn7rPqCx19oD4cU/63CJoADaxhHyUzZTCKWKd7xpM9DPuCspyHObuNbDHnbKyC5sehiHphPZU98hgUxRHTee+iPBU2Hl99MhI1hpgl7LoeQjJw8h8WeL2Ut/b4yOiCpydhDFP4e/wMQYWb9l8zOobE3nojZuVu1OslhOCkrHjhoWelSnO6JOHPTn6rEgZrN/dd+7rDmaXmfiZd/pGtwLeimbu+lxj5gY/n9TZ9+j88ZgGGsChNYyK/X+4P5gLTh2FxRGQFy6C2U8uX/nrg8pfTi6cxqrLwxNqL/LvxxfltJwa6nUy2fSmdDqwitCLMy35T9Qh3S3loM0sgZuBow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/30 16:14, Matthew Wilcox wrote: > On Thu, Dec 29, 2022 at 08:25:03PM +0800, Kefeng Wang wrote: >> - if (!PageHead(page) || PageHuge(page) || !PageLRU(page)) >> + if (!folio_test_large(folio) >> + || folio_test_hugetlb(folio) >> + || !folio_test_lru(folio)) >> goto next; > > That is a completely illegible way of indenting this code! There's > no visual cue when the condition stops and when the next statement > begins. Try one of these: > sorry about the bad indenting, > if (!folio_test_large(folio) || > folio_test_hugetlb(folio) || > !folio_test_lru(folio)) > goto next; > will resend with this one, thanks for your review.