From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E71F2C48292 for ; Sat, 3 Feb 2024 02:30:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 416636B0071; Fri, 2 Feb 2024 21:30:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C6B26B0072; Fri, 2 Feb 2024 21:30:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28E506B0074; Fri, 2 Feb 2024 21:30:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 17A206B0071 for ; Fri, 2 Feb 2024 21:30:24 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D700C1A09DE for ; Sat, 3 Feb 2024 02:30:23 +0000 (UTC) X-FDA: 81748913526.11.F850636 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf26.hostedemail.com (Postfix) with ESMTP id 18650140002 for ; Sat, 3 Feb 2024 02:30:21 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Gzp+ok86; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of rientjes@google.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706927422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XiG6CHWcYdWsI51hB+FTszglKDybzSu63LtpZjDM7i0=; b=gZZVsVxLkzai20w2DxUSnOX+bPSP3SQUgtNybb/22D4H6hLJrQWPy+NmbuI0+q1Zemgmy4 CbDXycRM/OO+JJMev0SuDJ759OpA4E7yCtL/dxos059/n+BL/mapu9MjwGYg2zdDhStJZt mnVh8xs1cqPYY4c3fLvOFN7ckY9b3Bg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Gzp+ok86; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf26.hostedemail.com: domain of rientjes@google.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706927422; a=rsa-sha256; cv=none; b=i6lk1CkbAo9LSxv+FtDknmid+c96tRA5Rr6FskoKYZVj0VotfcW7kFVt+X8wT1PI2fidSo 4RQLcOpcKUaUNOTgID/3cJOBz00iAyyfY6Hndt/T52UY15ClG0vXU2nTj5rAHyH9124Yis h8Or8VrsjD/rBpqEwauxhjkV4+okWHI= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d5ce88b51cso105015ad.0 for ; Fri, 02 Feb 2024 18:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706927421; x=1707532221; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=XiG6CHWcYdWsI51hB+FTszglKDybzSu63LtpZjDM7i0=; b=Gzp+ok86+1H3BfNoyM7QzRBpT15+5NTPB1v4mVTsSlgx+zVEQ4utgC6wIyDGH+sFm9 yKk48EWEb/IGxqZ9HtT28aQjrQo4R4uD73k2J/V/Z+hIxtq8ramBHBjZD0Ufgwt9YdYS 557J6ANbPXdqkkHeLQZOBzyUSf1X1WBKBYUrQ3cGyUvWC61StThcW5DrAwH/TXPWcmaz iryxlRvcuvw62eHMYn491vjJzkjrkr3GVb5u+jL59pf0WLPbks24HH6PXXHMDnlkmLNT miqejE5cixxS4u1fqnuLvZWYtmZRAStsJUxKTAkY1LpVcwgpPsFUEeN01lUZjYavmBo6 JUQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706927421; x=1707532221; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XiG6CHWcYdWsI51hB+FTszglKDybzSu63LtpZjDM7i0=; b=PZl3cmNFo0dpv7TvNirNRKNQuAWILWxfsAp7DwlAGm3eZ0bcK328AG5LXpHT/SgYbQ 1axLPaPuN09UiJpHYHfPW0YWTVffpq6evfn8KglmkKgkPEIeaeN7NmheePNaqwfQ5lF7 soWbj1UAdzrW4eH7mR+Ai8XnVp5cjQKR2GAtavC3hwclBmD9b6ZyIUjGiurfijjxUinr XR81uAFJr0hhLTh9WZStFeXN8U+C4ihJZm4z5nvNTb1b6B9UVmqfTqRblbwREla0/yrU eDohqcMB3d326cXHyLk7wWV1xWd0S2qgk65yWvWvwwuNQ6xMb0PBlGJZWfdjI+Tzz0/8 o8gQ== X-Gm-Message-State: AOJu0Yz+VurMdFIAA0+UZNTEE4p5ai5YtEKt+HM4eNFySTwRFI22we8f wjwyTp2k7YG12pFiaLrNZ/SyoCCxw3AGGnE9KHRNnNUu6IV9l8dnKfW1/PDpDKWRWSy5VOeZ0GV Vjw== X-Google-Smtp-Source: AGHT+IHg996dygyt9LnIiSvyqK9FLVoUTcVkp9Miw1CYvlt+COnosUlv02z5yOlwrNv7Cbz2O6gz9w== X-Received: by 2002:a17:902:fccc:b0:1d9:8e37:56cc with SMTP id mi12-20020a170902fccc00b001d98e3756ccmr24869plb.10.1706927420652; Fri, 02 Feb 2024 18:30:20 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVTJg+AEeBfOkpo/qJURUeu9o91x/nT1ZbAlXanN+fx4CgxYbFsH5DaRxefHDJLKAYgGLQ9IF9TOBbXgio9d1sxnArAMI62kfjIQwVRJFFH1C9Ih6WTB1vIMmmUJuIENK0KKVsZQ4f704yNfhvb8lj6P0i5wwsr5hTBgf/Qp63kzfRV9uhpKaPlEc3BSUA1ANE+aU210RCJmd+3VGAQMclintHIwqZRC6nPSf5y5OBzfg== Received: from [2620:0:1008:15:5706:ac37:6d6d:7587] ([2620:0:1008:15:5706:ac37:6d6d:7587]) by smtp.gmail.com with ESMTPSA id t11-20020a17090ad50b00b0029658c7bd53sm747960pju.5.2024.02.02.18.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 18:30:20 -0800 (PST) Date: Fri, 2 Feb 2024 18:30:19 -0800 (PST) From: David Rientjes To: Pasha Tatashin cc: robin.murphy@arm.com, joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yosryahmed@google.com Subject: Re: [PATCH v2] iommu/iova: use named kmem_cache for iova magazines In-Reply-To: <20240202192820.536408-1-pasha.tatashin@soleen.com> Message-ID: References: <20240202192820.536408-1-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 18650140002 X-Stat-Signature: iu9448qqt4m8qtqkh6iefb6oyd18inmt X-Rspam-User: X-HE-Tag: 1706927421-915903 X-HE-Meta: U2FsdGVkX1/7jCTqcwReaJMpD320Z71jzlXotlvPMtOrPBbS/4BaFyZE+UzzBnXrBFQbzZQ8P0JkL3XLKE/Fj6W+Aji2NPHOF3ObamJna8dwyURo6WJMjFrYqjvkme7KFQKuZOaxHBPmpMndQqQFTLlOM3nlvsO5/JZDD9fsLj75kJKWzbrbY6XabalyCre+OcAn6JZfvrR0br2SRaasz0LKdWpAm0sDgiN0UQEmo0PLzzXTqDhnyCsnZp5ed+c23kwrcbS40zef6V/ngNG4SS6sUykNFGvdJcwzVm1LnLi20H9zsH0cSqnKGylKUuGrNnAQNMC2RFFOiwoZTOcbxeVq4uBC72uIH79Od67WuU4ghNvAEd/A6fyigB/EQOu4l8bSMB0GWOqq+fVpJOhIOXbSpFEhI5J0Zd1oG7p88eGfLbpnLhl25SWLEEyxpikX2bW1Vz/2jhS1CBPILRBxs5pV8fZA8lMfwlsdtZ9oH4kndW+SnU85he4ZXGrvafiA9OvuyguBJ7b6r866b+ZIFevvkkqpgnUwv5o4sZupoM3EHQhBGFn9cCRonRzVsf5YuvJORaw87opHqdt1bUD4rr9kXRwOo+DzRKoZWRFmLdkZGV2HUG5Zm0two3tTV4T33ia63gnc8280MM0qAkckRuBnoeqOMv5yF7w8T24NbkMm2Z5Ap3s6svg3+7Q4WgQQYZ7BqYp3YRxNy8evMv6j/pTrCrejjpy2JpprJfgN4IyFdpAtKAEDOSKTdRLE3j0rd7wf0Q4QbnLEUV6bBZJNlo69onvqUWSduQuQIPfOwGdfbnDDrKRNP/Y7ZkkD9Cd089+P85LNeocHV1RGqQoZguSzsZimxWzBrHxj51NieDcP/EA0MlM/cXV8cUHXgWQ7NLOwSRJLywU1zWA0VyOSL4ld1Y4CuZJwNEkYi7ZrN+xjjkSpYhl/mvYzxpwFizU79SdK35nOnWEGlKFXwID benNm/o/ HfXLFEjAvagIPUVG1m3/eebwGGX0q8ywtE454arPp8Nsyg+9mIpOBH7ov4vm7i4AE4MwTwPe5C+qc45hAwPcDXQuUA/rYH3rZ360oAVu0v7qfBcMLtM98X9Rz8NhqlqizVIwKQMQL3m8vs8AMovf0OFFJrRHsJ6HYaBRRPuFrWDaIQroG4sLx/oJ89SSJF1BcNUfJk0UIjGx4iOpDBvQtEZIsYqMwMxMeO1OoUsstbQdnQZvF9ZMVBlfx+7EU25y4kseGqcWL/O6Kw2mkq0pGxIUbUDYj7bXraKNQS3aa+NkqrFJGpvJyOs8Ao41im4k63Og8alIrDPCjEnp/KdjFEWwbaBFHCuKQyBXOI50PEMW+O7YFwVmiis/nL2JJj/atpouo/xbdgNWDLPaIWFTAtPERYT0wxeMvgic66GPKEq/1v2YMz9GTOmlQWzn7txIuWiAwRxuqzDgX1LOAE2OdoksBLmvjQ3N6iiMFj4QB6XwB5pqrVJgv9fqu4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2 Feb 2024, Pasha Tatashin wrote: > The magazine buffers can take gigabytes of kmem memory, dominating all > other allocations. For observability purpose create named slab cache so > the iova magazine memory overhead can be clearly observed. > > With this change: > > > slabtop -o | head > Active / Total Objects (% used) : 869731 / 952904 (91.3%) > Active / Total Slabs (% used) : 103411 / 103974 (99.5%) > Active / Total Caches (% used) : 135 / 211 (64.0%) > Active / Total Size (% used) : 395389.68K / 411430.20K (96.1%) > Minimum / Average / Maximum Object : 0.02K / 0.43K / 8.00K > > OBJS ACTIVE USE OBJ SIZE SLABS OBJ/SLAB CACHE SIZE NAME > 244412 244239 99% 1.00K 61103 4 244412K iommu_iova_magazine > 91636 88343 96% 0.03K 739 124 2956K kmalloc-32 > 75744 74844 98% 0.12K 2367 32 9468K kernfs_node_cache > > On this machine it is now clear that magazine use 242M of kmem memory. > > Signed-off-by: Pasha Tatashin Very impressive! Acked-by: David Rientjes