From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B38F9C4332F for ; Wed, 4 Jan 2023 13:48:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 391308E0002; Wed, 4 Jan 2023 08:48:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 340808E0001; Wed, 4 Jan 2023 08:48:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2090D8E0002; Wed, 4 Jan 2023 08:48:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 104998E0001 for ; Wed, 4 Jan 2023 08:48:12 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CB8C0805F7 for ; Wed, 4 Jan 2023 13:48:11 +0000 (UTC) X-FDA: 80317245582.23.542B27E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf12.hostedemail.com (Postfix) with ESMTP id 06F944000E for ; Wed, 4 Jan 2023 13:48:09 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=w2B7F5Pj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=woTCjoNh; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672840090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A/xrkCTOG/VuEr/7vz/dj8OhDz1eXgBlHor6iAWeh/U=; b=KaYyP3vzQBaIg3gKX6Vlsfu9IxyCUXhwnKJ9GrFLo8ZMWjsUATO4zZeO4yL9V5FrWBKcfY ciArUKwQqNmkgYfTIRW84xl98B+sru1uUqefYKM3Y279THTvKIRIs+XyboO3aG+AHmj7si AK+X/yThD65h/GUQbGQkv6OJWlbuWqQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=w2B7F5Pj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=woTCjoNh; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672840090; a=rsa-sha256; cv=none; b=42htu3/Jgisq11qYiR8Fk0ey7DRrdOPKCk5XfjnPTXb4G9KKATNTBgD2HS+W8TMmiubwDl nNiT2JMELyYRRwztPjgW0TW1L5TF1wDj9QYQeOaX62706NCaPvYbrWRqY6NcRC6/19WyhS /APb+cmprQR/7g4HB3rM6m/JccEYem0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CC3222065F; Wed, 4 Jan 2023 13:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1672840086; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A/xrkCTOG/VuEr/7vz/dj8OhDz1eXgBlHor6iAWeh/U=; b=w2B7F5PjA87TYX0cXhH6LHSWIheAl0o+7WaZarkX3nau1Hfjm3lukJC83XHx4ht7Hbq13O 86ziXSVOYL3rDVhVTFFufSB2tREsREJan3GjKeOHDe6MXf9tks0MdH1+Vr5vkzvItPNHKL /xqC1DYPtFJKdvuCDBg0yOOo+JpGfcQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1672840086; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A/xrkCTOG/VuEr/7vz/dj8OhDz1eXgBlHor6iAWeh/U=; b=woTCjoNhJ5lrj7PPlvQ43Kxbz4uu72tr2LCCDBi9FmLUnfHibehmL8V0QyNmD9XbwStbm6 6GWpRXAsevg0CjBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9C61A1342C; Wed, 4 Jan 2023 13:48:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zriTJZaDtWNvPQAAMHmgww (envelope-from ); Wed, 04 Jan 2023 13:48:06 +0000 Message-ID: Date: Wed, 4 Jan 2023 14:48:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [Patch v3 -mm 2/2] mm/kasan: simplify and refine kasan_cache code To: Feng Tang , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Vincenzo Frascino Cc: linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org References: <20230104060605.930910-1-feng.tang@intel.com> <20230104060605.930910-2-feng.tang@intel.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20230104060605.930910-2-feng.tang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: hui6n9csfbzujd4zyiu8aaziu963dw57 X-Rspam-User: X-Rspamd-Queue-Id: 06F944000E X-Rspamd-Server: rspam06 X-HE-Tag: 1672840089-301523 X-HE-Meta: U2FsdGVkX1/jaBf6aacimD9v1pOc8ywuYL/Qa3uYtxzpGbE1nbgUZNqWIHTObz7VOpNXMkg4mVUw/VbFpPI5EJ1Ernciw6WDOUd0vX5E5CLnVJkqo3JVndI1Hd6qVICXhZw6A7a7Fe4HZTGy6ojM3/W0eD9+Ls12t+z7YolIULHMFLq5Ky5+KDo64TwgpSNi1GBZ+n4RApEvZ9RXSv8RBKq+Xa9QcLs2GAV3EiANYSmmOOqJV4uarPmtcMLe3fUcMCAdHBSJ+FKtdbcVwTmQzjzf62Uln9zzVFyZGpq7fO6rqvJMO0GTQ6xOaDap/I6syDssfg+CZ3vHKiOvrFfyfQAjw4ReDLDcszL4/CQ7G6HxlVMzeWXX8ztC6lzm8kzdKgU9+W9mi/RZnmhH+J2A7ytrbsDBfo7nmM4t+IuSvz2KfcwEBheFHCZBljtRDj1wre3Q+Q414NMphbD34WT+I8Y9ivS9s2AqiNQJba+K7eQx9aD6OILIqB/qooMybyKniptK1T7IOLHH37aOHnLd2o/z59HVSq8c5w6tgbF9ED12K28T4V3KcaDG6mhzqH4eapDW6ngDZVlf4JxLn0NH5pIbb1crXqIVLRXrrd5o0fpJYwFXQwMA5a7SbTJIeG7ZdyI6ZMFhC7O2+cfP7wRkgRTuxesIudjvMSfxiNo/XNmtDX4JJ34D463dMGJrpOTBR1B7LRCww32CxYH9MeO9JOEBl4Q/pvr6iFf3+2VcIMBFyMyLV3A0hT66msKUzT5kMBDuyVSY6P6aeRT1aqA9FKJuHS0vQ8qDKdxqGjnEiOuiCYt/z2KW/z6gP+3bWB3oqweuan2KbtU4EFNE+mqdqTNOM7OUAsdG2PajXWs9oSuD2IcjUKL9WAcJJThyk5Xbjk1jfKsovU6Mr4knvqZ0xMGm7q2MAhRX3XgCWhpWTVdt2bkWGt+/th1XHsDKTNt/znsDJc3s+pL6eHT1a+0 1pgBh2HF HEp5gfdMQMAk32WftgmvoR2s2DbT3ARuBjX3wJA2mLJ6EeXOilnQCsDdmZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/4/23 07:06, Feng Tang wrote: > struct 'kasan_cache' has a member 'is_kmalloc' indicating whether > its host kmem_cache is a kmalloc cache. With newly introduced > is_kmalloc_cache() helper, 'is_kmalloc' and its related function can > be replaced and removed. > > Also 'kasan_cache' is only needed by KASAN generic mode, and not by > SW/HW tag modes, so refine its protection macro accordingly, suggested > by Andrey Konoval. > > Signed-off-by: Feng Tang > Reviewed-by: Andrey Konovalov Acked-by: Vlastimil Babka > --- > Changlog: > > Since v2: > * Rebase latest -mm tree, fix a conflict with kasan changes As it doesn't apply to 6.2-rc2, I assume (as with v2) the mm tree will be a better route for both patches than slab. Thanks. > * Collect Reviewed-by tag > > Since v1 > * Use CONFIG_KASAN_GENERIC instead of CONFIG_KASAN for 'kasan_cache', > as suggested by Andrey Konovalov >