From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF34C3DA61 for ; Mon, 29 Jul 2024 18:01:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39D986B0098; Mon, 29 Jul 2024 14:01:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34DC36B0099; Mon, 29 Jul 2024 14:01:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 218656B009A; Mon, 29 Jul 2024 14:01:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 045F16B0098 for ; Mon, 29 Jul 2024 14:01:29 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 706AAA3E5C for ; Mon, 29 Jul 2024 18:01:29 +0000 (UTC) X-FDA: 82393557498.15.7AA701F Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf05.hostedemail.com (Postfix) with ESMTP id 33C6210002E for ; Mon, 29 Jul 2024 18:01:27 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=rowland.harvard.edu header.s=google header.b=aQ8KQxsQ; dmarc=pass (policy=none) header.from=rowland.harvard.edu; spf=pass (imf05.hostedemail.com: domain of stern@g.harvard.edu designates 209.85.160.179 as permitted sender) smtp.mailfrom=stern@g.harvard.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722276047; a=rsa-sha256; cv=none; b=XpwZKIqVC+mV9ct1Eb7p1U/wKKYcsz4KluO5P7+fI6Vyt14FhCWMUp/9y7CZZdXX1O2hXc Abyd5qfbSzV2Ik/CQeECq4xdCUYU90butWQXg4OV9//pi6DkcIZMKWJ8l6gp3exmDjb/0T 3Ayf05nHDCiP7L870jqH2Uxmq+6fx+g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=rowland.harvard.edu header.s=google header.b=aQ8KQxsQ; dmarc=pass (policy=none) header.from=rowland.harvard.edu; spf=pass (imf05.hostedemail.com: domain of stern@g.harvard.edu designates 209.85.160.179 as permitted sender) smtp.mailfrom=stern@g.harvard.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722276047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nd1WXiUiTtwYxOMtFvVlG67gP5owuM6QDVES/bBhfKI=; b=o3u1ieF5B/v6merGXoM4zvrsg7Auk2uiy/5sglNHpPWmAR+sa25KyV7U+581ivP1n/LYnp /eiu7hxG4OXijSB82O3j6UkcHq2VH0EqJgkMqnXNi91mmA6wwE4KMTw3JANZwy6VQkn9XJ mQ6zt3Gef2bnb40u2V2a+Ltu+ZpjAgk= Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-44feaa08040so21676591cf.2 for ; Mon, 29 Jul 2024 11:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1722276086; x=1722880886; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Nd1WXiUiTtwYxOMtFvVlG67gP5owuM6QDVES/bBhfKI=; b=aQ8KQxsQZlWdkP+LuOSwdnhsbOQo7yJCY0yI9wOOggvuar1zQUAviVkGALQTCmJG6w CRQTRfbt26bmvf2fQR0VFPXYl+GthONNmS5KJWgFIVn0GWGD9B8fuQmaBWiewNn+AQOw v/lVy0GZFRZDf7RvfRpR90p1q45/6BGnS5RyKli4wS/8IvmRpEz5DU3tsw6avEoFeXsc U+3eFjAHT3gRiZoa/bWCRHdmglYwTXG04W70Ze2wrcFrBozyAklbJl0icYGsHF7UqfpZ /uixvgd5hG4/LOHClWe7iNI9wxoMyBsmgad3pXIFvBIgJo0ajrYh+LZjOVj9XRDpoRgx yrJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722276086; x=1722880886; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nd1WXiUiTtwYxOMtFvVlG67gP5owuM6QDVES/bBhfKI=; b=b6n2TVl2nRXNq52CR9Ujv2VPBiXqkmb7Am4zfcmXpkBnAu0p9LSVXrrgR1fM5PQX+9 WfZx3hK/8qLatDSqqATWWRUvIyDxJ0y0shJC4OFWti/iTIyLRlmj3xxxPu86zuLVtigU b6EpNibE4W2SAKH1zcOFnLz1oU3YME4FDrSG6ImDaTPojaCHnVuFSa2g8+/+XclAoSMN Trkp4riB0pfJYdlQN2Cq2g9kvQLvhUsnKdYC647uyh446vmbmnqTQMqFoLaTkdFREhql CCvco81gyOdF3Rc7CUndPn7UHp9VJZxsb+UrXUd5TuzgU+XSjIynhtqemxDvnnAtk6ZC ZL9A== X-Forwarded-Encrypted: i=1; AJvYcCUC2bXeLpx9cnFswhTHJQyourGLGEuNhoYGyjt5qZBg1kz/R+Vb/cKtqhr17QrPpKa1p/jM27JheTbcO+G8g7Y4qVo= X-Gm-Message-State: AOJu0Yz8sWc7YctRhsFlujdwjJTtw/vYbO76i4veScmomM/rnCWZHPo/ ppNf97um4423E/s7BlPmrKhNG7RMgGIx/kt1i7UN7D1CVJACrjmij6zUc1RtyQ== X-Google-Smtp-Source: AGHT+IGVjAt2ihyHs5zn4xEcJd29SKFy9xWmbX66Bk6IjnJc3rfCed+UL/M7vTEtzJwl7uv6mxhVxQ== X-Received: by 2002:a05:622a:1791:b0:43f:fc16:6b3f with SMTP id d75a77b69052e-45004f1378dmr135514091cf.34.1722276086083; Mon, 29 Jul 2024 11:01:26 -0700 (PDT) Received: from rowland.harvard.edu (iolanthe.rowland.org. [192.131.102.54]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44fe8147635sm44235931cf.31.2024.07.29.11.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jul 2024 11:01:25 -0700 (PDT) Date: Mon, 29 Jul 2024 14:01:22 -0400 From: Alan Stern To: Andrey Konovalov Cc: Marcello Sylvester Bauer , andrey.konovalov@linux.dev, Greg Kroah-Hartman , Dmitry Vyukov , Aleksandr Nogikh , Marco Elver , Alexander Potapenko , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+2388cdaeb6b10f0c13ac@syzkaller.appspotmail.com, syzbot+17ca2339e34a1d863aad@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: Re: [PATCH] usb: gadget: dummy_hcd: execute hrtimer callback in softirq context Message-ID: References: <20240729022316.92219-1-andrey.konovalov@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 33C6210002E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fey16c7zkmf75ahiw6eo1mt8ds11z439 X-HE-Tag: 1722276087-72005 X-HE-Meta: U2FsdGVkX1/ymcu5EMu6HZkOT+6gHBheiE9nRWIX1DCPCM1E8Xj3pr45Mmh0vTpd8FeaBSjpTMyyc7Qdkn+qVjAVi2+Ox8l4e5tX6BPONai+V31gUMrhb8qe+Vxfc7mUJ9UnCnHQQ3aJrKLs83I8cwjQWdkp928wyVgXEScLuc/PDKJ8LErj1aYrn5WTWEnE+hKqo378Gqfa03boEnc4dfSSFWYcUU1xY7TFo0N8ZtMKuwY6Gk1Rkrch80JkO/8d2m8n9/QmdNWiZSENKOabYFdF7mlnJ9zjsQvq+B6dvzOJ5sudrpT8cRoD9V6T80EY+FJw/s2Pf/otR0KfyiAVnwrjE+B75G3lI/OPK70EYaYukc+XOfcp+dmVsR5MiBs9eAfAemd6Gsw4X4YVgfzOuRgFm5yhAYgsdlUGVPG8ed1ntCfj68u88ltImeB9BSnD+O0NDi0crlWCOy+t4q86nZ4h+FZjejqQrGwo+kdQYp94oczS1hKEJc/FqGsAKTzZ3Lz573etxyEbZ37YaFhL+FL8Z05cGfkLFPW9yntZy/hbLwRlVnrqV0REo9XeajkmaUwiY4v+IcCITKR5lU5aHB2HTkfFhNZ/REhzJQAiRGE4X7eIsrPhYhZePat1bBnXGucqxsC/HYedrpTaB0wYUN4nXZ0SiLgyojNL0GNdG2iJEbglvDkcSzXJ7MgnOQqurQWdh1CgGa8Oas2oyobKMGZEyWbBH/ctNKQdk1k+S8uhLWxaExuHvKsVR2gUjtqX7UiJR7s0LrLvww64k4Xvj66YelJkrGvnO2FO+JhXi286Gc8lEUhO8YKp4UsuGuIhPILIEIDy27Up9rxF7tpae5qxiRMnuLyUacYcxIXJu6VtfVaVGLfx9peZFD5L3/Xlg6WBJSvCJzA2ZcnWMuYtA41bCD2Cz4oS4IMTbvKsz1wdXCX94zs/EcE4lN83VtbD5IqQjQiwGjGWgavrQTz KgZJVAsb N8SMZGsKa/KS0I/L6PvY+e61q/7iwPWSkhvKbsY4V8ZjP016mp4Qotvhu/cGO9WHY96mSZwxLz6gCFp2F/76z4ya9SCTt/bZxf86BYQVpbMmdxWTWQAVgzQWcjDnQmuVminEkaAc36RO6Cdw3ZPw10L4RezpyYx3actciB0J6x85SdW1J92E/OkD/0ApiAEwD6Y56gctrN1DZMqe/QZapYOoXvWsQf5wD6cPh54YqsDH35n7+EkIc+V4F2VD5wVDY/zsh1q9KIjALIIATwN1J5RRbf44YweTzMGD05CuCbB3O0CNu9z9C6Ka+D089WvO2P+L7QTCkuoxrgV2wUB/PfM6VF1Zq7g+01CqcV09jWD7oKhIzgFvG4Ew29FXRNNknHff9zTpLIbUCKPEFeSXUimIFRkVnOaa8akP9MpmcyAfZvS9qcbNJL9fG8Swqvw1IaAcBHcz1sNh89OB2p03rOOMgzBGzyEv0MygR4whAhQOZYBHkxL0AvQ8q9P6MHwuOpRUrEgsyPEJl/W24FJLkR0QSukVwuz6NClgN1eERR/U6nQxjdDNf9J3VUjOcU/Qfb5JDFvrCE92HCvrauOHqsAYq6BT1WuXajH6B8OYhQMi/HXiU9ELVRaWaNDq5FnktlUTikeIaMzG14Jk/FsP8todd0nXiWfV5wylJN6iSR/yi7L4ODxfvIUTBh5OMNvgGZyEkjUJcYF2FSR3GRqFaagEbSZkG7zI0BHDDdKTxNJXsR4czt6eUV2pueOSTXi/hrEKSiagXZardLvjjCx7sT/kjc8v99tW9odBd/QoNxEUH9XsL1PnhwVJP00dfiwRVrw4j8pLuXeNX6gEaWR14G8pdcpLsGGJOHAQHyISFHjjZnm8Gq5NlFlSgJYvLaBWfm6G10YVZjjxzQPMDGpazeotU7tk1FcXhEJx44wVVuvp2ijQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 29, 2024 at 06:14:30PM +0200, Andrey Konovalov wrote: > On Mon, Jul 29, 2024 at 10:26 AM Marcello Sylvester Bauer wrote: > > > > Hi Andrey, > > Hi Marcello, > > > Thanks for investigating and finding the cause of this problem. I have > > already submitted an identical patch to change the hrtimer to softirq: > > https://lkml.org/lkml/2024/6/26/969 > > Ah, I missed that, that's great! > > > However, your commit messages contain more useful information about the > > problem at hand. So I'm happy to drop my patch in favor of yours. > > That's very considerate, thank you. I'll leave this up to Greg - I > don't mind using either patch. > > > Btw, the same problem has also been reported by the intel kernel test > > robot. So we should add additional tags to mark this patch as the fix. > > > > > > Reported-by: kernel test robot > > Closes: > > https://lore.kernel.org/oe-lkp/202406141323.413a90d2-lkp@intel.com > > Acked-by: Marcello Sylvester Bauer > > Let's also add the syzbot reports mentioned in your patch: > > Reported-by: syzbot+c793a7eca38803212c61@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=c793a7eca38803212c61 > Reported-by: syzbot+1e6e0b916b211bee1bd6@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=1e6e0b916b211bee1bd6 > > And I also found one more: > > Reported-by: syzbot+edd9fe0d3a65b14588d5@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=edd9fe0d3a65b14588d5 You need to be careful about claiming that this patch will fix those bug reports. At least one of them (the last one above) still fails with the patch applied. See: https://lore.kernel.org/linux-usb/ade15714-6aa3-4988-8b45-719fc9d74727@rowland.harvard.edu/ and the following response. Alan Stern