From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48063C7EE23 for ; Sun, 21 May 2023 14:55:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60B29900004; Sun, 21 May 2023 10:55:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 593AE900003; Sun, 21 May 2023 10:55:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43463900004; Sun, 21 May 2023 10:55:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 30084900003 for ; Sun, 21 May 2023 10:55:40 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E021840125 for ; Sun, 21 May 2023 14:55:39 +0000 (UTC) X-FDA: 80814561198.12.EE3606E Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf27.hostedemail.com (Postfix) with ESMTP id CCDD040006 for ; Sun, 21 May 2023 14:55:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684680938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5MWQQJ5orNGMt/23APFYO3dgWJ4x/JHJL6QCSzyUG8M=; b=5fYwqodD4y6lMt8NON51oifktNeHXgq1W16onVA+smT4juVl/wDgGnq826aqYkKzJvE8C3 1msYEEsc4Ryz7/Pb+/s/PyM7+7UKQ76/swedy+4k3FITd93DINzmJPV1GKUyk6JrCPHxot bGtWpwkgeJiYiCTc5JGCMY9Vjil3oY0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684680938; a=rsa-sha256; cv=none; b=eSUEe1muQCUWvfyJVFv/+EZ+shGNuj0J+lXDhStOITDPXjQy/LCzDG9ThupFgoduVuP4sd nwD4eh/1gw004Lt6wzoZW2LRqIQ9Y+SvQS//uwjjUPB8vDb3V0e2tXkiFoMS3RwQyBt9E4 YmbB/9sSmuNLvBJOVDlklpI60xG4Xjg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0Vj5ET5O_1684680925; Received: from 30.15.209.15(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vj5ET5O_1684680925) by smtp.aliyun-inc.com; Sun, 21 May 2023 22:55:27 +0800 Message-ID: Date: Sun, 21 May 2023 22:55:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v21 08/30] splice: Make splice from a DAX file use copy_splice_read() To: David Howells , Jens Axboe , Al Viro , Christoph Hellwig Cc: linux-erofs@lists.ozlabs.org, linux-block@vger.kernel.org, Hillf Danton , Jan Kara , linux-xfs@vger.kernel.org, David Hildenbrand , Linus Torvalds , Jeff Layton , Christian Brauner , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Logan Gunthorpe , Christoph Hellwig References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-9-dhowells@redhat.com> From: Gao Xiang In-Reply-To: <20230520000049.2226926-9-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CCDD040006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fdj9q33nqgofocbu5nzjuqttmfyscya4 X-HE-Tag: 1684680935-220097 X-HE-Meta: U2FsdGVkX1+cbFyGMeCqW9g+NpJq4MBD96JxTB+ygk1Ol9q0pGN7PUOztFtAs7IEghZLjURtbBXu06F6SideqY83e9NJdYwJDeieOkd/RkPesKfCZCZILTWJCFJ7vm7egMgTZ5gvjm5D8kEQ1HyDD0bGR2DlIQuWSTNaPlG+ZSpTq4Aqz65KAoNwYlIH/fD61er5t1DHavNvKLyLJJbFX97+PuxznXES/Q2pKFjssooJN3x+SAoIdhNG8gu63uVd7g6f8ep0vztjia0BeaURaWi7euZujzFn9VYF2L0+kZ24a95l0Q6pvFQOdp4cLWijrRPD5xKJ2H/A6LIE6yCqDRe8SwjRxYkzaAJl1/L2v9Vafg05o4gDTCSQz4NjqADUhr5CNrjk3BmsbE7tNAvfeAU/XNKjlkMKoMx0A7QjVN3grfc/RQy0Si1N5jsKd4M/Vyemzyaq8iPIoezXYZWZVBehw7pulQ6s48waVZ+DGVG2yctEydkc9yPErhv5VVzJs9e3Q4tl0yQ/sbu3omly7MmgQ4Y1K2vdNGBAdH7fms7LKX/lUGd0zefHliGhHgYzXIpgXAQpUc0Kxz62SfBtYxjpyoctedrykO06FE9hRTJkz8lP7RB2sTJ/vdYR5eoqgSkcoNXBNtnr8pQTLjQapSnozEnUHYSXKMkr2R9eq/JZ3kC43xYtu3BftblL4zPXHW3GIv/6mCWQ4oAT9+COr0m+8iY65OThYQk2HffMunkucXpBHSwDfkEIDgx8OrOF0N18a5g2OGHyNJFdoywHbBVKIRFBBDMvXP0tehNVtArBH9unM53KCXgdBHmhNdDFQofM2cmjBYfd+KQQ2FTSeE8qRR0Etd+sWXxSD+f77SROv3oGyhGwd5EGxeyPPr2mJDxvkR6Fj9G1sMXtT3hKZihYYeF8T/TS71BjKWVZ5nXa0C+2LicR6yrPbPaPT94ZSJdDG4icJdihK9ChYJf gV+eHptE itUCofYp2qpSxoOfgXpYTCRwoRGFm45brJjqSR22klZaSoG73+U1inl+3WjpB45eCx+7YBUmvF4XKVroEQ1hxdCJrFgQaKgfh+sEIzg4kdYC5/jUQgelq4N9OMHNjOLrr9Bra6QSOqStJ4EWCN1OX+QmqxFTd8JRFHrc4IqOBE52w1chG1ms0Si1HezJOgnssLQvuTkfgI7Dk9+MFPSMQHRBYbfry+R4ESNz8sSbdzdLc3WnTnaAhQc7ipCqd4L7f9QF0F8JIOAVh6p1xMx+hMwsmMWBqb3SnmIvwqKQXxNEgbYIganZgtiQFmQq5jKqm3bd8eIbWHkoTy/ityi59624eXrLyofR6S8n0R40RslBH4pkI20W93zUbWg677GkUaketRWW8raMI4uwED1smb+Kq9hcd8ETshWTJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/20 17:00, David Howells wrote: > Make a read splice from a DAX file go directly to copy_splice_read() to do > the reading as filemap_splice_read() is unlikely to find any pagecache to > splice. > > I think this affects only erofs, Ext2, Ext4, fuse and XFS. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: linux-erofs@lists.ozlabs.org > cc: linux-ext4@vger.kernel.org > cc: linux-xfs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-mm@kvack.org Reviewed-by: Gao Xiang Thanks, Gao Xiang