From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49293C07E9D for ; Thu, 29 Sep 2022 03:47:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AA1D6B0073; Wed, 28 Sep 2022 23:47:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 958988D0001; Wed, 28 Sep 2022 23:47:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81F936B0075; Wed, 28 Sep 2022 23:47:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6E2D06B0073 for ; Wed, 28 Sep 2022 23:47:23 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 371E3810A9 for ; Thu, 29 Sep 2022 03:47:23 +0000 (UTC) X-FDA: 79963737966.24.92148FB Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf03.hostedemail.com (Postfix) with ESMTP id 8AC8820007 for ; Thu, 29 Sep 2022 03:47:21 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id s206so351069pgs.3 for ; Wed, 28 Sep 2022 20:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=oR8kEmKepn1OxcoDnk+3+f0BMSGhXeHUAukDiRlODV8=; b=YzUZIxmCSK3Cc3CddDpRnQcarNDoKYyfhVUMJbPXN15NYXsk3ACA8BeNC7U1O88cJK uACyigsZ+waxZl7/K9rMWjqKCJECowNnHRfyKUK4z2SWmVocUWEXDz2tPR4A2k/Ao3bZ EvbdV+29w8bdwHzsoDo9uz1jd2AY/L520RrIyiyBW8VUkg4ghjfmWUt5rar+07g5IMlf Eu7jG5JipxB1D3qDYtkRYM/HmNiQnNk7TTfHMTC58ggl9TIhq9CF97P5nud+FjXc97hc VLVe6jS/KGKASeczLYh7q9FJ8Tg2eU3bUgr6V6ae5Tk2QJqZA03VrIYotYclq6z00wMC mG7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=oR8kEmKepn1OxcoDnk+3+f0BMSGhXeHUAukDiRlODV8=; b=wF0uTSqWcmVdkrRZfzwegMx6sYwCdNNOmZufA6TAkdZ8zPXrEqimhs+UHrst6A5nnW 2piDpDxgfihNNndZ3FH4mM7Z34kidqca170VRUeS/jy1EewaY7em8YIrh2Sg0SYzQ43b qM9Q/bca8O6Pz6xgdDjfikBsL8s3v/ib/OwKlng/AgOaIG1CHz8mr6OKGqdVmnhMrBhW PdsIFNBwADCsoatXAI02IxPSFtzx7eq1FlmrQ/b9JG6qFq9Vk4yRsLv1XXQpK5IPdLIJ ZV74j/ZluPcqHL46VIPFyn20fg9J/W/Wdqz14bYhq/UEQ3DxGeNoFcep5EUQNzNXTh+r /W/w== X-Gm-Message-State: ACrzQf0vG4Oa7mxY4VFKx4aycHCmwqTQ8T0lYNhvglEnmxYSCFuSzOTf PI5TM5zMd43/59T4T8Ui634Mzg== X-Google-Smtp-Source: AMsMyM7xwP2/B9SzqOzc2lCojzmWu4yqCZ2w2+v6ELVU29ddC7gL1QvWI4JTNNA+Od4s8rqk3gycfA== X-Received: by 2002:a05:6a02:30c:b0:43c:7c23:4717 with SMTP id bn12-20020a056a02030c00b0043c7c234717mr1100246pgb.412.1664423240257; Wed, 28 Sep 2022 20:47:20 -0700 (PDT) Received: from [10.4.189.225] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id e22-20020a63f556000000b0041c0c9c0072sm4340782pgk.64.2022.09.28.20.47.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 20:47:19 -0700 (PDT) Message-ID: Date: Thu, 29 Sep 2022 11:47:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] mm: use update_mmu_tlb() on the second thread Content-Language: en-US To: maobibo , David Hildenbrand , akpm@linux-foundation.org, muchun.song@linux.dev, =?UTF-8?B?6ZmI5Y2O5omN?= Cc: chris@zankel.net, jcmvbkbc@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song References: <20220926115621.13849-1-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664423242; a=rsa-sha256; cv=none; b=GlfK5yIigYw0wZFPMiQryiLVrOB/MdDTzQBWizWAkl9lqtKh/J/u2oMDj8H5ERld7TyU4I cVeZJ1+gGT1zk0XWXlrFqR6tdZTnJYluy8XdRDsPm5zfndiWR/tEAF/+Z29PRHEFM3HQDY 9dDApEjx+qgBRsV8REP5CnpEUUJ95dg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=YzUZIxmC; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664423242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oR8kEmKepn1OxcoDnk+3+f0BMSGhXeHUAukDiRlODV8=; b=nuTIdd41t4wXsd/AHBv+cuhMzJyLQuBWhWGuQbWgr81i5EjVf0AozUirCqL/JwVezJUb/5 yhwEM8KcArgzuKbeYgD/zAlh8Q2Nki1cUd18sTn8BfHwJPbzjBQD+svWYxq9rU0qFlKTtP xKodilxG4xARQFtKZS1yV97IoMijmx8= X-Stat-Signature: hctmctwzxfca89eso43f4yeqtx5w4ey4 X-Rspamd-Queue-Id: 8AC8820007 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=YzUZIxmC; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam01 X-HE-Tag: 1664423241-260270 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/29 11:27, maobibo wrote: > 在 2022/9/29 11:07, Qi Zheng 写道: >> >> >> On 2022/9/26 22:34, David Hildenbrand wrote: >>> On 26.09.22 13:56, Qi Zheng wrote: >>>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >>>> if PTE entry exists") said, we should update local TLB only on the >>>> second thread. So in the do_anonymous_page() here, we should use >>>> update_mmu_tlb() instead of update_mmu_cache() on the second thread. >>>> >>>> Signed-off-by: Qi Zheng >>>> Reviewed-by: Muchun Song >>>> --- >>>> v1: https://lore.kernel.org/lkml/20220924053239.91661-1-zhengqi.arch@bytedance.com/ >>>> >>>> Changelog in v1 -> v2: >>>>   - change the subject and commit message (David) >>>> >>>>   mm/memory.c | 2 +- >>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/mm/memory.c b/mm/memory.c >>>> index 118e5f023597..9e11c783ba0e 100644 >>>> --- a/mm/memory.c >>>> +++ b/mm/memory.c >>>> @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) >>>>       vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, >>>>               &vmf->ptl); >>>>       if (!pte_none(*vmf->pte)) { >>>> -        update_mmu_cache(vma, vmf->address, vmf->pte); >>>> +        update_mmu_tlb(vma, vmf->address, vmf->pte); >>>>           goto release; >>>>       } >>> >>> >>> Staring at 7df676974359, it indeed looks like an accidental use [nothing else in that patch uses update_mmu_cache]. >>> >>> So it looks good to me, but a confirmation from Bibo Mao might be good. >> >> Thanks, and Hi Bibo, any comments here? :) > > update_mmu_tlb is defined as empty on loongarch, maybe some lines should > be added in file arch/loongarch/include/asm/pgtable.h like this: Seems like a bug? Because there are many other places where update_mmu_tlb() is called. > > +#define __HAVE_ARCH_UPDATE_MMU_TLB > +#define update_mmu_tlb update_mmu_cache If so, I can make the above as a separate fix patch. Thanks, Qi > > regards > bibo mao >> >>> >> > -- Thanks, Qi