From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3851C369D3 for ; Mon, 21 Apr 2025 02:45:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 597296B0006; Sun, 20 Apr 2025 22:45:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 543916B0007; Sun, 20 Apr 2025 22:45:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 432606B0008; Sun, 20 Apr 2025 22:45:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1978A6B0006 for ; Sun, 20 Apr 2025 22:45:24 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D755D1611A8 for ; Mon, 21 Apr 2025 02:45:23 +0000 (UTC) X-FDA: 83356509726.06.92ADD2C Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf05.hostedemail.com (Postfix) with ESMTP id D6D18100002 for ; Mon, 21 Apr 2025 02:45:21 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NinYDjvb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745203522; a=rsa-sha256; cv=none; b=4JeUk3iKg2tuI32t1U3AXA8UKCVwREIEZWUbzMx+MwpqwLaPnJUvKgvDHvD38Ngkxp1wS9 m/llh3OAgXhU4SEtNyyvpG8io5XN/7DUOstJChJOMLSU77P8mxDIy4j1R9TtGu43YiiNPx qMH+szYwgBrNwxi0rwL0C74xI6B+thU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745203522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Lfdw020RvW8ZqZJ+w5NGkPHNmwYs6jOXtSJ4CBaPv8=; b=MmKPJOyce3yXzVdnXt/KnxCBM75StAXsX8FVF1DHat8LLgtKEkcw2BRw8Z0YlzTrpHzkbI wnhw9XtZol2ZqloBbtDRPjqqDikYsesYIe73mcUJxYOgkzGPkEL/HOldEKiuWCSTv5NDg7 xtuXP+DOI/UEHfTlUl+3EiPB8F14/Xo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NinYDjvb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=ye.liu@linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745203519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Lfdw020RvW8ZqZJ+w5NGkPHNmwYs6jOXtSJ4CBaPv8=; b=NinYDjvb8vYHaVWb3pHXCNAZXWrE4VxdXQVvHho++DzZVDK5OmSRbTrREbR3yjKaLLjAyf ddJwzXEQsJtkCqaCqISQZN7j9jTUszIw4tvKR3PL3t1smY+yYOrOSqRjsFQmIXBYkeI60l yoXpROa+bxx+tT9xPvbe0Sbp2BcJSGU= Date: Mon, 21 Apr 2025 10:44:41 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] delayacct: use macro to simplify delayacct_end calls To: yang.yang29@zte.com.cn Cc: bsingharora@gmail.com, linux-kernel@vger.kernel.org, liuye@kylinos.cn, linux-mm@kvack.org, akpm@linux-foundation.org References: <20250420115848388DXE4HgOnwCNl4IjrMloB6@zte.com.cn> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ye Liu In-Reply-To: <20250420115848388DXE4HgOnwCNl4IjrMloB6@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D6D18100002 X-Stat-Signature: qgd4ko6w16wqergqpc469npkouqw56p8 X-Rspam-User: X-HE-Tag: 1745203521-474437 X-HE-Meta: U2FsdGVkX18QMHVGnkOycPqpu3hcrfVG1OGi2muj2tELYaeAAVia0ebiykGbLJBMx8tmwcX98I2320hl2EDO8KYNGc+OmkJpXCIMgczs075zyhtIGH5j9LPOP1TkJIHe6bNVsTyTraiu3I1TrA/OBuHklbVP/SrGcOcf4PNqKdFT5HmVwzt5Tf6KeRNchPnK7o/19ALDecU77WwdzOUh85fwK8V7Tyg99NXR+I4ByhEIs7Xwb8QX0gSnLZ9JfI8S449Ni4xDca6TGajkN+wpqCCHtmu/NAgRrt6mMmhtOR2Vn9FuWsWr1zfsHGURn24BAgqkWq4L/HxNCgojkJafsa30xWwbhzkepOimVgxOuTWX4/waEbz8lDCwMYM4zBDXWcuuLra9JSRo0LK73Y0zcExJroRa5jXUeW+FJYTmGM9KnTtm7qThT93D8L6M0bHcAzCvev+e9lelk5fMlxxJ+tbPxzMbU6dFLrON8QlBnID3dNnlFZidvf1bvYTT5JC4G1pg/QYsvtwONG9nXjnZTJM5ulTaGDAMMXLpp4RpX3yUO0ANqv3jdh2yrTKDbm1hE9IiCgl927zxAJqpz3CTzxfSuVSub242EkFkO5GJlqJUpSu77Zh7XdYOdFxwYnLaH6edTDZzRd9FrGL6z9n6UpfyCdjxiOvfnb5yJW83mUvYJJQjuluBj+WdVX1jDdwufyWan7kNTys2p7wlXR5CW0+4z9ckL00ga8ha4XpK1VNzpRuEm7IBXXF7G9l6XmBpGo8o5Kk81BTPvVX5jV5ompQBv0TykvkBPO5wvFVw+PvfgwzGRrepuoSy5m7Yx+Bg0npZncCGl5z2Xy07C2Y/DJZQV1/UKofFRPAy3zryLCQ9gNTPZ7BZFb38foq43B2lQyVZbZzjh4aNs3mI7msSLQWULgAfsr84SyLqw0579/MOQ8ykI2w6cMr/tItvjVOSFcjLp6tt8lo+FRa2nL8 4H11O2aX eCqJiTQfkUfz6ixpPPTT25ta0HwUv+TnhZciAr+yO5wvjCR6VSZRd+jnreKIpoPWjnvP7RwtB/5bJG91EpO0xuTZ7BvmskJ5tAail0M3fp51rOIIu8INJ2eb0CeqMjqB34qOF+/7N+oEaYB9p/Y4y5iODWb6Zz9E1x8X0FbSrcywDy53g6HoynXTqL2rxkFcbROZZp9hYDbsbXoLVcxbPIu2aGFMiXGivAtvfnaqCRKY4uPJQ3onbFQL8p8W6y8k0cgJoTsn8Eupai2sr1uvTHTHoBaIFKLKXTGP5LXdfBh375wn8Ye5mg5MVHu3BqFMyRtH75kl02XXmQLANmOTdEYijbl8jmphE0cq19tJKJf98X6wbJLcoxGG6DiQunPZBmyoHc0eztKjOuA48gKsajKpwSVAxmj6nCL95MLiNeOgWahddHrxwtNwSaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/4/20 11:58, yang.yang29@zte.com.cn 写道: > Hi Ye Liu > >> Replace repetitive calls to delayacct_end() with a new macro >> DELAYACCT_END to reduce code duplication. >> No functional changes. > Please CC akpm@linux-foundation.org and linux-mm@kvack.org > next time. > > I think it's a good idea to use macros to reduce code duplication in > functions. So what about also use macros to define > void __delayacct_##type##_end(). Most functions can be replaced with macros, but considering that the parameters of __delayacct_thrashing_end in this batch of functions are inconsistent, is it worth using macro definitions only for other functions? Or do you have any good ideas? void __delayacct_blkio_end(struct task_struct *p) void __delayacct_freepages_end(void) void __delayacct_thrashing_end(bool *in_thrashing) void __delayacct_swapin_end(void)                                      void __delayacct_compact_end(void) void __delayacct_wpcopy_end(void) Thanks, Ye Liu > Thanks!