From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF09C433E4 for ; Fri, 10 Jul 2020 14:10:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A7A3E207DD for ; Fri, 10 Jul 2020 14:10:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7A3E207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 438C68D000D; Fri, 10 Jul 2020 10:10:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E84F8D0001; Fri, 10 Jul 2020 10:10:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D70D8D000D; Fri, 10 Jul 2020 10:10:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 16FE98D0001 for ; Fri, 10 Jul 2020 10:10:36 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C1E371E1C for ; Fri, 10 Jul 2020 14:10:35 +0000 (UTC) X-FDA: 77022351630.29.grade45_281753926ecf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 978E418086CA1 for ; Fri, 10 Jul 2020 14:10:35 +0000 (UTC) X-HE-Tag: grade45_281753926ecf X-Filterd-Recvd-Size: 3428 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 14:10:25 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=17;SR=0;TI=SMTPD_---0U2IjCvH_1594390221; Received: from IT-FVFX43SYHV2H.lan(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U2IjCvH_1594390221) by smtp.aliyun-inc.com(127.0.0.1); Fri, 10 Jul 2020 22:10:22 +0800 Subject: Re: [PATCH v14 07/20] mm/thp: narrow lru locking To: "Kirill A. Shutemov" Cc: Hugh Dickins , Matthew Wilcox , Johannes Weiner , akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com References: <1593752873-4493-1-git-send-email-alex.shi@linux.alibaba.com> <1593752873-4493-8-git-send-email-alex.shi@linux.alibaba.com> <124eeef1-ff2b-609e-3bf6-a118100c3f2a@linux.alibaba.com> <20200706113513.GY25523@casper.infradead.org> <20200709154816.wieg5thfejyv2h2l@box> <20200710112831.jrv4hzjzjqtxtc7u@box> From: Alex Shi Message-ID: Date: Fri, 10 Jul 2020 22:09:42 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200710112831.jrv4hzjzjqtxtc7u@box> Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 978E418086CA1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/7/10 =E4=B8=8B=E5=8D=887:28, Kirill A. Shutemov =E5=86=99=E9= =81=93: >> * hugetlb_fault_mutex (hugetlbfs specific page fault mutex= ) >> * anon_vma->rwsem >> * mm->page_table_lock or pte_lock >> - * pgdat->lru_lock (in mark_page_accessed, isolate_lru_= page) >> * swap_lock (in swap_duplicate, swap_info_get) >> * mmlist_lock (in mmput, drain_mmlist and others) >> * mapping->private_lock (in __set_page_dirty_buffers= ) >> - * mem_cgroup_{begin,end}_page_stat (memcg->move_lo= ck) >> + * lock_page_memcg move_lock (in __set_page_dirty_b= uffers) >> * i_pages lock (widely used) >> + * lock_page_lruvec_irq lruvec->lru_lock > I think it has to be > lruvec->lru_lock (in lock_page_lruvec_irq) Good catch! I will update it in next version. Thanks! >=20 > No? >=20 >> * inode->i_lock (in set_page_dirty's __mark_inode_di= rty) >> * bdi.wb->list_lock (in set_page_dirty's __mark_inod= e_dirty) >> * sb_lock (within inode_lock in fs/fs-writeback.c) >> >>> local_irq_disable() also deserves a comment. >>> >> yes, I will add a comment for this. Do you mind give reviewed-by for t= his patch? > Reviewed-by: Kirill A. Shutemov Thanks a lot! :)