From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E662E7718C for ; Fri, 20 Dec 2024 19:01:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 224326B0096; Fri, 20 Dec 2024 14:01:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AD536B0098; Fri, 20 Dec 2024 14:01:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1A876B0099; Fri, 20 Dec 2024 14:01:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CF0EA6B0096 for ; Fri, 20 Dec 2024 14:01:15 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 445F0B01B7 for ; Fri, 20 Dec 2024 19:01:15 +0000 (UTC) X-FDA: 82916254554.18.4A4D613 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 6423B40011 for ; Fri, 20 Dec 2024 19:00:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aoi7r9Pv; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734721235; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ug2XIccF0/YqFCL6Bdhqogh1COfkkzUL+XNw1IcnJx8=; b=XDbnu4MtO4De7sIC4pKblUCGFQHlCn6vttMs6Qx8Ph4Kjy27DzwvLQG2SsmVPWNPnoOsFU b55RPpXWT2fdZ4xlUmy5fV+OVpDl8qDk4c5EY8fQmxwIiYqVzgckwJyGbZA1bgwvWp+73R fdnv62/R3eMkZYiKMBmJ0OhzLTW/MEg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aoi7r9Pv; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734721235; a=rsa-sha256; cv=none; b=xhyOV+3Itq71kV2+XwDqJoD6mkwgatej76l2vQ9B/pcIIgNvIP5bjzSb7j8cJNx9JKrDD5 Yx4mXGs4DEpng0rjwiLzO3t6XE79eSZgzk5VgINcrgkVDuw31/OiTOFsTuKeDyLPJGA6CX anRXHTztKz4fmfE6Me0xtFixWQXWQWs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734721270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ug2XIccF0/YqFCL6Bdhqogh1COfkkzUL+XNw1IcnJx8=; b=aoi7r9Pv3zvD+wsIZCGJLWuYJz33wGVtBpHh6iFTw5c5VioK71w5s0bbafjrCudxTJrVBQ M1ZUl4W3sDF4B3QjTOqHbs6WdwFVpPyy2Pulc0U/4HBVP2vaaU3i4rg62TZd03e/C8UBqw HUWUr708i+4QnYKDM2je27ecYGgcoX8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-3RDuiKSsNuGsEXJWXLyB0Q-1; Fri, 20 Dec 2024 14:01:07 -0500 X-MC-Unique: 3RDuiKSsNuGsEXJWXLyB0Q-1 X-Mimecast-MFC-AGG-ID: 3RDuiKSsNuGsEXJWXLyB0Q Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38639b4f19cso1574783f8f.0 for ; Fri, 20 Dec 2024 11:01:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734721266; x=1735326066; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ug2XIccF0/YqFCL6Bdhqogh1COfkkzUL+XNw1IcnJx8=; b=GxuLk+28jVuT2/JUXnrULWOv6XPRgEcm0VgEwaWGFTmztrMjD+Lsk3oWdLpPnkKd9s IiY2QSeJvlrC05/a5DFS4wXe9EaCjma3Xdqd9tp7ghBj1RpWMxkhe5iSr/A3M6Vd+tqT nx58a4PuoL6k8kwnn7+c8EfqNHe62mtz7elUmugK3AhmsYExf+nAElVvSF7G53Qg02fp fmp3Ynzal7vzdKrgz5IZJ2SZ+5qZCBXPlw+LtRxnKAwub3MNPejNIwdxePDaKx2qGSnF KIJ2/Cf1zkRbMFAwZoAJwi7Dm5CDffKVW7AIgNESZ5+PTDqqQf1SqrU7fygRgzczsxI1 F5rQ== X-Forwarded-Encrypted: i=1; AJvYcCX5//iVkJVWPoWnp6b/1v3NlKsk0tOLZ53t978ZsDyOAHP5kqJbnsqYdvmelRyKe6RQGklprpdpLA==@kvack.org X-Gm-Message-State: AOJu0YysQ4+Mj8zeMcRENOMSFnXtWlfD4d2mnVMmSJSty2G6ejjg5hJ1 lXqgdIhs3OT6Ixqt9lBnJAN3rLHtmrJlEBSYbUKhGcd/vzZJ+SIA2QPEDgnooUbOXeCyRxrvDnz 7l3KYJWzJOHQehQ4YCXoQ5Muw8lHRH2g04FTsEm/75oNA0XUc X-Gm-Gg: ASbGncuvCoc6chc4rDeaqbNNsFCy6DNCsxK2ToXAJNdcKw294nSGLbm8W643JMfxXLy Yfzq/2PBNZ6e6uoz0eilSJizLqw3scOhLKpIF6jbLjhoO9zLJvbL/t5AZp0i7vJBSW90LSM3Faq fo+biql8R8nXwNTAg4YBgE1jJ44Ch4TOHeKV30QrFPTf9pqRC86lUJO3gDxbFLs2Um5Irpi1BCo VAQIPdrAQBXK+B8WfEfdP8UpnrZ2/LKuCPrzAK9mJSN5OpPahG2m1bRgTzC9mHYHwV8H0JClor7 2M2FajNAw7bSkT2BjbPFVRcNXwppNPoiIfBw/MB972CWdJe3/phLdAVGgMMcwdAzSztJteEj5Ke 8Yk5p6Dpx X-Received: by 2002:a5d:6d84:0:b0:382:46ea:113f with SMTP id ffacd0b85a97d-38a221e2799mr4695507f8f.10.1734721266497; Fri, 20 Dec 2024 11:01:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IE509IM4SN9jE/jQGrc5Y1LN5lcHkipiJsCNaT3s/Oi8fyaGDIBaILpQ3fg+YFYHK3krJT9Yg== X-Received: by 2002:a5d:6d84:0:b0:382:46ea:113f with SMTP id ffacd0b85a97d-38a221e2799mr4695410f8f.10.1734721265957; Fri, 20 Dec 2024 11:01:05 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8b874asm4653683f8f.109.2024.12.20.11.01.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 11:01:05 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 20:01:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/25] mm/memory: Enhance insert_page_into_pte_locked() to create writable mappings To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: <25a23433cb70f0fe6af92042eb71e962fcbf092b.1734407924.git-series.apopple@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <25a23433cb70f0fe6af92042eb71e962fcbf092b.1734407924.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VYVRHdjno6m4eKAHdN-_GuIBlYkMZLbZPgl_qdp846M_1734721267 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6423B40011 X-Rspam-User: X-Stat-Signature: zi7sdq7tukdoez4fgfmjk9zugph9hzb4 X-HE-Tag: 1734721245-332417 X-HE-Meta: U2FsdGVkX19w0mFVr4Bdq1Yvan9tGnv0auLl0aFgcs0gj9IEbUWK1z6CaIkaQSU3/0XvtcfI1p9NLexLxrewloHFxT2TwVe2Asf/GhcNY0eRaP/tgYgoI+F+TmDHTOGjeKHhplZCDTBfrA1+RZqaGg4F8stYvjyk7fQiWoa32PohaHHteuZ3+bXWStD4shWei9jSANpOQfVQ8szWADyOVwXps7hHDLdkWDUzZzrKfEXKPP0JN/nonsc6iwm5EwLlVMhZtkxoy13SJhF6gf6hhq0kTI8+pMC7MDeeLA9fljwf1FW6+pHPF0DPb3hUfdMvprn6q/no3vQYGM9/qDqzJIpBGUnV1bmMJzxyMxFViO+J8EC4RtPNbsBDvhMyGKwy0uBVjonbSqZXStv4/i8hCVY+riHLtWUpqbw/8PcoDLa5WiWDXmVX7x/3W2KuZNttdEQSPQoUZ8XTqoa6AVN6sTC5asZzQxLEV2om1cVa0bW599B6edcnpCKlGD0zD8FfnzBqjOCVmTOb/oOczDu6Zd94CrTQ7KaVMl2BsdR+pD6i4wat1V5EIRtr0p+LltUW4vIQNiAcwa4Am9mlX7B1S5tX1rvj0/ww/omUgyK0OI0kfh2xbnUcpGYyWFRwjh7f6ZfWneD9wJj/Bt7g4GajFo/kGucCQkYnyUZgbhLgfqZ9V6Vzas9auVrIImM8O5l8flKBiQQ8EFbt7ilJjvRKSVnY3lvnHmbVY4rYn+BCLOcekG0b/ntpL/QvgAJKCLoO/KHc7b8FwpRyKJm3mkLBECYva67z5cbaMgL9hwCNPRVE/tmrTOODYTFCo0GDsHhr530cQ05mhutw96AcLdNhrf7R32wXEdTGFhLMD8+dH9F0GyiC0RXlkkOzSJrYl9eBWIQZHrF4J7JEL2p3wvPQTqTT18p5vswljyBhtV+SnREowL1wIXWvM9GKLZ12DcxI/BJK7t9X2oB42zaCymb f2u7bKyJ uie8RDItv2vvaEOJ93UNdY31AcfNnb4qt24NeTkOSbnt7h5U63JpyIh9kXFhceMklNYs2/dmD8+mcqNRfFAR9EFtPFsEOMPMzMdQYz+LExxdPdM1Bsim2MvPQd88SknZ6x7tQJ2kYqFor2i0GoyFvNYVdFonbFiLSNWCjVkKoSBAYJ3bthY3ncVf31cLBC/0aBZJjyB+9t1z1feFQ6BnUX5BFSppiyCYcEPaVVAcTphvlP3ae2RMW7qswS1vCTPwWysnKprrYRm5q8HdJdu2AT+8ojp8RGxZ8D/3nNHI+hEMmKUjbwYJ/SkZoFOMLJxmzB9XGApvBkuhxQ14zqcLeRs6IFPHl4/JgqWp774wX+CarNvvXiqCOA0Ji0GqxYQkHCzznmmXWPXG4Y+Baka6gFP1DmWbvLur+aEFW9YziWJFxBc4tidEjhGbY6sEKtXnstarRUuTKMMc+ozmP0tBRDD/6d77Y9uL07kRwuJEHQARzcf+Qc1C2/di9feITV2Vh64BKU/xslCwk0K85NbIGbZolJoYlqjFsJtnvYU2yrhubjTkZ//fgbxjKHw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.12.24 06:12, Alistair Popple wrote: > In preparation for using insert_page() for DAX, enhance > insert_page_into_pte_locked() to handle establishing writable > mappings. Recall that DAX returns VM_FAULT_NOPAGE after installing a > PTE which bypasses the typical set_pte_range() in finish_fault. > > Signed-off-by: Alistair Popple > Suggested-by: Dan Williams > > --- > > Changes since v2: > > - New patch split out from "mm/memory: Add dax_insert_pfn" > --- > mm/memory.c | 45 +++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 37 insertions(+), 8 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 06bb29e..cd82952 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2126,19 +2126,47 @@ static int validate_page_before_insert(struct vm_area_struct *vma, > } > > static int insert_page_into_pte_locked(struct vm_area_struct *vma, pte_t *pte, > - unsigned long addr, struct page *page, pgprot_t prot) > + unsigned long addr, struct page *page, > + pgprot_t prot, bool mkwrite) > { > struct folio *folio = page_folio(page); > + pte_t entry = ptep_get(pte); > pte_t pteval; > > - if (!pte_none(ptep_get(pte))) > - return -EBUSY; > + if (!pte_none(entry)) { > + if (!mkwrite) > + return -EBUSY; > + > + /* > + * For read faults on private mappings the PFN passed in may not > + * match the PFN we have mapped if the mapped PFN is a writeable > + * COW page. In the mkwrite case we are creating a writable PTE > + * for a shared mapping and we expect the PFNs to match. If they > + * don't match, we are likely racing with block allocation and > + * mapping invalidation so just skip the update. > + */ Would it make sense to instead have here /* See insert_pfn(). */ But ... > + if (pte_pfn(entry) != page_to_pfn(page)) { > + WARN_ON_ONCE(!is_zero_pfn(pte_pfn(entry))); > + return -EFAULT; > + } > + entry = maybe_mkwrite(entry, vma); > + entry = pte_mkyoung(entry); > + if (ptep_set_access_flags(vma, addr, pte, entry, 1)) > + update_mmu_cache(vma, addr, pte); ... I am not sure if we want the above at all. Someone inserted a page, which is refcounted + mapcounted already. Now you ignore that and do like the second insertion "worked" ? No, that feels wrong, I suspect you will run into refcount+mapcount issues. If there is already something, inserting must fail IMHO. If you want to change something to upgrade write permissions, then a different interface should be used. > + return 0; > + } > + > /* Ok, finally just insert the thing.. */ > pteval = mk_pte(page, prot); > if (unlikely(is_zero_folio(folio))) { > pteval = pte_mkspecial(pteval); > } else { > folio_get(folio); > + entry = mk_pte(page, prot); > + if (mkwrite) { > + entry = pte_mkyoung(entry); > + entry = maybe_mkwrite(pte_mkdirty(entry), vma);> + } > inc_mm_counter(vma->vm_mm, mm_counter_file(folio)); > folio_add_file_rmap_pte(folio, page, vma); > } > @@ -2147,7 +2175,7 @@ static int insert_page_into_pte_locked(struct vm_area_struct *vma, pte_t *pte, > } > > static int insert_page(struct vm_area_struct *vma, unsigned long addr, > - struct page *page, pgprot_t prot) > + struct page *page, pgprot_t prot, bool mkwrite) > { > int retval; > pte_t *pte; > @@ -2160,7 +2188,8 @@ static int insert_page(struct vm_area_struct *vma, unsigned long addr, > pte = get_locked_pte(vma->vm_mm, addr, &ptl); > if (!pte) > goto out; > - retval = insert_page_into_pte_locked(vma, pte, addr, page, prot); > + retval = insert_page_into_pte_locked(vma, pte, addr, page, prot, > + mkwrite); Alignment looks odd. Likely you can also just put it into a single line. -- Cheers, David / dhildenb