From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CEE8C77B61 for ; Mon, 10 Apr 2023 13:02:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D096280017; Mon, 10 Apr 2023 09:02:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 480D4280002; Mon, 10 Apr 2023 09:02:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F9EE280017; Mon, 10 Apr 2023 09:02:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1D6B6280002 for ; Mon, 10 Apr 2023 09:02:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D3C3180338 for ; Mon, 10 Apr 2023 13:02:15 +0000 (UTC) X-FDA: 80665494630.14.31E9ED4 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf13.hostedemail.com (Postfix) with ESMTP id 3653A20021 for ; Mon, 10 Apr 2023 13:02:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S8wYV9um; spf=pass (imf13.hostedemail.com: domain of perlyzhang@gmail.com designates 209.85.216.66 as permitted sender) smtp.mailfrom=perlyzhang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681131730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u5w185Me5M7zSn4d9QrTVpJhTLjbMKcakFOrEP4Qx0w=; b=PdAFNW+ZHZ4t+yP967wkM9EGoZzdQXzSV0gaRP13UUWQucF175YGAzh7izwN6fAdMn4oAT Gpfd4b3sdsMzz0Qkwl1NonOeASS8irnjwHDkY4UXYg+vE0cLHiLnDE8tmRlwN0Or1F+h2p kFHWJ3o49iUB3LrfLg0IxBKJbd2Hcqo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S8wYV9um; spf=pass (imf13.hostedemail.com: domain of perlyzhang@gmail.com designates 209.85.216.66 as permitted sender) smtp.mailfrom=perlyzhang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681131730; a=rsa-sha256; cv=none; b=ucVh+9Ld0kfl16D3Pjm4sQF02MPYggEMXi9NhSWGL77spkwyghDl9YcSOLipU7MECLk6Uf W6V7sXOcxEOjh+C7GFq1VhLDBQHlaTSHvSAzR77N4Dn81y16LM2qfeCGnX0rUKIlUzAfzK DrzWe1Dt2ZXoc2jV+oMy4z2R6tppxwY= Received: by mail-pj1-f66.google.com with SMTP id h24-20020a17090a9c1800b002404be7920aso4328868pjp.5 for ; Mon, 10 Apr 2023 06:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681131729; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=u5w185Me5M7zSn4d9QrTVpJhTLjbMKcakFOrEP4Qx0w=; b=S8wYV9umEhgUZNjfILciRNDGBn7cJijaO7FXTAKY4FSEyNceJ5QHXyHR9jq/USG+Bd pusNPwx61zaBzazu/5Mb9CLrs223026k2XjjFwXmJtLoOa8FoCpuwHL7GPwE6yHczywS KbXdQ65vKRtY8rYYzp6E4UmP1t6pgFrQhGlXRb2EpxBycbBKYbEWfmA5m0iAEzCTIC1a 30QW/mYSGaV6KSqgtpoygzqzjHC8c6ug1kMBzieVtDGsfcXBEQXZNFy8lU+R153IqLJG y2l2nbV0Q7rlFr8L3r6AgXkrrHXeuexg0rOz42hyuacA/1wOv1DJWTuZwuoTSYrJyQ7w jr6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681131729; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=u5w185Me5M7zSn4d9QrTVpJhTLjbMKcakFOrEP4Qx0w=; b=lAOxhY8JF3Ez3u92Qo9zLWbOPmNd5NyuMw1RfuE77S2Hu4HRjsNpM78XebKrJx780z QapjrikUaDLi1ahXreYI/2zwB3t2qGrXeE51ttKPYgbiKHOb7vYbvCaKxpSk9MB/P0ah dEQcpEAeagDvMThEXlIG+cai3VUEoONvWQIiJ+f8vT6WHetv1Y7mYGum36w9pF0JAHvy 3/oeA/rAwlcoRrktNqsuwFqLBVvJTz3B3jGfxLSd/wItS4JrJtvurmh/dp9pvOK7X1fS I3apgaBI7y7UYS31Xm6pJD0/jgg14Yg3w1l+0Ltfi1ff0os/sxNfwz00nTUR0tfA1wZs rF8Q== X-Gm-Message-State: AAQBX9d49iwZfJ0RfXYbMk7syfIGrO2T0Ne7Hl4mzBHJuXfqG8a/eUKt MTXAwbaMgtGkKwRQ7pZcNwATJtfjDhUy2PoF X-Google-Smtp-Source: AKy350aLe9TwzIVhf7jL14WwgNiiUj5REUzvaSnIBPqjDytnJ8YZd0SiIsDGsQ3zlvToLv4fSu8dsg== X-Received: by 2002:a17:902:d503:b0:19c:a9b8:58eb with SMTP id b3-20020a170902d50300b0019ca9b858ebmr16999131plg.12.1681131728814; Mon, 10 Apr 2023 06:02:08 -0700 (PDT) Received: from [10.200.10.217] ([139.177.225.248]) by smtp.gmail.com with ESMTPSA id d3-20020a170902b70300b0019a8530c063sm7741083pls.102.2023.04.10.06.02.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 06:02:08 -0700 (PDT) Message-ID: Date: Mon, 10 Apr 2023 21:02:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] maple_tree: Add a test case to check maple_alloc To: "Liam R. Howlett" , Peng Zhang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org References: <20230407040718.99064-1-zhangpeng.00@bytedance.com> <20230410124144.ouhhnmfoipkqtveu@revolver> From: Peng Zhang In-Reply-To: <20230410124144.ouhhnmfoipkqtveu@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3653A20021 X-Rspam-User: X-Stat-Signature: pad4fyhmqdkwkebr1xx79xg1acpqcoy1 X-HE-Tag: 1681131730-550234 X-HE-Meta: U2FsdGVkX1/KXKG9rFYGrMJMXaOM7RGYB/rSFb1fFnOgGm9dXGt7nvel8Lmlu2cdIBcI/La4naPqTnnetZVUL7S3M2n4YWHpUMrGK/lveECcB2TWXnZRXYVfYKp3U61FnIVRqhpqLrtb461weS3hvP0EaTwENi6rPmqUPZWDJIQE3/wsWMjFZ1uhoSfzkCPZr3vTjsbM8K5bZQLhy8ExArZe2iiTOuDD+PXf31EMbtl2mwtF3Pt9Oa7qIftnBVP6b072w3cY65ofRSNWQeHb0Mf/eClDvBOBc59IQr1hQQGTk6GTUqSisNn50RnLIiJuhc9Eoj6AaDlXrefTayEVcoi7h1CcYZ7HD4LX4Mnhjl/HC8iGOZnA+AQ3ClPgX6SR7pZGGNgKyn2DaSTPDKsiOO1cKMus9wU2MojjR/3LRhWDlxxtYKg+mf++eRdrb7SgOkcYTpYq/xk4ys0mSzhz7+PC3pW38S2cmZPz7eIp7wemHxRCR64stMpfpNMuAK0JA6xNKeLdq7aG/qRdv/2ODnhuYyfWBk0WK+nCLolrGRmv4v3pYlwWKclm38zDfCrsaggRtaHLmqAU/eHJLYJgUJQ8tgtHwVZE7sY5e/aaKG71WWcF5vb4YF5+UnXZMTFHLWsA+tOn5riumnT8xvg/O0sEUPEaFqdF+zFYM+tTPTcB9L9MYKcdaYDzFdn1SS30DbS961OExv1UmQacVov3W3x+2EC4zMx1kkUj0M3/yb+6pMKO9bhiyxtxKJj+mpu8D6ZlOag02fdHfyPzTDHYUVuCmZ49YxgEIur96bWj/ejRROTyp7S52yp1e835wfdtsnwbIJlbY8zu6sMJOeHxS2pAxyVT/I3VJaDgh8MMo0Njk57l6nKRtXucwxVgSPVQR+eX4Fl3R7Lb7cHcg1mbBUfxQRXhH/8eIwiBKin+h6Q9qteBYj/2b1jB2xlDpJNglEuzS7JroT5A8XQPR50 zC7Ucf9r aXgkuXCyqYJG7ztUqCwXu4BlJCnzE7w18OtDuFfGwuuDkP0mYTu6ZxbgtBC/FvXHrwGWUEf9Wq5yDnXjiezlf0NvAIDX5odNVdfZJ8DQA65DkQUMLgQkYHBpJxX8dkZIsjTymFjWy1XOktux3DUoFHDHMHoHS1ojPqeIY0PNxBL9qqwodcBqctWD4LChYumEByqyEqVlPJ79uKuEewVGemOrP4pleDyuU9YWGe7sl1Z0hn3fZXQf6umPzAhiawYmxvOOjgj9/ke/nWelQsETudYgvS18VaED09o/7OXlvSviAeJ+EMnzH5N7L36QGSywxrTMZGisoaVmZn0R5RWQDPTCWmsgLNiwxWqUwrr0esU8zrfHJ4SBeiHDx+CuwllokyXwJuga6Cuby7arr/UCPrZS9bMXqU2PtBoXvv02gEMzfB4tTVHyrqtXyiE1J+zclFQPM1wOIcpy3SwIs23Tta2sWmRn1U8ufpzs05xeZWhhf+03iMzLd1cDwC+8CgzEWMjXYujG/X4EHRhS1riaXMp1+jE5eVeQTdgyX6qlNWJQMc/M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/4/10 20:41, Liam R. Howlett 写道: > * Peng Zhang [230407 00:09]: >> Add a test case to check whether the number of maple_alloc structures is >> actually equal to mas->alloc->total. > Thanks for the test case. Can you please send the code to fix the issue > first in the future? This way the verification code can be used to > bisect any issues. Ok, I will exchange the order of the two patches in the next version. > >> Signed-off-by: Peng Zhang >> --- >> tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c >> index 958ee9bdb316..26389e0dcfff 100644 >> --- a/tools/testing/radix-tree/maple.c >> +++ b/tools/testing/radix-tree/maple.c >> @@ -55,6 +55,28 @@ struct rcu_reader_struct { >> struct rcu_test_struct2 *test; >> }; >> >> +static int get_alloc_node_count(struct ma_state *mas) >> +{ >> + int count = 1; >> + struct maple_alloc *node = mas->alloc; >> + >> + if (!node || ((unsigned long)node & 0x1)) >> + return 0; >> + while (node->node_count) { >> + count += node->node_count; >> + node = node->slot[0]; >> + } >> + return count; >> +} >> + >> +static void check_mas_alloc_node_count(struct ma_state *mas) >> +{ >> + mas_node_count_gfp(mas, MAPLE_ALLOC_SLOTS + 1, GFP_KERNEL); >> + mas_node_count_gfp(mas, MAPLE_ALLOC_SLOTS + 3, GFP_KERNEL); >> + MT_BUG_ON(mas->tree, get_alloc_node_count(mas) != mas->alloc->total); >> + mas_destroy(mas); >> +} >> + >> /* >> * check_new_node() - Check the creation of new nodes and error path >> * verification. >> @@ -69,6 +91,8 @@ static noinline void check_new_node(struct maple_tree *mt) >> >> MA_STATE(mas, mt, 0, 0); >> >> + check_mas_alloc_node_count(&mas); >> + >> /* Try allocating 3 nodes */ >> mtree_lock(mt); >> mt_set_non_kernel(0); >> -- >> 2.20.1 >>