From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08BBC433F5 for ; Mon, 17 Jan 2022 03:18:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D747E6B0078; Sun, 16 Jan 2022 22:18:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D24186B007B; Sun, 16 Jan 2022 22:18:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C120B6B007D; Sun, 16 Jan 2022 22:18:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id B339C6B0078 for ; Sun, 16 Jan 2022 22:18:12 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 693A3181CE292 for ; Mon, 17 Jan 2022 03:18:12 +0000 (UTC) X-FDA: 79038320424.31.03B7BA5 Received: from out4436.biz.mail.alibaba.com (out4436.biz.mail.alibaba.com [47.88.44.36]) by imf26.hostedemail.com (Postfix) with ESMTP id 45EE4140002 for ; Mon, 17 Jan 2022 03:18:10 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R741e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=rongwei.wang@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0V1zqFQx_1642389476; Received: from 30.240.98.42(mailfrom:rongwei.wang@linux.alibaba.com fp:SMTPD_---0V1zqFQx_1642389476) by smtp.aliyun-inc.com(127.0.0.1); Mon, 17 Jan 2022 11:17:57 +0800 Message-ID: Date: Mon, 17 Jan 2022 11:17:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:96.0) Gecko/20100101 Thunderbird/96.0 Subject: Re: [PATCH 09/12] mm/readahead: Align file mappings for non-DAX Content-Language: en-US To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: William Kucharski References: <20220116121822.1727633-1-willy@infradead.org> <20220116121822.1727633-10-willy@infradead.org> From: Rongwei Wang In-Reply-To: <20220116121822.1727633-10-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 45EE4140002 X-Stat-Signature: my9zuozdarn591t7rw891b7u3hrwrqr9 Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf26.hostedemail.com: domain of rongwei.wang@linux.alibaba.com designates 47.88.44.36 as permitted sender) smtp.mailfrom=rongwei.wang@linux.alibaba.com X-Rspamd-Server: rspam02 X-HE-Tag: 1642389490-614781 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/16/22 8:18 PM, Matthew Wilcox (Oracle) wrote: > From: William Kucharski > > When we have the opportunity to use PMDs to map a file, we want to follow > the same rules as DAX. > > Signed-off-by: William Kucharski > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/huge_memory.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index f58524394dc1..28c29a0d854b 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -582,13 +582,10 @@ unsigned long thp_get_unmapped_area(struct file *filp, unsigned long addr, > unsigned long ret; > loff_t off = (loff_t)pgoff << PAGE_SHIFT; > > - if (!IS_DAX(filp->f_mapping->host) || !IS_ENABLED(CONFIG_FS_DAX_PMD)) > - goto out; > - > ret = __thp_get_unmapped_area(filp, addr, len, off, flags, PMD_SIZE); > if (ret) > return ret; > -out: > + > return current->mm->get_unmapped_area(filp, addr, len, pgoff, flags); Hi, Matthew It seems this patch will make all file mappings align with PMD_SIZE? And support realize all file THP, not only executable file THP? Actually, what I want to say is we had merged a similar patch to only align DSO mapping in glibc: "718fdd8 elf: Properly align PT_LOAD segments [BZ #28676]" > } > EXPORT_SYMBOL_GPL(thp_get_unmapped_area);