From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54173C3DA64 for ; Thu, 1 Aug 2024 20:16:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E21976B0088; Thu, 1 Aug 2024 16:16:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD1CF6B0089; Thu, 1 Aug 2024 16:16:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C72376B008C; Thu, 1 Aug 2024 16:16:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A8FFA6B0088 for ; Thu, 1 Aug 2024 16:16:39 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2BFB781037 for ; Thu, 1 Aug 2024 20:16:39 +0000 (UTC) X-FDA: 82404784518.18.2718B2A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id C448B1C0032 for ; Thu, 1 Aug 2024 20:16:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="H0/2OWMl"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722543340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mw7ZJF4ofML7CXPXYTsJzk+K9UaMGlsdG7gR16i9K1M=; b=uZD6222KXXC1fOe+4DMWKAZz9MtSaS2Wwyqr4vxgMwNxHU1Zxy3e3CyesD4wWosgWq7c5s 7hB776MoqWlUAGH7u79E4uz7yRfXI/gMF+xpmBlhNDIjlpm3hs28nFOSoxnlOR8yZiZHax Gl21LFYBFoMQrjSdvx+T8RmUgBK57tE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722543340; a=rsa-sha256; cv=none; b=DIw6gikwZq/UvQFuhwmU8swPqBbXa1FW2Uclo+KQCS1SA2pCrXGL6wqndsBJmt4/AjX7ZR Ahx9rwSre/6CZdA3nysEkmF78k6hb+FSjhp1J8WLUKV9cvGIx3ApnLbSadlpSc6FJSnf+B JWMn5ydBqaUd53EwLqpJinJOdi5oFb8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="H0/2OWMl"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722543396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mw7ZJF4ofML7CXPXYTsJzk+K9UaMGlsdG7gR16i9K1M=; b=H0/2OWMlzeF8YhnlZszvIjFI0W1jlk23iDn5k2s/G7VxCp6pdzGrhH9ayikO251gxBw1xA fMOJNwVkc35C0H/DE6g4QL85rQhEdZkzTFtvMeGKZBO8tcu/rQpllN0F7MCyYd2//RQJ9J AGZwaLrWiF1mqnVdfHEhAAPDoBIXO0s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-k0Dz_ebnOvWZewLfhX2ulw-1; Thu, 01 Aug 2024 16:16:34 -0400 X-MC-Unique: k0Dz_ebnOvWZewLfhX2ulw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-428040f49f9so43727265e9.0 for ; Thu, 01 Aug 2024 13:16:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722543393; x=1723148193; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mw7ZJF4ofML7CXPXYTsJzk+K9UaMGlsdG7gR16i9K1M=; b=u6dTr3D/U1DfUR3XZgFhJ2Quv88xwYyxeVj84K3ZqnI3nkcbGYFPMMz7hf3zn2gxnq 909EydF+6xD6PqyN0sOR8t97svIamq+WM54rOrchTnb0DZ4JP4p6nZPuX4BFOwpZnWbH eGe5gILtowf6R2JZKe8GasvobruWBaYnMk3Jbpb+9sK5Dd5Mx5DBbq4AGHfTp3NOoDL+ o7uzEUFwid1SJvTRK6J5SWWuQJWUKqCFaHPQF4eLGfg3Zye4saqSraYXQjuHEGH9/Y06 ThFSnOp9C1ihP4j5QlcBpXMNbnU6FGmKzFtUVppWeyVK311HC3ca8GVZl351mTMOX67N xcDA== X-Forwarded-Encrypted: i=1; AJvYcCVb5+ZQC/IvhZ7H/LCluzfYX/mnXRE6uUFe1bhcZVrysIoYbiIG0URUZ45dDdmh1Y6DeBmYOVaPSpdfFGk5lnmrxl4= X-Gm-Message-State: AOJu0YydopqLQMNNDaOLwgW9rn3R4P/YhWQauS7rej9cmLQ7G34YTKwS ATYiHDH2PEw1WCSKQhhElkgrKO7UBdtfj7TBiLQ6SHYmNxaXGgVCFLMJ/1hugQ6RU7WNjJJs6fn lX+2O7y+A2NjNI5qeRkAwOy74BFoc7EMoPO1PuhjMpYIu48f/ X-Received: by 2002:a05:600c:4f07:b0:427:abed:3602 with SMTP id 5b1f17b1804b1-428e6b7cb5dmr7112255e9.24.1722543393287; Thu, 01 Aug 2024 13:16:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVRWPbBGRurhlFIFGe547MAxTCWwDVt2578BFeLDTTju67T07WZpEGxHxnYRqgBJSPtcD+bw== X-Received: by 2002:a05:600c:4f07:b0:427:abed:3602 with SMTP id 5b1f17b1804b1-428e6b7cb5dmr7112085e9.24.1722543392819; Thu, 01 Aug 2024 13:16:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbcf1daeesm345370f8f.33.2024.08.01.13.16.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 13:16:32 -0700 (PDT) Message-ID: Date: Thu, 1 Aug 2024 22:16:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240725011647.1306045-1-wangkefeng.wang@huawei.com> <20240725011647.1306045-5-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C448B1C0032 X-Stat-Signature: 9bfz7gt5bgxncig5or4ws9cq5x5opsho X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722543396-888657 X-HE-Meta: U2FsdGVkX18HfFaw+Uv3Up0DKFlyEjsb5vCb3nxe5OrOSVTdWwYkIJHOD/owAEyU4z5SJZqogPlV7cqPp+4VQ088s5mfUbkyTqUVzMEEGWratCDCYYbDMDGRxSoiLB+tKAgobTe+pCwsYc0rwNYbUajfkhhZphBRSOL0bSbm+fXFri0NhUx7K6GI9/km0zp8i2bbmlwYftS22aX1BW6fHeyFl3nmj91/p+9DkhF/YeF3qNNJSE2Kj1/1Y8MIn5M30cF+QqOzpG3X+am1tcfFF3c5vPvD96Ys5WOQ1nzNSX36WynJQCBq/6UceSGDjJSlvU6u/yHHNu4LRlVgZ83oUn5KqrYUPOEua8GXFJrUKefpxvRN5U3UvbjPtt2pCZgAzqconHGH2rvqHDStJa0NmGDygdkuo+7SR7qoihqixGjWIeUtzRrBu6XfNPjnYdOze8zOnbqx6Ia1qMd/w+cTwVYfMR9cUuNp/10qJxiRBt9lRnvWRlM/XDjKiRpwduwl/NOQ66fwyAka9V1sRUSwoISpFP/8Vovm0xc472vgThRrtDqGVWD0jWKAiv79Rc70bIDjU/KnpV2F/CB+QeTjF8W6+7tURiZPx71t4Be8aPCWg8IL6qaGfYYgNDSJs4Q6CTFHSOeQfD883f68MFt6OTcQHMvU7ZH+kYEybZks7KbZAOduxojaRDjokRF3q1ONbD4y5pD/kRhlKNdXunzoKx4YyUn8XRBIvSdao4E65yGU27GVxg4HikCAYwjPGbTe476zdboC3OW/K0s8l52ErgDl2/9sdYVxU86v8KtMI5B/CsXwn8zdcPeJpOT9TSYkxQpO5Gcph65STYvTfbwLt3ZtN8enyyMlWi4Tq+Tyxwfe22CBAa8v05FY01axg7L2AtVY9ShcsWD1vS5WD7UIJHxiSPgIklh0867BJ7WzLE8MPHLHXzSG2vQokNDpQIWIJo1Hu8dxSlhR9P/75lm vJULsw15 qOHZTHEPtIE4/50AIZv04gJh42yEPLHW2VIgL0LvanE1kzKk1EeuphjLOoOEmhPPDQVvKO5ujSLL4O7qj8+3KbNjwpEP/51csGKMeThUWhVKSHBypkjbeujjXSbSSllu6JrbBP00qPDYSfbxsJugyCcKvCmmrZDom30lGGrr1l4+OQMLvBDob5TSaEKWZKpEhWAWCYuDBgg4bw7vu9/++eiGbKwSN+23haud/tIHVV/CEaAMObGI8YxhwL13z2gZ4yFBxF2ZCmXajvWJLiLhjtJzAOeuFXzzAWIEl2flwSGzO/33uQ2EaJFi34c72Dwlwud5LbsLUbRPEBBhMlVJw2RnoZFPvOIiYhYAHsjSxahlrTj9JRbx8DazaeuzGokeKKCssxRHa/YnbuiG6YdOT7CiBLZ9N32sxuHreh8LipFP3eklhYShGwEKeEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.07.24 07:13, Kefeng Wang wrote: > > > On 2024/7/30 18:31, David Hildenbrand wrote: >> On 25.07.24 03:16, Kefeng Wang wrote: >>> Move isolate_hugetlb() after grab a reference, and use the >>> isolate_folio_to_list() to unify hugetlb/LRU/non-LRU folio >>> isolation, which cleanup code a bit and save a few calls to >>> compound_head(). >> >> Will this work with free hugetlb folios that have a refcount of 0 and >> get_page_unless_zero() would fail? > > Before this changes, isolate_hugetlb() will fail to isolate a ref=0 > folio(call folio_try_get()) and now get_page_unless_zero() will fail > too, so no behavior change, maybe I miss something? Good point, isolate_hugetlb() will simply do nothing and we skip the folio for this round. Let me take a closer look. -- Cheers, David / dhildenb