From: David Hildenbrand <david@redhat.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Oscar Salvador <osalvador@suse.de>,
Miaohe Lin <linmiaohe@huawei.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 4/4] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation
Date: Thu, 1 Aug 2024 22:16:31 +0200 [thread overview]
Message-ID: <d4a8dc10-4f9a-488a-888f-562086099db2@redhat.com> (raw)
In-Reply-To: <ff608104-f358-450f-a90a-8b3344aaff27@huawei.com>
On 31.07.24 07:13, Kefeng Wang wrote:
>
>
> On 2024/7/30 18:31, David Hildenbrand wrote:
>> On 25.07.24 03:16, Kefeng Wang wrote:
>>> Move isolate_hugetlb() after grab a reference, and use the
>>> isolate_folio_to_list() to unify hugetlb/LRU/non-LRU folio
>>> isolation, which cleanup code a bit and save a few calls to
>>> compound_head().
>>
>> Will this work with free hugetlb folios that have a refcount of 0 and
>> get_page_unless_zero() would fail?
>
> Before this changes, isolate_hugetlb() will fail to isolate a ref=0
> folio(call folio_try_get()) and now get_page_unless_zero() will fail
> too, so no behavior change, maybe I miss something?
Good point, isolate_hugetlb() will simply do nothing and we skip the
folio for this round. Let me take a closer look.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-08-01 20:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 1:16 [PATCH 0/4] mm: memory_hotplug: improve do_migrate_range() Kefeng Wang
2024-07-25 1:16 ` [PATCH 1/4] mm: memory-failure: add unmap_posioned_folio() Kefeng Wang
2024-07-30 10:20 ` David Hildenbrand
2024-07-31 4:46 ` Kefeng Wang
2024-07-25 1:16 ` [PATCH 2/4] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() Kefeng Wang
2024-07-30 10:26 ` David Hildenbrand
2024-07-31 5:09 ` Kefeng Wang
2024-08-01 20:10 ` David Hildenbrand
2024-08-02 7:50 ` Kefeng Wang
2024-08-06 9:29 ` David Hildenbrand
[not found] ` <1e6cccc5-fedc-8df6-1deb-16ceb52a4094@huawei.com>
[not found] ` <1e14d86d-0d17-41da-9400-16c9c6f93f8f@redhat.com>
2024-08-09 2:02 ` Miaohe Lin
2024-08-01 20:14 ` David Hildenbrand
2024-08-02 8:02 ` Kefeng Wang
2024-08-06 3:44 ` Kefeng Wang
2024-08-06 9:24 ` David Hildenbrand
2024-08-06 9:15 ` David Hildenbrand
2024-07-25 1:16 ` [PATCH 3/4] mm: migrate: add isolate_folio_to_list() Kefeng Wang
2024-07-26 14:21 ` kernel test robot
2024-07-27 7:56 ` Kefeng Wang
2024-07-30 10:30 ` David Hildenbrand
2024-07-25 1:16 ` [PATCH 4/4] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation Kefeng Wang
2024-07-30 10:31 ` David Hildenbrand
2024-07-31 5:13 ` Kefeng Wang
2024-08-01 20:16 ` David Hildenbrand [this message]
2024-08-01 20:23 ` David Hildenbrand
2024-08-02 8:39 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4a8dc10-4f9a-488a-888f-562086099db2@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-mm@kvack.org \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox