From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF9AEC4332F for ; Wed, 23 Nov 2022 01:31:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53CAF6B0071; Tue, 22 Nov 2022 20:31:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C5C66B0073; Tue, 22 Nov 2022 20:31:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 365D46B0074; Tue, 22 Nov 2022 20:31:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 23D256B0071 for ; Tue, 22 Nov 2022 20:31:01 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E9779120219 for ; Wed, 23 Nov 2022 01:31:00 +0000 (UTC) X-FDA: 80162978280.12.5B9F301 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf11.hostedemail.com (Postfix) with ESMTP id 76A6E4000F for ; Wed, 23 Nov 2022 01:30:59 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id 140so15999968pfz.6 for ; Tue, 22 Nov 2022 17:30:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=DKO5lR4cLz6p7NWkfnd0y6rPCWBH2+knxhaYnv/yN7g=; b=NXD0++W1grzconoV0x+G2IAlIiJtVCOGTMBnUhvmAstsMhj6jtOs7BcAJGgKzdSGxJ 6WRKCQPUQQdVSYMLLzc9pngh3MZKR8YrFD8d/E9qcP1+rhgI4WqDBdm04K8qAIi5/dCs l/OF72+iUkIrkggctoMI3+D8SQLzptPdnkw+nsDBb4TjXNCOUZkK4+AEHFZDAycjlOeW mSZqXSpomAhvM2koEPenAJbEQl7m64YkqH7+NoPou3o3g13CGO3qQd3jpsYENN9pD+95 KZWGcbJIpU5W+68tUnqzWFjs0R7CLIucsBRjr7AHpne6oOJ+/xKUwsr2KtjsxZjhRTVc Zt7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DKO5lR4cLz6p7NWkfnd0y6rPCWBH2+knxhaYnv/yN7g=; b=0dwLhP4ls79WYlUywlaSs5qki0lzGn8xABf1xeUBszToJEdtAj2E7SJBBDhbATSWPN 10QDz+mpMxctx8Trce362+KsDbewvNp2t0V4Q1nB31MGYkiee6PCdSdpg4QYNJkaxxGy tMZfWdMkNzWyo+yzYWP2pE35fzLHY+gaF/J7A+gtFTHNwqLYhg3Xvnmok+xdXthBv04B bwNVShFbsWD2wIiBHyu1P70jctZL79PQATVAjXoyKkq838LI7h7FR/BJ6LC2oiv1ottb bX/shcL6vjRJFJqp0vOsAfyVLk5pHNTqcKqtnhnJJ2L4z9OoiorRsz6N1EiVUnGBGCbK EDaA== X-Gm-Message-State: ANoB5pmCKXQnxDqgrr2QWl883ogewlxyYaxrbMi9MqmrW/+ywaC8RjG5 q/APJG36o4kCgc0dZtrWPehpSQ== X-Google-Smtp-Source: AA0mqf7QekbcagrdW2ZDZzvV7seCNJVnDeErvb+ZQk78iSZep5oGbGV2XKOj4eOZEI3kIJGB0bxSpg== X-Received: by 2002:a05:6a00:1a14:b0:572:5be2:505b with SMTP id g20-20020a056a001a1400b005725be2505bmr6959442pfv.52.1669167058288; Tue, 22 Nov 2022 17:30:58 -0800 (PST) Received: from [2620:15c:29:203:2520:fc16:115d:2f43] ([2620:15c:29:203:2520:fc16:115d:2f43]) by smtp.gmail.com with ESMTPSA id r8-20020a170902be0800b00176e6f553efsm12647970pls.84.2022.11.22.17.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 17:30:57 -0800 (PST) Date: Tue, 22 Nov 2022 17:30:57 -0800 (PST) From: David Rientjes To: Kees Cook cc: Andrey Konovalov , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , linux-mm@kvack.org, kasan-dev@googlegroups.com, Vlastimil Babka , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2] mm: Make ksize() a reporting-only function In-Reply-To: <20221118035656.gonna.698-kees@kernel.org> Message-ID: References: <20221118035656.gonna.698-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669167059; a=rsa-sha256; cv=none; b=Y9fwxCQZf3bs0+vAaL18ep90QhnMPEs0OQ1+Mquh90avublh4yX0w/p4VkOuG7/P93xjry M1cbIurawXGw2lFwevLH8HUg2oysDmDyIgdU6LctnH8yXdb1A7YIApgZuyM139pBaj9mcp +dP7qz3b8yCh6XIJsk8iB91MxQ41nCQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NXD0++W1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of rientjes@google.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669167059; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DKO5lR4cLz6p7NWkfnd0y6rPCWBH2+knxhaYnv/yN7g=; b=oZkwkTxve/tNwwNIeLf6NCUqTvE9TjwouQVtYfl/+sLB39Ks8f92eLoHme0H+5Z5sWReUn N+ey27dw0IE2+EF43ay9BjoWUTi8DD7XFDJP17r7DVR5GZoXEvHW4gJRBzTWMXW2rF0yZu fhCG/W71P5Qq2wQpAPKTmtpxjUHNbSo= X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 76A6E4000F X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NXD0++W1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of rientjes@google.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=rientjes@google.com X-Stat-Signature: k9waj435bfg7obxoj9rrdq864ueqqbzh X-HE-Tag: 1669167059-726919 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 17 Nov 2022, Kees Cook wrote: > With all "silently resizing" callers of ksize() refactored, remove the > logic in ksize() that would allow it to be used to effectively change > the size of an allocation (bypassing __alloc_size hints, etc). Users > wanting this feature need to either use kmalloc_size_roundup() before an > allocation, or use krealloc() directly. > > For kfree_sensitive(), move the unpoisoning logic inline. Replace the > some of the partially open-coded ksize() in __do_krealloc with ksize() > now that it doesn't perform unpoisoning. > > Adjust the KUnit tests to match the new ksize() behavior. > > Cc: Andrey Konovalov > Cc: Christoph Lameter > Cc: Pekka Enberg > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Andrew Morton > Cc: Roman Gushchin > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Dmitry Vyukov > Cc: Vincenzo Frascino > Cc: linux-mm@kvack.org > Cc: kasan-dev@googlegroups.com > Acked-by: Vlastimil Babka > Signed-off-by: Kees Cook Acked-by: David Rientjes