From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF891C54E94 for ; Wed, 25 Jan 2023 18:49:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52A536B0071; Wed, 25 Jan 2023 13:49:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DA236B0073; Wed, 25 Jan 2023 13:49:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3549E6B0074; Wed, 25 Jan 2023 13:49:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 26B116B0071 for ; Wed, 25 Jan 2023 13:49:07 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CA1C0A0C76 for ; Wed, 25 Jan 2023 18:49:06 +0000 (UTC) X-FDA: 80394208692.30.051842C Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by imf03.hostedemail.com (Postfix) with ESMTP id BEE632000D for ; Wed, 25 Jan 2023 18:49:02 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YEmuKQaJ; spf=pass (imf03.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.236.40 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674672543; a=rsa-sha256; cv=pass; b=v6a0MKA7qy3yx7JD6B5DZjUQCjjzpvTYrHloaXEofhiaWIO7kNgcrzTRxtNlaQO/YDBbC3 0ifNhYlzT+j2Zak2VxprS+zuXIbMW5k6rJdm+8ITu/DRS8KaRDbd6byE56U4IblU5REtao bNCXwdqIFcF2n/bxbugzWVu8LViPc/w= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YEmuKQaJ; spf=pass (imf03.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.236.40 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674672543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9aaPxcUSZK4uMvb80W+6KN57lv8Q83YcWziBOs+QFAo=; b=N9j6DCqgdHvBV+Ow78c8GImoloEtubkS3kgXiBe//17pbDkQu/ayX3oxr6wJ7MLY0wHPQA rcg/oYMAbMM2k7S3C4N7+zpGdaKqn5AML5gbRtbK6mn3kifMqrKdQR+0JUkqVW6tIillkv KK0ukGPNDeeeri2//wLXt5MqoyHLBlg= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aInc7viWMhN+wE134DyvNZ1JYcTpahzv4Y1W4sxFlGjtjuj5zwPlzf375zTOjt1NSYYg9icOZP2sx8VAAmmD2/P6CKLmJJMDxiI1x04bQ9n0KZEHdAYF5ZSLWziEA9IaxjBChlXeWnLB+9tYSi+rnoYduSubqlJIYkAT3+oIREC7gTkhNH0vP5Rtm1joW64PZOxLex3XrtvV+OqCX0N82p+SmiYfImTypUevhx6hdu9MaXWBocVifmcur5cQx6NCnDQnooBs+IWT9Qpv+/ShUREI1WCEY1bxeS45HBd/hbGk9PRhrqPgfGaQY7etbdP0+FBpi0I75lNCIYTM3Z3THg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9aaPxcUSZK4uMvb80W+6KN57lv8Q83YcWziBOs+QFAo=; b=kBmEPvv8188h1r6M8gW59G86dh2Xe/62ElHR3EfQVzPdzizUYphpkQivYq9+Sb2jz+VXLEMijjGHdZCidtx/UxmmbrIQDokkAXg/kfwk7Tzew/xMOUvyb9e6ymOaCNoCu53grgI4C01p2RnDY9gOLH42ne2X4oPPBiiFeX2ShW6K6KR2SazVVTXowqOUEgWO33ULjlWPK9qwXWz2nBkbHaowmUVJZvMs7SQCDw+Y/+kkESQIPUgeKns3gxEFq6xmE6o8f3ETT/hNRVQx5/QijT8fkYXlNUA/JDj01lo6OpxdBWdRKw9rWi8zes82EmRblOzt10qa8Szoch+tOaCvig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9aaPxcUSZK4uMvb80W+6KN57lv8Q83YcWziBOs+QFAo=; b=YEmuKQaJoUcZE30g3NJLRS7Z9g6ZdcpWcQDvFlozRQBLG/08pFAgOU4wvTpSYrgGYuFi0oVBEuCoAPq+8yKwaF1exTG4NyzF0/8SdFpI1VnvH9aRhRTH98tvP44VGOGCfjWQ53mmucjsx0J1ur3Nc9u86sWpJIvl9TgFEyoPdAYa53G9vO4NbbiJwTi6/lOrNsEwwh8RoJ7DShBfS6CPcDskH7PpJqTQVCNKka63VHDZprTuGIoNdvkgNxS9Sqvg2xVOrykV6Y5117KNm5zrVaoI4GHALjZppyvGQA3zsLz5YOgj9sWMM5FEw/xyFLgcR06O4Z4goMxEI4UICo461A== Received: from DM6PR08CA0032.namprd08.prod.outlook.com (2603:10b6:5:80::45) by MN0PR12MB6319.namprd12.prod.outlook.com (2603:10b6:208:3c0::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21; Wed, 25 Jan 2023 18:48:59 +0000 Received: from DM6NAM11FT090.eop-nam11.prod.protection.outlook.com (2603:10b6:5:80:cafe::25) by DM6PR08CA0032.outlook.office365.com (2603:10b6:5:80::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33 via Frontend Transport; Wed, 25 Jan 2023 18:48:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT090.mail.protection.outlook.com (10.13.172.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.16 via Frontend Transport; Wed, 25 Jan 2023 18:48:59 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 25 Jan 2023 10:48:37 -0800 Received: from [10.110.48.28] (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 25 Jan 2023 10:48:36 -0800 Message-ID: Date: Wed, 25 Jan 2023 10:48:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 01/13] mm/gup: have internal functions get the mmap_read_lock() Content-Language: en-US To: Jason Gunthorpe CC: Alistair Popple , David Hildenbrand , David Howells , Christoph Hellwig , , "Mike Rapoport (IBM)" References: <1-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> <53ac3700-6532-a609-ceff-d0840469e532@nvidia.com> From: John Hubbard In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT090:EE_|MN0PR12MB6319:EE_ X-MS-Office365-Filtering-Correlation-Id: e3d4939d-7f3e-4f7f-611e-08daff04d1e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L3u7RAQQ6zgvVPsnpWAj8iBpbXgYx6lwaLh7QSLtOEFoiI7PTvkpuTzLb6G/c4VfhwjmXUGqulD2yy721TtyYXR7qhXAAifqvUOiWrnJY4xyuePS5NY0LmxHeEtyuPhVWSAcA1KvgG2X2/QI8okbIeA1s73+C7iFj59vJTtF78DACLlz6tbv3vEoPNPYZAwjH1tNKx2ddfa1IjGNeF1JZHa5jvkAVl+7JDZIYVk9RPGLN7nQtdvnErPNhouQ+QmpFn7xITw5xqq6MixCYAYYMoK050HdQcHtCwygE14Y02X2tBQzVEoYGuDBl6LTGnBDRTOWE22Kqx3IQT1NXNFRl186xnty3dR9qb/YaTJuoHS7dqNRNtLmkFD6j+rID3tvLZ+S0Iu847N7EAd9J5qkBElu1IuZ6koXBoBmSNMvIb6IzyvVNWCRKkG0N+/AMGtIQQZJBUklLzwI4wGNwWXosGN62cP5Iw4BQ2967+CBf+LroMA+mMgr3xHCIafiE7AC03MxB7CamWlsULHyzIUw5GTSlncpWRVrM69a1D+vmMWx2QjC6yoJOc8O0iQNNBpT6oCPwczgru0cx4mreNDCUL5zMLp8dtoPc414QlvhjOTOFNzLUBA/z0cSA7aEP9hcpT2XlZgvWHO585RwS4KHkguaEgPDdJFLx0G7ce4nBQPv67lDHH/ANFAAJSrRQmXFAVKEveN/AkPMet8Yt0c9wMlGKKuafrkGjlG/pBKy3bHDJtPYCQ526rthAt0MSCPJ X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199018)(46966006)(40470700004)(36840700001)(83380400001)(47076005)(426003)(336012)(36860700001)(82310400005)(40480700001)(356005)(6636002)(54906003)(316002)(16576012)(37006003)(4744005)(2616005)(2906002)(7636003)(478600001)(36756003)(31686004)(8676002)(4326008)(70586007)(70206006)(6862004)(86362001)(41300700001)(40460700003)(8936002)(5660300002)(31696002)(16526019)(26005)(186003)(53546011)(82740400003)(15583001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 18:48:59.1232 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e3d4939d-7f3e-4f7f-611e-08daff04d1e3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT090.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6319 X-Rspam-User: X-Rspamd-Queue-Id: BEE632000D X-Rspamd-Server: rspam01 X-Stat-Signature: ewx5tdqizip6obi744xj34aq4j8taeee X-HE-Tag: 1674672542-612232 X-HE-Meta: U2FsdGVkX18Q8DwQoa9OJoZnj+V6blUxcNMQz07iWoMha5AQ4OjfM9HwZKOdrsiXQCQpctNHutj95Ias0gMUogWkyYcDd8YO1mN7LxSEXOl1hrK/IYuZY2+HHThVWeSCmPx9e1df1AFy0o9Lu2+C0Hzf3F36NxO2+/nhjKwe3BXBv2xGuBiCMdlVOuMqR0dVRmFHIft4NHydpFSTiVfx4d4GeZ5MDTMi538u+t4rxs+/gMzTks7xfR3JoRooTVSqe5uGd0q/IQ5fb6f5J+0v7zbMZpFcGCbcMLhzkJKxCbTgZ7HMxljkiaKrgCosrmAhrPn8f8ZaG8PChBfRl9i0MQjA7q6oo6TxWEwnSpccoVjnf7KbCz303qAQ5RFxeS17Yc+xGLr+qC+NcfFUt/izZwDGaUNrcxzC3dlkS02tdf2r1i9rkf7SABPEGAz20bUCBKxt2TjA02+1RjKpuQJmV9q4ZwhEYJoFctkzZZhoaYJGdPd9Ndp1L0a7xn0DcqdMZTBm7Z0NsGTqwFdRKQ81ruhTrmxJQEpS950x9PO/5+DEYznN8pSkxH1UZgCLkDBWl3NYG9K/PRvMDKwiBf96SnTFG4FF2DKWVfsgqvFtl9V3z5jlOFqsrxKL5eX17M8G3VVjF8kqNXHL9mvedPFdGBZINusshLOhjHJ20LZ1w5W/H1uggC7C2JMFszlm6HZegT5QhDlr0hRMIlQfh3EhIILsrR3Ior5xE9/OOK6gsvsTInBbKFoTK4cV6oUm/MieWwssTmpOOw/2vd5CjHI2HKUBI8Ye55sQFGm9BIoOF+WRCfZ5Ao25ZsoohwYPiC9QpBoHvky5Dgk/KizH/AeydgQu3Ls221U2qlcKAVcOP9KwSVvc1jGY2trUrPAuQwIrd0h2Yt4vzx0Pz6Lah0vZX1k6opqfuza54SVvruOa0L/szzbghTgwz9b+GPKG0MHrlN9MNN506bJTzYrNacb denS5r5s c+CUTCSoxswPnjtBZKFNhzT0hN6DQdN4qyL30TbmACYei5Dd4ta1vFVAH0S7LR21t8VHMIFQp5F8tGLjLHOihE/P8lcv/MLGfU3YnGs1qQyYBy2CwNOQbF1R5m64HdHkOhb9+i2Ac1R5ZFsOCkVfHD/WGtpFNfeVF7wCrXMZULNHLFfml4u6TEztv4jRt5OCmhLU3gWTnMQ/VAcN0V+TZU7K9PXCrUawcRFJZvejpJf0GaYHlx+5W64RpoNbNidwNED6ivJOGoprRqaX87m0arwC2zAeBTY4pwh2GzpRMnyPqrR5lQAgWaFB7bGB8li9tti3bQOwIf1jfhXCXVfv4J/uIRM5DZBbSrdtjl12YKRDCA2o8R/1wkBIvFZ3mjP1+afTTI5poDd82c9g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/25/23 08:38, Jason Gunthorpe wrote: ... >> I missed this on my review of v1 of this series: the FOLL_TOUCH change >> looks like a mistake, yes? It should just be left as-is: >> >> gup_flags |= FOLL_PIN; >> > > No, not a mistake. > > The transformation is this: > > - return get_user_pages_unlocked(start, nr_pages, pages, gup_flags); > + gup_flags |= FOLL_PIN | FOLL_TOUCH; > + return __gup_longterm_locked(current->mm, start, nr_pages, pages, NULL, > + &locked, gup_flags); > > Ie we switch get_user_pages_unlocked() for __gup_longterm_locked() > > Howevr get_user_pages_unlocked() was adding the FOLL_TOUCH before > calling __gup_longterm_locked(): > > - ret = __gup_longterm_locked(mm, start, nr_pages, pages, NULL, &locked, > - gup_flags | FOLL_TOUCH); > > Thus we have to lift the FOLL_TOUCH when we do the function call > replacement. > OK good. Sorry about the moment of panic, haha. :) Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA