From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F93C4345F for ; Thu, 25 Apr 2024 11:05:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C05A6B0083; Thu, 25 Apr 2024 07:05:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96FBF6B0092; Thu, 25 Apr 2024 07:05:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 838DB6B0093; Thu, 25 Apr 2024 07:05:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 63EC66B0083 for ; Thu, 25 Apr 2024 07:05:45 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 27EFB811DF for ; Thu, 25 Apr 2024 11:05:45 +0000 (UTC) X-FDA: 82047773850.04.BD00A6E Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf27.hostedemail.com (Postfix) with ESMTP id A570A4000A for ; Thu, 25 Apr 2024 11:05:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714043143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pHzoxfF391FtcVu44gA0W8XikiJ/KNK5eBYYx7Pyv5A=; b=0+0har+pYEmZzydisFgyG3vVZ3lWR1VTHAEW2RGtosgcAcQJ095CNLcbpmxEdGn1ygsbKa Ay+HIc+244f0v9Ju+7tqzDI3BZ2ksESLNo9R55jGqAsV4GXndQ4ncv7amZ3g9nzjr2Zr5K fm9xGbjkbg061XXNOgqiz3Y5TBpZYtc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714043143; a=rsa-sha256; cv=none; b=0AX1a+ka0oBspYWAoDT09LL50JYnB6dUkk4Biqc+7fSNkANONGWxa+i4QRPIdNQnwB9odP XtVt8h3+u4mlryiczZElnfBtl8LPAdiv4YUzyy35SDfjVQyKkcoZB+FbPmnWYx2KYcwYwJ hAWneMbdZLjC+hBAJpGxKBXIKVsXOPY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4VQCd52HWfzNtRH; Thu, 25 Apr 2024 19:03:05 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id D25E5180A9C; Thu, 25 Apr 2024 19:05:37 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 25 Apr 2024 19:05:37 +0800 Message-ID: Date: Thu, 25 Apr 2024 19:05:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/10] mm: migrate_device: use more folio in migrate_device_unmap() Content-Language: en-US To: David Hildenbrand , Andrew Morton CC: , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Zi Yan , Hugh Dickins , Jonathan Corbet , , Vishal Moola References: <20240425084028.3888403-1-wangkefeng.wang@huawei.com> <20240425084028.3888403-10-wangkefeng.wang@huawei.com> <5a05d9be-6b7f-4b1f-88cd-cad17caf63ed@redhat.com> From: Kefeng Wang In-Reply-To: <5a05d9be-6b7f-4b1f-88cd-cad17caf63ed@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A570A4000A X-Rspam-User: X-Stat-Signature: k3ug91onqpmqhq848amkhbnqww8mjye3 X-HE-Tag: 1714043142-779651 X-HE-Meta: U2FsdGVkX19awgAgQmmFKSfrqCxXFqgrT/SLa1ZY1jqZikRJH2TIVdeVGVufQI7JM1dh0k+RatfsbJFx2NVcHxv5C7pVnRAQDPKpPPKyuyT3wTifGjVVShnSsbKkWtUR1so7j/IHb43PIrS4dw5FYtbfKrDHspp5bcWrzS+MA+pKA9X8EEow+3a69pWRrlidoPwSbp//ExBsFV/JfvkRjRbEbIcO3NPz5+ZFdxi/byAOqE973iPfA4NrSeulDC+VTrj/xa8eAv4na+pFLVU6AxnigH7ZU7p/bEPfDTTjjU9qxfc/7Nv5yUKDltlFzki4TSpp1vMQt5c+fqjCcQShaJxEcj8G6vXU8oRevnaAoT01WU8+d6ZpYG/rlxDQAFXSc0TyNg9rVXBGgvJmC1qlot0v8nQ40F9PNO+W3+TSG/hxqzj9YTSdVdvohror5dHNl6ZJztsYGoDpVQpndFfcEtEUQ7L7hLoShBmb+eL1ZmYkb3C8wh2eBC5FqWPGV3bu+l4P3ICqwYkqfgv0CHDCTj6fwAlldZ0vGK8DeYpmamxRa7VJBlkGiaWzzro2KqdeLlvNoyMrNZqJ0KWh2g+Iyg//55A8cA45xT3H82R9lCrwhPwQKgt4g0C+KBvUBfj3luxGIVXn8nqWWp3uOqmjFF8Sh0Z2EJD7sdJWp53aSuxuNfs5l878zSbT8a1bKUQT/q/Gyiv29QHh0s1foBTP+avUVqKKoGRLl3VfMPxS1IR4iv/9B2e0/f1M81Q+YpnbDysBqbvq1As12D8YGWw1vZOXT5FFbkDfu03jDTuyv34NTrlIEsFJVEtI1mrl+4qBd+3XWyM6eXpDkMVlrSz0PXPoH98jHgOAv0lj3/OrOgmRmJnUyzPHQHWw8dWNcV1Mrh0lXV/6usCDGOVAJj1ElfhbMECr1Y3VJbZAIBAyR+3p4e/XT5MFjmw+b4tDIT6hTBPga8xyRlLzGizJQDf zQIL17L+ /Ooz9cEVQ8P95vuqt6aT6R9vDEV9ViDXr0NxfUsXzJsubaQJKgnQkShHE4FrE7PuMTfBn6uto8YpFosNxlQPLGU4CnkoPlc2ISMPXxRULRsMuYLOAlEmjznvQ9bTOMAg2E4DiMq+CDnZdAWfUiCmI8zCJrXaE1Nu7bkK+YGZ1g0NtTyAdI08tUdszniw0HPoW/TkeGMgOflUzti5s17XfGwsJwUtI9WEkzbvV8vmvlksb0+ll7T93jhuw8K8zs8BtEJUaEzhh1MH9aCeCoMNkYYIOwzu2NsoJkt3uk4BM1rc+8NjVnAcptDQl2/DNpX9oAgGif32bo4AIXyHT5fsjLnbjag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/25 17:31, David Hildenbrand wrote: > On 25.04.24 10:40, Kefeng Wang wrote: >> The page for migrate_device_unmap() already has a reference, so it is >> safe to convert the page to folio to save a few calls to compound_head(), >> which removes the last isolate_lru_page() call. >> >> Signed-off-by: Kefeng Wang >> --- >>   mm/migrate_device.c | 16 ++++++++-------- >>   1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/mm/migrate_device.c b/mm/migrate_device.c >> index a68616c1965f..423d71ad736a 100644 >> --- a/mm/migrate_device.c >> +++ b/mm/migrate_device.c >> @@ -379,33 +379,33 @@ static unsigned long >> migrate_device_unmap(unsigned long *src_pfns, >>               continue; >>           } >> +        folio = page_folio(page); >>           /* ZONE_DEVICE pages are not on LRU */ >> -        if (!is_zone_device_page(page)) { >> -            if (!PageLRU(page) && allow_drain) { >> +        if (!folio_is_zone_device(folio)) { >> +            if (!folio_test_lru(folio) && allow_drain) { >>                   /* Drain CPU's lru cache */ >>                   lru_add_drain_all(); >>                   allow_drain = false; >>               } >> -            if (!isolate_lru_page(page)) { >> +            if (!folio_isolate_lru(folio)) { >>                   src_pfns[i] &= ~MIGRATE_PFN_MIGRATE; >>                   restore++; >>                   continue; >>               } >>               /* Drop the reference we took in collect */ >> -            put_page(page); >> +            folio_put(folio); >>           } >> -        folio = page_folio(page); >>           if (folio_mapped(folio)) >>               try_to_migrate(folio, 0); >>           if (page_mapped(page) || > > folio_mapped(), just as above ah, don't know why missing this one, will fix, thanks. >