From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 212FEC433EF for ; Wed, 5 Jan 2022 16:39:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 573316B0071; Wed, 5 Jan 2022 11:39:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FB476B0073; Wed, 5 Jan 2022 11:39:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 374C66B0074; Wed, 5 Jan 2022 11:39:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 252956B0071 for ; Wed, 5 Jan 2022 11:39:21 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D46E495C8A for ; Wed, 5 Jan 2022 16:39:20 +0000 (UTC) X-FDA: 78996793680.14.8749292 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf27.hostedemail.com (Postfix) with ESMTP id 004BF4001B for ; Wed, 5 Jan 2022 16:39:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9B75F1F37F; Wed, 5 Jan 2022 16:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1641400750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=671oRtpp5WCs8Fk9Hz2g9PU50UrRMSTbK7reBDGjtCs=; b=NRsZKCZitYMeU3RMI4mLOr+6li06jujBRhQsffYRQUkFW9PzULWtrL9sf+TAZSnQfN/PFW vM6/MTfW8m/iSdJQlSZGTuf8ommuOTf4zyXfj2xodWa580XJFAlrfobKzZGZpOqhkgcw7b w7Rkd3lRVPo05v08Q4Ze6NDY68SHnmQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1641400750; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=671oRtpp5WCs8Fk9Hz2g9PU50UrRMSTbK7reBDGjtCs=; b=A7c4TZBO+fD7rEud8NwULvyOqkWaT+XnEGjIj6AYNSs4vZ4Apwth/CZG0akr5xMhlAzuDJ JMYPGpTT1ZH7AUAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5418C13BF8; Wed, 5 Jan 2022 16:39:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7jnnE67J1WGcEAAAMHmgww (envelope-from ); Wed, 05 Jan 2022 16:39:10 +0000 Message-ID: Date: Wed, 5 Jan 2022 17:39:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v4 22/32] mm: Convert struct page to struct slab in functions used by other subsystems Content-Language: en-US To: Roman Gushchin Cc: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , linux-mm@kvack.org, Andrew Morton , Johannes Weiner , Hyeonggon Yoo <42.hyeyoo@gmail.com>, patches@lists.linux.dev, Andrey Konovalov , Julia Lawall , Luis Chamberlain , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Michal Hocko , Vladimir Davydov , kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20220104001046.12263-1-vbabka@suse.cz> <20220104001046.12263-23-vbabka@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 004BF4001B X-Stat-Signature: u39btqjj1jhetiuo4juhqixm33hjd1o8 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=NRsZKCZi; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=A7c4TZBO; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-HE-Tag: 1641400750-751135 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/5/22 03:12, Roman Gushchin wrote: > On Tue, Jan 04, 2022 at 01:10:36AM +0100, Vlastimil Babka wrote: >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -249,7 +249,7 @@ static void print_address_description(void *addr, u8 tag) >> >> if (page && PageSlab(page)) { >> struct kmem_cache *cache = page->slab_cache; >> - void *object = nearest_obj(cache, page, addr); >> + void *object = nearest_obj(cache, page_slab(page), addr); > s/tab/space Yeah it was pointed out earlier that the tab was already there but only this change made it stand out. Fixing that up here would go against the automated spatch conversion, so it's done in later manual patch that also touches this line. >> 2.34.1 >> > > Reviewed-by: Roman Gushchin > > Thanks! Thanks!