From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Andrew Morton <akpm@linux-foundation.org>,
Jason Gunthorpe <jgg@nvidia.com>, Peter Xu <peterx@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org
Subject: [RFC PATCH v4 11/16] powerpc/e500: Switch to 64 bits PGD on 85xx (32 bits)
Date: Mon, 27 May 2024 15:30:09 +0200 [thread overview]
Message-ID: <d4994e1e6766975ed1f739838619a39b21a898d8.1716815901.git.christophe.leroy@csgroup.eu> (raw)
In-Reply-To: <cover.1716815901.git.christophe.leroy@csgroup.eu>
At the time being when CONFIG_PTE_64BIT is selected, PTE entries are
64 bits but PGD entries are still 32 bits.
In order to allow leaf PMD entries, switch the PGD to 64 bits entries.
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
arch/powerpc/include/asm/pgtable-types.h | 4 ++++
arch/powerpc/kernel/head_85xx.S | 10 ++++++----
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/pgtable-types.h b/arch/powerpc/include/asm/pgtable-types.h
index 082c85cc09b1..db965d98e0ae 100644
--- a/arch/powerpc/include/asm/pgtable-types.h
+++ b/arch/powerpc/include/asm/pgtable-types.h
@@ -49,7 +49,11 @@ static inline unsigned long pud_val(pud_t x)
#endif /* CONFIG_PPC64 */
/* PGD level */
+#if defined(CONFIG_PPC_E500) && defined(CONFIG_PTE_64BIT)
+typedef struct { unsigned long long pgd; } pgd_t;
+#else
typedef struct { unsigned long pgd; } pgd_t;
+#endif
#define __pgd(x) ((pgd_t) { (x) })
static inline unsigned long pgd_val(pgd_t x)
{
diff --git a/arch/powerpc/kernel/head_85xx.S b/arch/powerpc/kernel/head_85xx.S
index 39724ff5ae1f..a305244afc9f 100644
--- a/arch/powerpc/kernel/head_85xx.S
+++ b/arch/powerpc/kernel/head_85xx.S
@@ -307,8 +307,9 @@ set_ivor:
#ifdef CONFIG_PTE_64BIT
#ifdef CONFIG_HUGETLB_PAGE
#define FIND_PTE \
- rlwinm r12, r10, 13, 19, 29; /* Compute pgdir/pmd offset */ \
- lwzx r11, r12, r11; /* Get pgd/pmd entry */ \
+ rlwinm r12, r10, 14, 18, 28; /* Compute pgdir/pmd offset */ \
+ add r12, r11, r12; \
+ lwz r11, 4(r12); /* Get pgd/pmd entry */ \
rlwinm. r12, r11, 0, 0, 20; /* Extract pt base address */ \
blt 1000f; /* Normal non-huge page */ \
beq 2f; /* Bail if no table */ \
@@ -321,8 +322,9 @@ set_ivor:
1001: lwz r11, 4(r12); /* Get pte entry */
#else
#define FIND_PTE \
- rlwinm r12, r10, 13, 19, 29; /* Compute pgdir/pmd offset */ \
- lwzx r11, r12, r11; /* Get pgd/pmd entry */ \
+ rlwinm r12, r10, 14, 18, 28; /* Compute pgdir/pmd offset */ \
+ add r12, r11, r12; \
+ lwz r11, 4(r12); /* Get pgd/pmd entry */ \
rlwinm. r12, r11, 0, 0, 20; /* Extract pt base address */ \
beq 2f; /* Bail if no table */ \
rlwimi r12, r10, 23, 20, 28; /* Compute pte address */ \
--
2.44.0
next prev parent reply other threads:[~2024-05-27 13:31 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 13:29 [RFC PATCH v4 00/16] Reimplement huge pages without hugepd on powerpc (8xx, e500, book3s/64) Christophe Leroy
2024-05-27 13:29 ` [RFC PATCH v4 01/16] powerpc/64e: Remove unused IBM HTW code [SQUASHED] Christophe Leroy
2024-05-27 13:30 ` [RFC PATCH v4 02/16] mm: Define __pte_leaf_size() to also take a PMD entry Christophe Leroy
2024-05-27 13:30 ` [RFC PATCH v4 03/16] mm: Provide mm_struct and address to huge_ptep_get() Christophe Leroy
2024-05-28 4:12 ` Oscar Salvador
2024-05-28 5:41 ` Oscar Salvador
2024-05-28 11:02 ` Christophe Leroy
2024-05-27 13:30 ` [RFC PATCH v4 04/16] powerpc/mm: Remove _PAGE_PSIZE Christophe Leroy
2024-05-27 13:30 ` [RFC PATCH v4 05/16] powerpc/mm: Fix __find_linux_pte() on 32 bits with PMD leaf entries Christophe Leroy
2024-05-27 13:30 ` [RFC PATCH v4 06/16] powerpc/mm: Allow hugepages without hugepd Christophe Leroy
2024-05-27 13:30 ` [RFC PATCH v4 07/16] powerpc/8xx: Fix size given to set_huge_pte_at() Christophe Leroy
2024-05-27 13:30 ` [RFC PATCH v4 08/16] powerpc/8xx: Rework support for 8M pages using contiguous PTE entries Christophe Leroy
2024-05-29 8:02 ` Oscar Salvador
2024-05-29 9:39 ` Christophe Leroy
2024-05-27 13:30 ` [RFC PATCH v4 09/16] powerpc/8xx: Simplify struct mmu_psize_def Christophe Leroy
2024-05-27 13:30 ` [RFC PATCH v4 10/16] powerpc/e500: Remove enc and ind fields from " Christophe Leroy
2024-05-27 13:30 ` Christophe Leroy [this message]
2024-05-27 13:30 ` [RFC PATCH v4 12/16] powerpc/e500: Encode hugepage size in PTE bits Christophe Leroy
2024-05-29 8:05 ` Oscar Salvador
2024-05-29 9:49 ` Christophe Leroy
2024-05-29 10:09 ` Oscar Salvador
2024-05-29 10:14 ` Christophe Leroy
2024-05-29 10:15 ` Oscar Salvador
2024-05-27 13:30 ` [RFC PATCH v4 13/16] powerpc/e500: Use contiguous PMD instead of hugepd Christophe Leroy
2024-05-29 8:49 ` Oscar Salvador
2024-05-29 9:58 ` Christophe Leroy
2024-05-29 10:05 ` Oscar Salvador
2024-05-27 13:30 ` [RFC PATCH v4 14/16] powerpc/64s: Use contiguous PMD/PUD instead of HUGEPD Christophe Leroy
2024-05-29 9:23 ` Oscar Salvador
2024-05-29 10:07 ` Christophe Leroy
2024-05-29 10:11 ` Oscar Salvador
2024-05-27 13:30 ` [RFC PATCH v4 15/16] powerpc/mm: Remove hugepd leftovers Christophe Leroy
2024-05-29 10:12 ` Oscar Salvador
2024-05-27 13:30 ` [RFC PATCH v4 16/16] mm: Remove CONFIG_ARCH_HAS_HUGEPD Christophe Leroy
2024-05-29 10:13 ` Oscar Salvador
2024-05-29 20:49 ` Oscar Salvador
2024-05-29 10:23 ` [RFC PATCH v4 00/16] Reimplement huge pages without hugepd on powerpc (8xx, e500, book3s/64) Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4994e1e6766975ed1f739838619a39b21a898d8.1716815901.git.christophe.leroy@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=akpm@linux-foundation.org \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox