From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34643C4345F for ; Sat, 13 Apr 2024 20:12:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB6686B0087; Sat, 13 Apr 2024 16:12:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8CF26B0089; Sat, 13 Apr 2024 16:12:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E0596B008A; Sat, 13 Apr 2024 16:12:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7EBD66B0087 for ; Sat, 13 Apr 2024 16:12:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1F7FCA0150 for ; Sat, 13 Apr 2024 20:12:35 +0000 (UTC) X-FDA: 82005606270.17.D7A848E Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2075.outbound.protection.outlook.com [40.107.102.75]) by imf25.hostedemail.com (Postfix) with ESMTP id 1BFE9A0002 for ; Sat, 13 Apr 2024 20:12:31 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ccn8w4ht; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf25.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.102.75 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713039152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w1dU1IB96tlkruBZtXgTUb+RzON86jsl2WlPUA31/EM=; b=6K0+bTAQz5RHaVz1Yy+F/ILGeUp3bWLaHqAiv9TufXTObc454sZ9d6jPXLueyTJjISWqAA 5zIAfF18zNjj1Rdt8sEgY4BLINIfRYdeyf4elAjLVG4wQcu0k1kJTR4KULLOsX3gLdAoh0 6g560xSRfSMHngTpUC5/DEiJt62t3ME= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ccn8w4ht; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf25.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.102.75 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1713039152; a=rsa-sha256; cv=pass; b=ai6L8vkxOWnv2pcSXSBfbRVDs3SuvHm+KOwtTGcnlOqQ1ZkGiRmkSf+JpYEDnnpOJLOC84 zDAfiSVoGCJbVZrx0mz0uumzsu+hoaypU2HKbfExi26tT7G9frOJxhVdEcwmQH+bfLYbog HcLW014RqDOYPZONfiwRFmmZcM/4FKg= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HUEVyDVbrG8K+tLel9BNv4Z5t63FwSTOmz+g+XXdF8mjM/zzhgrwCmTsqhQdDqif/zfjsZT6o58CD3M0jyJ5fM25mIXbWV06EhBpaLpcKhxMpdGu2m19xAK5KqQmxY1hRo1f6V+mi6q+17JdrrSf9y7ayMN4l0OWVM4A31QRtSWv4Q/15PYcQrURtMGw2OnxfBcZKqyD1HvdcjPhxUtofn6K7Wi4HrjXO5nsGpUn4RNnhyEFjM+0fe+eGnotL3X9KHrgFVuxouMfv8ncM6JyDV+mPoBdF/mAqxQR6U/3vBdn5Vsg8LYsk1CwBW4jF6bbXlSyp/zpXJV9MZBtLF52KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w1dU1IB96tlkruBZtXgTUb+RzON86jsl2WlPUA31/EM=; b=Bn0zXH4tziyPmaKbZkrgs9omZ8WiZVlS1tKnS88lGIQ5OhIYNtLuXGEJ+DSY7MsAOprAj4XY1VY0gla24gPXQ0IlgwJHBJFCUfi4Wrfbiw+ADsCICmuJPlMaIbzpZsPGdHiPz0wWfF90syl0NuD4YC2id8Bg1ZvpXwH2kX8Duao8nSHorLGOk+NikIvavOxG9P5XTYDtfu0mfL1+gG754/Hs0nLsdb5L72HcesEDsny82syyTbaxhWiyIs4F3LvRx+z38zFadI6nUehkvOOSt2nkNZ0tQr1RYs+oYKeJ2OKcm3Das3hKGZqYKRJ9/l7XjxSktmIZx1X3xqpyi0G78w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w1dU1IB96tlkruBZtXgTUb+RzON86jsl2WlPUA31/EM=; b=ccn8w4hthDc8Um+YTEHRtzpYLIj2iYVXP551udB3zmidxNG36Q42KWV0ppUerXx+rDn2G5rGN09ubudDFuDajew1LJTFsuW7+/vHh6fqxLyPP0QyRludIEQ1znk7sLxSYCEIai2q6U02AyP1qthy6vBGE2i7npR3Eqj390J/lD7/03mVJEb9w6E1+cdxBOofpW34x4G3Fdxzz9RneVnwF+YNNzHDh0swIhpevHLIFaXn/K5yv7+I9mjSKtuuYD8pER+miLlCOi6KVDtRx1H9G3PybhAd1IaoQiGmAXxA1vfrZTi8U1NvmVfTqgS7oiKJPo8hyRT8hfwOFftD1ltlRA== Received: from CH2PR02CA0030.namprd02.prod.outlook.com (2603:10b6:610:4e::40) by SJ2PR12MB7918.namprd12.prod.outlook.com (2603:10b6:a03:4cc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.54; Sat, 13 Apr 2024 20:12:28 +0000 Received: from CH2PEPF00000147.namprd02.prod.outlook.com (2603:10b6:610:4e:cafe::6a) by CH2PR02CA0030.outlook.office365.com (2603:10b6:610:4e::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.31 via Frontend Transport; Sat, 13 Apr 2024 20:12:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH2PEPF00000147.mail.protection.outlook.com (10.167.244.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Sat, 13 Apr 2024 20:12:27 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sat, 13 Apr 2024 13:12:14 -0700 Received: from [10.110.48.28] (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Sat, 13 Apr 2024 13:12:13 -0700 Message-ID: Date: Sat, 13 Apr 2024 13:12:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] mm: use "GUP-fast" instead "fast GUP" in remaining comments To: David Hildenbrand , CC: , Andrew Morton , "Mike Rapoport" , Jason Gunthorpe , Peter Xu , , , , , , , , , , References: <20240402125516.223131-1-david@redhat.com> <20240402125516.223131-4-david@redhat.com> Content-Language: en-US From: John Hubbard In-Reply-To: <20240402125516.223131-4-david@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000147:EE_|SJ2PR12MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: a0aaa0a6-70c6-472c-e044-08dc5bf60abf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MjNVtL4LM6YK6isq4wiC8G4q8ELWNqm50rFIV6H+AkQtPk+GNTw1bypC5EjFciw0xtsNof2pxnozwmce5kJhp/UKNGsBchZdVd57/QS3woqC9fpotDv8P+94mug9Qf8sZK8laLf1JDgSbzCi5zTiKMN/k4+uqV+wEkI9OEsegekIJXERp4onv3JmvZGJwEh1NVivpGH6lTzllKAnK/xnEacIOgtAODTrv0AdzAzyF9ds0wG/RndBT+dJI1xQzJ0E9+NhOyM/jJAzNKmRzKchsEE3dTMroOA7el2vmvBvx2JB6qy21uRQeNNivbmCVZH7jkr6HvyI1JjiEYb9XfLnc023Q0V1r6qQkxB7J2q7vAi9V57pNTfjqwVnguB5TlqwZ+hE4p7q7aqolWpHtjZEOLDyGmPAuavVXib7XqXKjG3Xh6DFUOxLSIvVNJ0Zev4v17HsRH0/UlyMIh/X1djxTtymLetHYnTv50FYvUWayq4Y0S3mwe9J6WE17YBbZCklEmiTKgcvuZ1Gc33DjkjdSrdMT30eG0/T6p4YtcWU3n/WZUNnsRiwuFxHicp8MsLNN9aXbMOa2CUM0/1G+nloeyJ44xMZB0/FBVOaCyAxZeMn8o2vOmMT4DUOcPykhKwQyJ81uQq3WBLkfVr+6HWpsuJhKqSLfPCpBLTNC24e0gnSvqPkm387Me51zAyx+uC0oeFRFtx4kqrgAiWY0zDLntM4WVVzD2Yw/grQJCLhM+s1mY8b6mRGtqVG6+U8buR9 X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230031)(82310400014)(376005)(36860700004)(7416005)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2024 20:12:27.8478 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0aaa0a6-70c6-472c-e044-08dc5bf60abf X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000147.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7918 X-Rspamd-Queue-Id: 1BFE9A0002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: cxsxhm5r3rpsygy9ypf86kbfabkmt6t7 X-HE-Tag: 1713039151-571607 X-HE-Meta: U2FsdGVkX1+lEYhSOwhT1bH9+oJ6ER3c+jXSnYo2dXz9OsoMZNTglg9vUEBYvh5Uk8ZLjpQjpMzcxs1TOM+bxttQKfESNSC4tcpjb5dI5Y7sm8K0fkjBFLaokdw0IHl36Q7L8yjTQ/74fAA6dCNjS4lrNtAXtN+10Ao+xjDD3STo71nLUjVMtaVhtFx74dD4vQ6OGt5Aghb3v2ieLGGfxqdXuwNX3KEwfFzouVZHGE+Df5cK9w4rx3C9XtDwiBVPnTiY2Ce7SseunBG1Y24sYthhaJXNBFSn5hAeKh68/VsAT7+CS1AtteB5z1rIQlLY/Yf/oly954FFUE007dr0OE7qF6NAFXKDer/Gp/8ZI0oYfvsb+aaskHQqHkvJDtK7CtXcWJfQ0eF2TCJlQAvX1kd1P7midsKt0aSeeNKfnTRHyQwDd88mXO0mIwfglpyHqYMyi4bWMe5JRde4ThugExt6KJa0yx71+7djA4eR5UUbyykUg3oW0tH989fIH7dxltiesI7jZ3ZNF+E8Qq/L1cGDzB6U4FapLjelraQWMyxZ4tBWVqUniFZh7YjYa7stUQWU19CFtKYC2qnQIU4vHFqnBYkqSmERNtc6gMX2BeSoB7cEcOARqVMRYQS26rhep/k+2mLGWG0O8FeZLMYPXQNhrgp/iMAUXbyMaGl0zq7JiP1HIaPYhSXl4pT2jzuWwZSdNVVjsXKKwltQM2fzqZeb5rDhg8wzhFQW+Gwo+NOBowWgoeat5KcP7l0mr0N4NF7seOb7hizQOcoOgRCEr5gJHZaRJvSDYcPtnJts13wbetA5r/L//Fr4CwUHUpwhSGJ/wvIFgUoougTVMLKVqmlqo1zdS9Z94SHnML+3Mk/J3CqvXlIVHBoEt8CINLF6VArLxT+DRAr5ivSsrGnm551Y2jnbV1xW1+CW0LTJt74H1LcyH5BNlpX5XFserj1sPwDxYZTa73lu7tureYE v9f5pGcf 2I2amUTVprpStRRGNP4N1Nn6x//gD4g0kcxqc4nRq7Uf5LJ6fOMB97z0abAAp+K1jKUpt4ojr+LZKIBDljCvyFLnO+6lZsnazZYLJYyFf7twxkNZGeocMvrLq6fjGWbkhWN4KcIpxasj+N1uH4f4svMMizc/TEt5X1siW4tKSTBtcLEtIyxMgGcrnW8a8y30+whxHF0dHfVQzXFUDWUUb/MTqGiSNUsIxz6UzfwQP14BUwfSdq4rzd4pv5Ifpm1qzJeyp72a9RRkJZkKHVCv/hc0DQWRB2wz9nSHxvT5jWxLuoVnVQhY35JMomJ5Sntn6XgDVh2MbIpe92wL2n7eqrpi0gjly5BoxWpjlj47pUEoZvcyMnC9XjqKl4L98Y1Pa1/ozsIYEnueM+DvwrIOF25Uc196ML3x/giyHqNT9Y2XPX3lX/MoU2VbQ2BEg3N3YKmdoxrVS6jiXyN3E6iSCKqjKsvlV7/klNTTC9F8RKxa8sGM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/2/24 5:55 AM, David Hildenbrand wrote: > Let's fixup the remaining comments to consistently call that thing > "GUP-fast". With this change, we consistently call it "GUP-fast". > > Reviewed-by: Mike Rapoport (IBM) > Signed-off-by: David Hildenbrand > --- > mm/filemap.c | 2 +- > mm/khugepaged.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Yes, everything is changed over now, confirmed. Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA