From: Dave Hansen <dave.hansen@intel.com>
To: Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
alex.shi@linux.alibaba.com, dwagner@suse.de, tobin@kernel.org,
cl@linux.com, akpm@linux-foundation.org, ying.huang@intel.com,
dan.j.williams@intel.com, cai@lca.pw
Subject: Re: [PATCH 2/3] mm/vmscan: move RECLAIM* bits to uapi header
Date: Wed, 1 Jul 2020 08:56:25 -0700 [thread overview]
Message-ID: <d48be7a9-ee18-956b-a14f-7eda08aa7bc0@intel.com> (raw)
In-Reply-To: <20200701154635.2dwwz2b6xbeyp2rc@intel.com>
On 7/1/20 8:46 AM, Ben Widawsky wrote:
>> +/*
>> + * These bit locations are exposed in the vm.zone_reclaim_mode sysctl
>> + * ABI. New bits are OK, but existing bits can never change.
>> + */
>> +#define RECLAIM_ZONE (1<<0) /* Run shrink_inactive_list on the zone */
>> +#define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */
>> +#define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */
> Have you considered turning this into an enum while moving it?
The thought occurred to me, but all of the other bits in the uapi file
were defined this way. I decided to not not attempt to buck the trend
in their new home.
next prev parent reply other threads:[~2020-07-01 15:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 15:26 [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl ABI Dave Hansen
2020-07-01 15:26 ` [PATCH 1/3] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-02 11:28 ` Huang, Ying
2020-07-02 14:36 ` Dave Hansen
2020-07-01 15:26 ` [PATCH 2/3] mm/vmscan: move RECLAIM* bits to uapi header Dave Hansen
2020-07-01 15:46 ` Ben Widawsky
2020-07-01 15:56 ` Dave Hansen [this message]
2020-07-01 20:03 ` David Rientjes
2020-07-01 15:26 ` [PATCH 3/3] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-01 20:04 ` Ben Widawsky
2020-07-01 21:29 ` Dave Hansen
2020-07-01 22:01 ` David Rientjes
2020-07-01 16:00 ` [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl ABI Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d48be7a9-ee18-956b-a14f-7eda08aa7bc0@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tobin@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox