From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67803C27C4F for ; Thu, 13 Jun 2024 08:20:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA0176B008C; Thu, 13 Jun 2024 04:20:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4F546B0095; Thu, 13 Jun 2024 04:20:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3EE16B0099; Thu, 13 Jun 2024 04:20:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B49C26B008C for ; Thu, 13 Jun 2024 04:20:46 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 67AD84197D for ; Thu, 13 Jun 2024 08:20:46 +0000 (UTC) X-FDA: 82225169292.16.EF8AFAE Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf27.hostedemail.com (Postfix) with ESMTP id 9183A40011 for ; Thu, 13 Jun 2024 08:20:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JuEYxjOF; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718266843; a=rsa-sha256; cv=none; b=leesIrwY6y50HAtI73pO0jkzAzdQbVgrDXHzLVbrpMNkpqCL4zS2UiAJZiiNWdyq3bkr7u Nb3N9f8081aR01qQGiXVTk5dAvvNIt5IanIQ+SEI1XzDqfOfQymUdFCGkiJDUZ9AM/TX/n r1FnPsxQVHQ/Naeh6mkt93bUjP02MYM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JuEYxjOF; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718266843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/lFAuOYmr8Us+EmOEoVPRlzvuNvNZ/fszqFE/s0Rh5g=; b=N9hSkO6LczYi3v7eyskg5pc3TAMWBDrWLdbjuqNtoqJZQMgC6DR8/HsxELC9NDp7FoqC/v chcEmuMAdiw4E6huB4cfwik+OXMB1bJTYWduzev04qrT2zbsr6ha4a8Hc0bQ3wFH1tG/M3 kE2qqo2t2qr5bj+psz7nDgoRYsaceTA= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718266839; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=/lFAuOYmr8Us+EmOEoVPRlzvuNvNZ/fszqFE/s0Rh5g=; b=JuEYxjOF1U4tB4h+wwSoa1YAzTLpjswX+k2Ehu0gwlae5vI0XnP2a8k2ljEhQ9RrPcvbQmFG+ioZkpI9YUvYrtCoPBDyh16fGErc0sKZlsTQ35+lSJfbP9o3N3GnRPCOUkh19sLJ90OKEJ61IcRi+amE666UsTrM8oOsqzKshLE= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067112;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0W8NU4Xs_1718266836; Received: from 30.97.56.57(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8NU4Xs_1718266836) by smtp.aliyun-inc.com; Thu, 13 Jun 2024 16:20:37 +0800 Message-ID: Date: Thu, 13 Jun 2024 16:20:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/4] mm/vmscan: avoid split lazyfree THP during shrink_folio_list() To: Lance Yang , akpm@linux-foundation.org Cc: 21cnbao@gmail.com, david@redhat.com, fengwei.yin@intel.com, libang.li@antgroup.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, maskray@google.com, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, ryan.roberts@arm.com, shy828301@gmail.com, sj@kernel.org, songmuchun@bytedance.com, wangkefeng.wang@huawei.com, willy@infradead.org, xiehuan09@gmail.com, ziy@nvidia.com, zokeefe@google.com References: <20240610120809.66601-1-ioworker0@gmail.com> <20240613072858.16512-1-ioworker0@gmail.com> From: Baolin Wang In-Reply-To: <20240613072858.16512-1-ioworker0@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9183A40011 X-Stat-Signature: drqos3c5s4yhoetbiw13zb5nu3tgcag1 X-Rspam-User: X-HE-Tag: 1718266842-569693 X-HE-Meta: U2FsdGVkX1/X69oIdbco+LSe0Fe5XSnEEFuYX2iN6U4zn1ZaZMzl1ezUkx+hpcuj0KX8F0zqMVO19XxM7FQLKRrxDnoVP+ESWt9jlOAT6KpVK6MhoHfHAsiPdzP/KzmZ9bMQwTnqtTkuwwCl7vvJS/igEOkzramjukMCLeR2dkv89HNQAku6wgQWNN7nDsPgefyQW9PJQ45zFz66a2W2s0NDKBlMSUXld/wYNIy7YcPQNIoF6+4B3CPxwCcJ7Qfc9poypBx5bgpNbeMpCLCQdPV4IsXvImHR5HN0E9hP+dkNooAU3/ksBrYOZyt/A13R5pSW/E0IpUDo+VirztwiqyXJcf86FdYpOU9OwNIsJRUCi+VCRSoIrE7DhlVWe7Wq7+G0oETyQnNLo3/vly0pmuQiHRoFMz0JuIAanblUsxU29azlK2yncgmDHMpqLSejmzLbXdVSiWAlrsLoSBlmynYtCgqkpiRSH5mbttRnpJgegjrSd1B1e/lSjkyop40duprm47nvoJsDosuntb6OcB4ZALBjJd/BbfioqAxlm7v7mZSAAfmeagz8uPDM/KesfGch/x4a2Zt2gbPTo/zxTJZSQE/BACdxczIQz8f40ibpPLhukHadc7s2s5714EoMaG1tch9BIk29clJgRwzQDf77/fd3GRKtREHmCLspfNyF6QJ+MuFdX2ilkSBBTeMhy8S8fCYvxgnTo4UMTokgTVoP9xGkWQfDe2c1AiT81gLHagGsjW9bjTKho3HfYbsqUT2vwjoh1I70k3JQuQcpnurbVK33A7Vb3MGsJw+nGxnHoeAEzwYqJbAGRLwE7NnL1TdrfDC1Msg9kG6RvcDHcR2rwk8HJrVO//jk6+LiZDACmDTNwYz19bsFZseb/Uk0a7q1d5EaDFIABB39BPCLPL+NuqZ5QDU/iRPigXDK12zK5aKLFKB24yQ3wgAloXFKpAP6XcSen1dFP2DemPf t7p3+Y8r Q9DjBm+4wwPLE9BAz403xkFpN0QKd+G4XD6IWUXgFDGqlw354MNx3Kw43sjqMDKcxVMl08yKuHSotHYfPpJTrGsgQMRgBVXaMgdq9/WPL7VmORiebbU1PuJD7eKPFQTJ7odRZQEuvnlnay0qMe+F403AVQPatS66cFLvH8tf+XNwJh9bYI1CTd8aGEqPF4waqjtDcHbaJHN6rGxvfU4PSNG1fNllDWIr4eqxRH0A46kE8YQ2CpkjhBP585YZ3g9YuoLDewjk3aBy+ekMz0bIPwWwQxMIRwonwYV07luLnY4oHz/gDCgIJyCO2DX5YKRMvKqWSnCA3CYxTbt5k3uDGyPNo1U36L36uMKBs28eJol5CGUnTiCiQFzoQ1ccY3R95sfDEsY+IW11Qsp+0YYPCg/PHyzjd/BSRT9TG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/13 15:28, Lance Yang wrote: > Hi Andrew, > > I'd like to fix the bug[1] I mentioned previously. Could you please fold the > following changes into this patch? > > [1] https://lore.kernel.org/linux-mm/20240613065521.15960-1-ioworker0@gmail.com/ > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index f409ea9fcc18..425374ae06ed 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2707,10 +2707,8 @@ static bool __discard_anon_folio_pmd_locked(struct vm_area_struct *vma, > if (unlikely(page_folio(page) != folio)) > return false; > > - if (folio_test_dirty(folio) || pmd_dirty(orig_pmd)) { > - folio_set_swapbacked(folio); > + if (folio_test_dirty(folio) || pmd_dirty(orig_pmd)) > return false; > - } > > orig_pmd = pmdp_huge_clear_flush(vma, addr, pmdp); > > @@ -2737,10 +2735,8 @@ static bool __discard_anon_folio_pmd_locked(struct vm_area_struct *vma, > * > * The only folio refs must be one from isolation plus the rmap(s). > */ > - if (folio_test_dirty(folio) || pmd_dirty(orig_pmd)) > - folio_set_swapbacked(folio); > - > - if (folio_test_swapbacked(folio) || ref_count != map_count + 1) { > + if (folio_test_dirty(folio) || pmd_dirty(orig_pmd) || > + ref_count != map_count + 1) { > set_pmd_at(mm, addr, pmdp, orig_pmd); > return false; > } > diff --git a/mm/rmap.c b/mm/rmap.c > index b9e5943c8349..393e2c11c44c 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1824,12 +1824,7 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, > */ > if (unlikely(folio_test_swapbacked(folio) != > folio_test_swapcache(folio))) { > - /* > - * unmap_huge_pmd_locked() will unmark a > - * PMD-mapped folio as lazyfree if the folio or > - * its PMD was redirtied. > - */ > - WARN_ON_ONCE(!pmd_mapped); > + WARN_ON_ONCE(1); > goto walk_done_err; > } > You can also drop the unused 'pmd_mapped' variable now.