From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD72FC678D4 for ; Thu, 2 Mar 2023 12:42:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 037BD6B0071; Thu, 2 Mar 2023 07:42:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F297E6B0073; Thu, 2 Mar 2023 07:42:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC9E46B0074; Thu, 2 Mar 2023 07:42:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C89296B0071 for ; Thu, 2 Mar 2023 07:42:29 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A02061A04F0 for ; Thu, 2 Mar 2023 12:42:29 +0000 (UTC) X-FDA: 80523921618.12.D2BD41E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 7EAB54001F for ; Thu, 2 Mar 2023 12:42:26 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bHBQZ2kT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677760946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9EbyPGw/PLfi7RG+ShAiqiUEOlZiujjcNGly444bA7g=; b=0stgjJa6OQHcLLN9V3fIwgGg1Gtjsle01m+OYyqRDtzNKvUiQNrPBvxUnCkMFbVqYnWnW2 Me8cHk+o4Ov7go49Acmtazk5v0GVumQYrGdzvQOLGIxtyZRwl17WF8xrL9PqbYHLWpMGTK T+Jo653jnJTcvHjaTqT1XgBjB1fzgBg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bHBQZ2kT; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677760946; a=rsa-sha256; cv=none; b=dSnmcgleoNHMtRhX/y4iiVEstTEPiqdgWNQpGv/cnO99hIkTemopJXSZ13+kzPl96W3o8s Jx5ez4l7v2iAhAc7h9qtw2FIoUsDBORzGg9X37e34c3TvX7XEyZ8MJevT8xiyehz7zRZzG rs7mERKqmBl+QupEYS2bPLe7lAyHm2w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677760945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9EbyPGw/PLfi7RG+ShAiqiUEOlZiujjcNGly444bA7g=; b=bHBQZ2kT3epMt3hYR0V5JbW1pyVeq9j49g/2jyytSi9e8QmNH/MY3nUMeMwjQdh72W5Cs4 WWh6xkLLTB/LfkkL7SF3Cv/ovBdOlOxDV8f/fprtvjzM5DXyzZUg59kyTeocEQ/TQWYGVQ njRb9LWJBSOC8H6ozLkdKgBU9PqhPQw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-281-0WcacO9LPOWxXQkPRsleNQ-1; Thu, 02 Mar 2023 07:42:24 -0500 X-MC-Unique: 0WcacO9LPOWxXQkPRsleNQ-1 Received: by mail-wm1-f70.google.com with SMTP id m31-20020a05600c3b1f00b003e9de8c95easo5708199wms.2 for ; Thu, 02 Mar 2023 04:42:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9EbyPGw/PLfi7RG+ShAiqiUEOlZiujjcNGly444bA7g=; b=vcIiLTgFpy1eMZxYfz0MHpsC8yjm1nDJqbfEbBHclzN2VBGmuOUg9hZ1zeuS5c1HXq DTclZlbKkq+rCH0XJhFdUHPxQkkHzVRuS4WV7Wk3Ryzy+rmCNaLy6FgxpRKY8ON67ftu Lb5rjsG+BK/4Wb6Ky2nD+ezO/YYpos1P6g8NFatP7CsHgghvWpRcjWDE0nFHJHLtbu7Y C0P+nrWowlgYRs4cyewlARtut6y0Laff6xITW5Nkb7w2Vui4BmqI10ahMUPwlkacEXTJ 38SdDJinVhEqw1b0jzQDl7y1c+B3GQcdpjJNZ2r7S1Yn7qbA6awXGIlfPArzKHDgC09g HSLQ== X-Gm-Message-State: AO0yUKX2iSrYH+VbFDkHlXWbFlroRuoRaJkhw7Ahp3EsGG4y5HQ5xqPx bVPcLfhuIAK9j15g5WCys1Au2YwtBqun9UVHuYlSFs8uJXCP5pOHyGpNjDolqZ16SNYOGhc1III kyG1/ilvXqtI= X-Received: by 2002:a05:600c:3b14:b0:3ea:d620:57a7 with SMTP id m20-20020a05600c3b1400b003ead62057a7mr7976430wms.8.1677760943699; Thu, 02 Mar 2023 04:42:23 -0800 (PST) X-Google-Smtp-Source: AK7set/QrSiKFfiLUJO8Cajioz2AbQDvgkLMFQdM8vHtrEf3tbr3y3T5RsMAGax2eUNWsnEQkfOzWQ== X-Received: by 2002:a05:600c:3b14:b0:3ea:d620:57a7 with SMTP id m20-20020a05600c3b1400b003ead62057a7mr7976416wms.8.1677760943365; Thu, 02 Mar 2023 04:42:23 -0800 (PST) Received: from [192.168.3.108] (p4ff237b6.dip0.t-ipconnect.de. [79.242.55.182]) by smtp.gmail.com with ESMTPSA id x16-20020a1c7c10000000b003e70a7c1b73sm2770968wmc.16.2023.03.02.04.42.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 04:42:22 -0800 (PST) Message-ID: Date: Thu, 2 Mar 2023 13:42:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH V2] mm/debug_vm_pgtable: Replace pte_mkhuge() with arch_make_huge_pte() To: Anshuman Khandual , linux-mm@kvack.org Cc: mike.kravetz@oracle.com, Jonathan Corbet , Andrew Morton , "Mike Rapoport (IBM)" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Christophe Leroy References: <20230302114845.421674-1-anshuman.khandual@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230302114845.421674-1-anshuman.khandual@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7EAB54001F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: dqoado473ze1qdcnjjepxgrpztpub4qb X-HE-Tag: 1677760946-132370 X-HE-Meta: U2FsdGVkX1+7koM4W3tYsegrqpCCwo1inFeSaRalu2djBljjfdSZFtegFL9IRfPL6o7eC742fQ+WwCKEItRdHA1w53JELhMu08Uvps1IO885BbsmebkCHwoUO5FgjoQXdDG54sE7bpDiSnKaxbKo9ttFV9C8FwCV+5sv3ImTN44C1Cn17OQ25TabPIp4m6i+MzuOOXcX7q9Y6GW0DAK/QfVDGZzeD4TA4QRz0BWh2T7TIzLINhcsXSxuc712nQV+F50+KPIIkAW6uVM3j5fYkDt/atjVC5JpXH7gAHjvr3tedg0Qao0/TIirVhho0CyqfzDcEbwpOx0VK1SGamDdJhOrXQEO4eahgHKSMR6VzdUUNg32Ri1PVmp7fhu86oPQueCv7Csa16JmDiTRpIOqli9A5otO+dRh/5Pxh+NlfCdSMKHAJlGVjHDHREkfmHtBccylpCcVmi5nI3mH97yARN1Nw2FrscmYmS57qhC3EtGS2krdKklH4iQqyCqpy3NhnCDgdQVDJ/E7vwncqUF8etrOjHq3PJoKR1eE7RGy1vIYueuX5VkZHmjPZmxg9m9nSo0GgAUVpPi4GZhntYtwusN09Sjq5CwDCX5mV0LBE/H75imT41oxHkumuOuMXTJ/i3i7id9M9exVWnIV2oPiAcAURAwIK8VGb919Q7A7W8skmn2McOxIR1QSQ1uOM+Mn0ShTlP9kWgiCHgeYDncc+pPzV536N7IFGFpOEeB/NaIInUJW2HIE2nERfoha+EK/McnzmxaivVGYXuAIxamT0NndLlXPI1BYMh5dAfKcISL6mOenslp/fLaSYpnggNIvRX1PQzXjUIGI6WS421xlnNejWlufi8K0hij2iVqhm4TsDzFq+kSndYtxFrSZlBCaSFyxYX2YpTbuGtTph1uXC7lhFohq6q2LDD/Ped2+eGmZZGb6lgWfxKB8Congx8nmC1TsDiiTyIF6vE28V/F cskK6Y2A hoBuDey0SaH564uJ++Y/wPxJskEYsclCVR1HXOv6eIWzLmMYN1CE68YdQZtmWkQqf+o0hiluOsJg+GGZmGNjAGjEwkaa21WluBv5wtmBNjfk+mPNGcZx+xG0/9bE6AzQEJWNLeCk8IF2R3SFGNEWmGLzWAXy2OO8Z7PF3UNQntGbtZ+X6gGuA/ZYpsjm6mHFY6mtsJEh9OgyNTJVmrhnTYfkTgndk0g5Ak9tHGnKFgE3apvudiE6qCPNZaEnWvGFxuaIJvPr2su24OzDtYWNe6idS97SBMMlld6zhOHKNEDX7QAVMxopNdreluBVgEYabkG1B7Z6Qoh+Tchgmlr1gpo3DUvH6s9wvVBu06pTkTMA4MvfDgNnf46NLzJRv9veTUUwqIZtE9mx5zt+9nBSiGtkyL/RIFI8IEth0osK4Weg8mYAjTrotzyCtEFW7HSFVtNTPgZ/d01a98H+eu8kgG++R8BuxA+5uKSlqcT1tZbK51uODGrLJGRJwhReIpqn5NMy5ujmoL3/h5JH5t7QcyoK2+keQVoBIM7lps+4MbrEKbqG1G2O6NsmRN0B25ZDnmdsTpXgpGvpTSGhg06qRLHAqWb9n/cGusFabKx0x9ieHSOxBLnqF0+l/4UTVYLAWKPFPUYEzQlVES9tpnj9QyHE19XfYucwBchBjj/EZ0SdP2BOou7Xv4M7d+mCSk5ApSK0OQcODmXk0T105CVhJ73arMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.03.23 12:48, Anshuman Khandual wrote: > Since the following commit arch_make_huge_pte() should be used directly in > generic memory subsystem as a platform provided page table helper, instead > of pte_mkhuge(). Change hugetlb_basic_tests() to call arch_make_huge_pte() > directly, and update its relevant documentation entry as required. > > 'commit 16785bd77431 ("mm: merge pte_mkhuge() call into arch_make_huge_pte()")' > > Cc: Jonathan Corbet > Cc: Andrew Morton > Cc: "Mike Rapoport (IBM)" > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > Reported-by: Christophe Leroy > Link: https://lore.kernel.org/all/1ea45095-0926-a56a-a273-816709e9075e@csgroup.eu/ > Signed-off-by: Anshuman Khandual > --- > This applies on latest mainline. > > Changes in V2: > > - Send PMD_SHIFT and VM_ACCESS_FLAGS as arguments for arch_make_huge_pte() > > Changes in V1: > > https://lore.kernel.org/all/20230302031833.360679-1-anshuman.khandual@arm.com/ > > Documentation/mm/arch_pgtable_helpers.rst | 2 +- > mm/debug_vm_pgtable.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/mm/arch_pgtable_helpers.rst b/Documentation/mm/arch_pgtable_helpers.rst > index 30d9a09f01f4..af3891f895b0 100644 > --- a/Documentation/mm/arch_pgtable_helpers.rst > +++ b/Documentation/mm/arch_pgtable_helpers.rst > @@ -214,7 +214,7 @@ HugeTLB Page Table Helpers > +---------------------------+--------------------------------------------------+ > | pte_huge | Tests a HugeTLB | > +---------------------------+--------------------------------------------------+ > -| pte_mkhuge | Creates a HugeTLB | > +| arch_make_huge_pte | Creates a HugeTLB | > +---------------------------+--------------------------------------------------+ > | huge_pte_dirty | Tests a dirty HugeTLB | > +---------------------------+--------------------------------------------------+ > diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c > index af59cc7bd307..7887cc2b75bf 100644 > --- a/mm/debug_vm_pgtable.c > +++ b/mm/debug_vm_pgtable.c > @@ -934,7 +934,7 @@ static void __init hugetlb_basic_tests(struct pgtable_debug_args *args) > #ifdef CONFIG_ARCH_WANT_GENERAL_HUGETLB > pte = pfn_pte(args->fixed_pmd_pfn, args->page_prot); > > - WARN_ON(!pte_huge(pte_mkhuge(pte))); > + WARN_ON(!pte_huge(arch_make_huge_pte(pte, PMD_SHIFT, VM_ACCESS_FLAGS))); > #endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */ > } > #else /* !CONFIG_HUGETLB_PAGE */ IMHO, it's a bit weird that we are starting to call these things "arch_*". PTE operations like these are already mostly arch-specific helpers with custom implementations (and some generic ones in asm-generic as a fallback). So this one certainly sticks out now ... anyhow, change itself LGTM ... -- Thanks, David / dhildenb