From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C43C433EF for ; Thu, 21 Apr 2022 07:10:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6199D6B0073; Thu, 21 Apr 2022 03:10:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A2246B0071; Thu, 21 Apr 2022 03:10:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F5EF6B007D; Thu, 21 Apr 2022 03:10:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 2F7856B0073 for ; Thu, 21 Apr 2022 03:10:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 015DB261CA for ; Thu, 21 Apr 2022 07:10:03 +0000 (UTC) X-FDA: 79380011928.03.4F09AAF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 07B73140017 for ; Thu, 21 Apr 2022 07:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650525002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=63ViWfLlmaj/DhjRP9oFB/1KLHxLMeQrGcqkKvT3aeA=; b=QcxqVShYQymURTOj3Hw/XPcWdNd3zsKfvzCfVN7fZA6cf5LBfoieZ9DsVjMf5JHZoq+Ozr CRsLRk/pU+wtzp1PL+3RFBhtagBHOdhGYu+v50nlQU7ShWlUp7fev2Jq/MlulPpnE0zVUl vDrB6JWpeUqj5EPTR3iaow9zNVqoJUM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-448-Qu-ycjsnM02k6-B2L8nOMA-1; Thu, 21 Apr 2022 03:10:01 -0400 X-MC-Unique: Qu-ycjsnM02k6-B2L8nOMA-1 Received: by mail-wm1-f71.google.com with SMTP id h65-20020a1c2144000000b0038e9ce3b29cso4108426wmh.2 for ; Thu, 21 Apr 2022 00:10:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=63ViWfLlmaj/DhjRP9oFB/1KLHxLMeQrGcqkKvT3aeA=; b=BAvMbH8FkFDm6jzDGJcMf3ckWwEGa3DkSbdc2kYWNEXkq+GXiHTqo0qVs8uiTl69xK Ce5iRx2IBQMPPgPxG/pH0Yj87ToM1Yqr/bUSCE/C+CNo69WAj5UxtLUFr3yfGju6yTXs DARP5/wlzTya4VnW2l5ISLMF28SQ9gNnV1lsJLkP5nOSqTvoO5mbqnwDls2GPQJbml+o XX4tibTv8ySkN4mpfSxeC0qccgKnFDBFblh0kr9zpN2VkeZ/3UFyYceO3m/FkpW8BCu0 HZFYG1ahGB1c3Kcf/pU++FagKeHCwRpVcLWwOp8A1AlC0s6bHbPpxC5RSxwwIt0G6ZCa 71EQ== X-Gm-Message-State: AOAM532budm6rzbAnDg5iuaxG7CcQM8fvDA1SYzkJhzH7s2ftRqSz/4f BmFPf7Nw/OxBDIpLzKwUZVIwVImSzbIBlfgR6tVPMsrj3kRYpJ5KBeupK+LJkmpwsK4EZZDOW3Z /GmzJyjEoXOY= X-Received: by 2002:a05:600c:34c5:b0:38f:fbcb:e4d with SMTP id d5-20020a05600c34c500b0038ffbcb0e4dmr7147577wmq.174.1650524999971; Thu, 21 Apr 2022 00:09:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXav5e1L/ckc2V1R7UYJ+Xe1T+TSkgXnebYAZ2ub09jZihdAfDOzhB8LCRP40IxAf8HiDmag== X-Received: by 2002:a05:600c:34c5:b0:38f:fbcb:e4d with SMTP id d5-20020a05600c34c500b0038ffbcb0e4dmr7147555wmq.174.1650524999717; Thu, 21 Apr 2022 00:09:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:de00:711b:76af:b335:9b70? (p200300cbc702de00711b76afb3359b70.dip0.t-ipconnect.de. [2003:cb:c702:de00:711b:76af:b335:9b70]) by smtp.gmail.com with ESMTPSA id v2-20020adf8b42000000b0020aa790a258sm1628401wra.8.2022.04.21.00.09.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 00:09:59 -0700 (PDT) Message-ID: Date: Thu, 21 Apr 2022 09:09:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 3/3] memblock tests: remove extra column of spaces in block comment To: Rebecca Mckeever , outreachy@lists.linux.dev Cc: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <663c930475c3c0a32965024c1094d3288629a3af.1650452552.git.remckee0@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <663c930475c3c0a32965024c1094d3288629a3af.1650452552.git.remckee0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QcxqVShY; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: 9smdai75h8sbijstmy7ujj4oqbb18rqo X-Rspamd-Queue-Id: 07B73140017 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1650525001-628124 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.04.22 13:19, Rebecca Mckeever wrote: > Remove extra space at the beginning of each line in block comment > for consistency and to conform to Linux kernel coding style. > > Signed-off-by: Rebecca Mckeever > --- > tools/testing/memblock/tests/basic_api.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/memblock/tests/basic_api.c > index 834d8705ff8a..05448a25f1f9 100644 > --- a/tools/testing/memblock/tests/basic_api.c > +++ b/tools/testing/memblock/tests/basic_api.c > @@ -303,12 +303,12 @@ static int memblock_add_checks(void) > return 0; > } > > - /* > - * A simple test that marks a memory block of a specified base address > - * and size as reserved and to the collection of reserved memory regions > - * (memblock.reserved). Expect to create a new entry. The region counter > - * and total memory size are updated. > - */ > +/* > + * A simple test that marks a memory block of a specified base address > + * and size as reserved and to the collection of reserved memory regions > + * (memblock.reserved). Expect to create a new entry. The region counter > + * and total memory size are updated. > + */ > static int memblock_reserve_simple_check(void) > { > struct memblock_region *rgn; I'd pull this patch to the front, so you don't end up modifying a wrong style in patch #2. You could also just squash this patch into patch #2 and mention it in the patch description. -- Thanks, David / dhildenb