From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41CB7D24454 for ; Thu, 10 Oct 2024 21:19:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B18AF6B0089; Thu, 10 Oct 2024 17:19:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC7C96B0088; Thu, 10 Oct 2024 17:19:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98FA76B0089; Thu, 10 Oct 2024 17:19:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 792296B0085 for ; Thu, 10 Oct 2024 17:19:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 473A6A03B0 for ; Thu, 10 Oct 2024 21:18:56 +0000 (UTC) X-FDA: 82658957724.23.7F0696E Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by imf17.hostedemail.com (Postfix) with ESMTP id A059240011 for ; Thu, 10 Oct 2024 21:18:59 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=cOqt0Ujc; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf17.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.52 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728595097; a=rsa-sha256; cv=none; b=ntuNAxZuQcA7jSY1dy4QkUJLhUauA6VZ49V+1qdH7C/XoeVGVeIKocpiOtAxHsinfPheau 5r8MJkLDp+o3oKvTz/2lAMElpHVCdr12U+Tf8ZbMdOw2CvtV9pmT2S774HI0zifFsiItQi 4dk+HynsISTepD9FmkVmVPGZmKHvEUw= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=cOqt0Ujc; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf17.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.52 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728595097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nBZbBlwQa7HT+/mui9xTJE7fZJhA2rmF/mcQQtgNOAo=; b=GSoxQzaF/2ZmjYRMIbYVfEJt7jFB3hkiPIO6JkhnkY+lmm2Kk3lfBsLmg/jQEqUVb/92Ch AfYDQGKK8Ik5dA5kYJ1eNflBaIDMYaWxbwLZH/FuX3I8YqrubZrhUD6c8Yt/lxTAb6+XO9 TilnPisDiYE9fm6APHsmh63qzTxg350= Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-82aac438539so52151739f.1 for ; Thu, 10 Oct 2024 14:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1728595140; x=1729199940; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nBZbBlwQa7HT+/mui9xTJE7fZJhA2rmF/mcQQtgNOAo=; b=cOqt0Ujcmq+HvzorBKHAR4KgZFF87m05uxaZqRKZMWiv5lwJX367ejEDJ81juFOVn+ o9YBau1+EJ9Dg2XQG/rMRvVlRaYd/gzqSZe+l+h9lPHA39LNYO/R3F6GkWhns5XRDbGd k2k/neciE9Kt6VqySzpRe8Qx4ACB03feXfywc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728595140; x=1729199940; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nBZbBlwQa7HT+/mui9xTJE7fZJhA2rmF/mcQQtgNOAo=; b=OLRTmu8OiAF0XrzRVLbJXm4VsEU4ONl2VkFk3IvptvCf+AuXbYyO7Um7X+qriOYpfa Mo2D7xOqTx41xYEB/PUcQ7cC8EOVr9r3fGuguFBjrWUhKcoexVDBnxNIH5y9gzDdhf6k BgHo7DlukfpYG0GtmX3yUdDB51N3aV+DIh9CCurPbiqtiKdGXrwHfFT/tl7kbQ+ou2m3 g9sAbt0V9zvtyXFX3gYJh8PwSVA7jy75lwGCbyZoAEkO0OqK7KTcB09+a1HQd/Z5AFwR r7rYVepp0xNhR/NS6HZe8Kx2PPdxun7sZcizuvOCFlLCU7WrfdxNUosrIogT1GcB3VQq cNRw== X-Forwarded-Encrypted: i=1; AJvYcCXJfglFhfsx+0eg/tZfGivLPtdaGpibf3dECeW839pSJimPyr7h8xPd9mgmX2gDt2qMQebk2hpmhA==@kvack.org X-Gm-Message-State: AOJu0YzH+5Zv0oX1V8n+V6nHRWhjLJsOo8SqEpSI17xcrTarYCEWRoA0 WMOfFwvg/QtjdbeZYfWh264o2yqxhhlpZaC6BwpqoFOCHo+0I4fvMCi9Jrn8XKk= X-Google-Smtp-Source: AGHT+IEYkeeNxtQt681in3Sz57PrDzHIA9l/kBVtyF0yM/0puYCqVuivQ2EI5A8y1bdIaBfyBVotKw== X-Received: by 2002:a05:6602:1341:b0:835:3ec0:9 with SMTP id ca18e2360f4ac-83794d44d5cmr28566839f.15.1728595139979; Thu, 10 Oct 2024 14:18:59 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dbada841ebsm384083173.112.2024.10.10.14.18.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 14:18:59 -0700 (PDT) Message-ID: Date: Thu, 10 Oct 2024 15:18:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v20 01/14] mm: page_frag: add a test module for page_frag To: Yunsheng Lin , davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Duyck , Alexander Duyck , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20241008112049.2279307-1-linyunsheng@huawei.com> <20241008112049.2279307-2-linyunsheng@huawei.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: A059240011 X-Rspamd-Server: rspam01 X-Stat-Signature: hxzs8pu5f4yr5b3siui5njprxbskhhhd X-HE-Tag: 1728595139-631695 X-HE-Meta: U2FsdGVkX1+5y7B4VLEqOqWXmYgp0L24MhKduXhUepzpPis1anhFUWEcBNdcNJtfw5onXvGBVrqy/aYpmcMdNM4kDy26Gt68kW91Tyin78E3HZNcBUdYDk2CY0Mg6C+aV+wfqyXLsFdLqQIo/5Aq+7M26cOf72ob84/mqjJat62E7aUoMOeeiDbzyrmFS8778/TgyG2o+g5fbzUPDHqfPdN2VMpYUK1x6V19HMEluwsrjH5EXVdPwGgS8lqfQr3TcHlyXHIGowXkAiaKJ3l5hEbXOMr4MUCNFcrv/68EbopVmC6cte3eVybG1WJxeeaSf75+J43YAFmjWi9T9gmkiijuu0XkB4mQ3efcUM/BOdZdFfCQyHMmVg/Zm0D4KXrsRlhkTblWVwdY4JYWgtnN/xWbAqRg9Ppl2IzUcv9RH5CmaRMOMaa+KhuBP9waUWbEhF0zOAFjQmn6zpRfvrgVviuR7LlfjUVdOoIVu98HLCMrSjoSz/4DMJo1ZMyI1ugtjQQIROVVBXcn4EuiqzrVIcAeOKyFrHhrcEBoydvOGiomw3iFVW1HDvbQ+5Hv1C886KC8BzwJvrwRfTeTQOQEEVlWMSlCNYlsO9W9Yf8nj4FwZOYiTalxTk8HqjwoW/s6UAJjfcG/hOqU9oC/kXxD6JLxAti0XBMAQ/Ae+6iYIsmg1f3d89X49Y2hScK/sjsOw0Krr46LS93Xn1w9teR2OWwjdiWkNKqn6KLLyq+uEBD7c+9LRpLeXlAGVRcom+LaUIjIC3WdC/5/oGZFAVMZivyZ3xwqHjHZKquACDp1sIR+LRpes/+8FRe8wBInt9VFJ3/XFish7/2Hib/lx97g36qYl+AV8o/D65LIaBrc//tTiD7CUMZfE7Re8bopK5h0fq5vRjhS0zu9HcE5q/98GLof7u3eE/scW6lmyzlUuhzyddWpmZ80EL88Od90i+7oYD2JSmwGYBbD+L4LkZh V/YmvHLA fYj5K2dpQPDujLW837+FAY3/rIu88an1aT6hD6QIODKtNOJyA4KfjODhsveBpTOkOSmm9XWzrseguogp27CbY9qssQcr9zyntSZZfWnIXNo8bU5g/w4yQXvgUBmCh9cFFasiBwYrDZSVTdMoJtnm+yIAloFSoUvs1kFbX24ou4kx+U5/rJOugk5RNkvXeIJcvwpJSCLKXriEKUqgNjgx5a5t5eFb25v9QgYZJ55tkVZ4J5f8x9l4/KmKJTttB2OIkf7DMhxU+M4iv8mE2sJr/riY9hazkLc3LXpzXA+XzBF2RKyCHFoA6GkPhr/E14G2h2imYAX17sGbbXTBO+09vF1x34fM3ZOtRi99Zd0fyl10ypnz7MkEBXYwy37VYYv4AwCt5mIGSLjgaDxL+FD00A5V3qXr+g0jMmaJnvDk2iD2UhZz2LJ5iQ3wzU9yDjd2B/JEOaSoB1bDCKTifavDH+9ODDbCzgi2BGGUfmxNA/HXaxOtHTQUMGi/XT79hA7p2yZIghfZRNOGAEQlwA8mX/s1Tsc4AQ/0gO2PcCoJzTF0M8eWm2Qh/W+rCLVZDiAYpcfOjbtOUTdQT//Dj7bSQETWxdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/8/24 21:59, Yunsheng Lin wrote: > On 2024/10/9 3:56, Shuah Khan wrote: >> On 10/8/24 05:20, Yunsheng Lin wrote: >>> The testing is done by ensuring that the fragment allocated >>> from a frag_frag_cache instance is pushed into a ptr_ring >>> instance in a kthread binded to a specified cpu, and a kthread >>> binded to a specified cpu will pop the fragment from the >>> ptr_ring and free the fragment. >>> >>> CC: Alexander Duyck >>> Signed-off-by: Yunsheng Lin >>> Reviewed-by: Alexander Duyck >> >> Signed-off-by should be last. Same comment on all the other > > Hi, Shuah > > I used 'git am' to collect those tag, it seems that is the order > the tool applied, and I checking other applied commit, it seems > only Signed-off-by from the committer is the last, like the below > recent mm commit: > 6901cf55de22 > ff7f5ad7bce4 > okay. >> patches in this series. When you have 4 patches, it is a good >> practice to add cover-letter. > > I guess the cover-letter meant below? > https://lore.kernel.org/all/20241008112049.2279307-1-linyunsheng@huawei.com/ Somehow this isn't in my Inbox. > >> [snip] > ... > >>> +function run_manual_check() >>> +{ >>> +    # >>> +    # Validate passed parameters. If there is wrong one, >>> +    # the script exists and does not execute further. >>> +    # >>> +    validate_passed_args $@ >>> + >>> +    echo "Run the test with following parameters: $@" >> >> Is this marker good enough to isolate the test results in the >> dmesg? Include the test name in the message. >> >> >>> +    insmod $DRIVER $@ > /dev/null 2>&1 >>> +    echo "Done." >> >> Is this marker good enough to isolate the test results in the >> dmesg? Include the test name in the message. >> >>> +    echo "Check the kernel ring buffer to see the summary." >> >> Usually the test would run dmesg and filter out the test results >> from the dmesg and include them in the test script output. >> >> You can refer to other tests that do that: powerpc/scripts/hmi.sh >> is one example. > > Thanks, will check that. thanks, -- Shuah