From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC784C5475B for ; Wed, 6 Mar 2024 08:58:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2ED1B6B009C; Wed, 6 Mar 2024 03:58:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29D876B00B0; Wed, 6 Mar 2024 03:58:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 165926B00B2; Wed, 6 Mar 2024 03:58:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 038346B009C for ; Wed, 6 Mar 2024 03:58:33 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CD25116050E for ; Wed, 6 Mar 2024 08:58:32 +0000 (UTC) X-FDA: 81866013264.10.030A495 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf20.hostedemail.com (Postfix) with ESMTP id DF4941C000C for ; Wed, 6 Mar 2024 08:58:29 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ZCSHeNOm; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf20.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709715511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8sqL5oufDdJey+dd6E71N6P0bC3HDZLL4i4IRfJyaUM=; b=Z4Z9sPvC8MMG9P8Y2Qel+YUQv0UpWo789QO7NHXG9E2z0cISg97sC6PYZgRtbUdunHRu1d xqPXojm+vxd3EBRWWLBlVOEw7sOaPp+Zcx58l70svf4NByp6EAZsqnBJhf01SUAgla9+cp k/G8en9xEGF2KQV07DHLR8A2576f2jo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ZCSHeNOm; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf20.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709715511; a=rsa-sha256; cv=none; b=l2bDNgfjJmqZdKiQAWnJ0BnrXigZhdlt8G0vH5HnnnIGit5PIn/5zO0wsXxmVRo+emNs37 YXBx2Yd80vRu0xzSemqapZ36RU5nQbqMOyqe4JybwSnT+R1v8ub7cqyZbvlDyBiuMIcIAp c+hltM5It4sCpaYrblapz9Uaq4KwobY= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1709715506; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=8sqL5oufDdJey+dd6E71N6P0bC3HDZLL4i4IRfJyaUM=; b=ZCSHeNOm73OmUcFeb3pc59FQ/9hAsgNsmY0dVrhekLRBUO78p08aDPdM3fzovGB7vlC9LB83nr3Lrpr1mZigBdUwXheFIh1/Tuh5EFaYj+cx4fJ7/gJHN5lEzvFssLrGO+NyNFvCikl4/D1oAompjvaOqG18jwJDYC8qi+AG/Qc= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0W1wuDqC_1709715505; Received: from 30.97.56.47(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W1wuDqC_1709715505) by smtp.aliyun-inc.com; Wed, 06 Mar 2024 16:58:26 +0800 Message-ID: Date: Wed, 6 Mar 2024 16:58:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: hugetlb: make the hugetlb migration strategy consistent To: Oscar Salvador Cc: akpm@linux-foundation.org, muchun.song@linux.dev, david@redhat.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8d35b8ae-b8d8-4237-bfcf-ed63c0bb4223@linux.alibaba.com> <3eda72bd-25ad-4518-b38e-b63f75e5e94d@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: fk5jemoqdgj546catrbcw6aap7imzqhi X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DF4941C000C X-HE-Tag: 1709715509-262838 X-HE-Meta: U2FsdGVkX1+SBS4CFzvr4sH9lNNhbADw4ghCIkPNBlte1vN5QBlKLnWf1gF7SRpNNIP+TOpSVxZYGfiBIF3hBSHMkDWbayCA7QiqL0F3NqRIWvSasaQRnGoDEBbxb0AHvIi/LyYX0yavRKyjNZk3Oqo8N4BB4m0uITazM3guoOpy88jN0OkUuWYZ+sS1KE/PWO1u5Jc1uvWBihINeny9IYn2kDAdTkwfFDGs377M8ftnvJvlliTe6i5SU38rS4np0HKtSuWJKuDB8ECtUn/xNS8ybDN2bZk/AOwfQut1NVh56irKeEWTGCSX4SpjapBHULfQ5V5b5690KM2jXxjd+imi79HZzXiNz4YVmjtsGnaqr2yCIdIs+yr+GvmDUgoV+02pUreuYRmSFZzZLVUQOLgXdfnlwW+jBRRmaqt3Dz1TqjKnrlobqMrD7Xa5wrKHkpI78QeS5Pi0AJlzCSFnQQROoA0CkKDvY4QPGxG2z49KIrj+PwPFBavDYXtJmTJUuGH/GkcAhNaSYPfEODEaq0ko2q3+9HhJdBEB4cGbj6vs1qz/v5hNH7Ejd86aek2k3yqIy2uEEe3KIz4NzaZImMfVEPCq8GAUVQ1sehxzvUNBUtTgwflUsCrm6qhqI5ln28QoAVHNaWBcK7vr20HaD8DCILJDnbOTy4wVxfg+zK6+h65JPNZP/jRHQlTwcrTPJ/+J9usvplPCmMHiwJWL6mybYZdY5ZXpDSKVaEgoY6nKbmNcBLE1C7pCHD439uxS3wC3qrqx8lT/AXlIqesSis+5lXpR1s5lPBkWwwOfQVvQNzQZrOHiitQJKLYmQy2JlYxn3GYKgMdqkz3no8pq6deU6PqHeEStIx/WsqfhBYcll+DpnttqDjVYlHVjYZdOdHZR7Oik5tJe28lp1dO3YbATIPTHCVBc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/6 16:46, Oscar Salvador wrote: > On Wed, Mar 06, 2024 at 04:35:26PM +0800, Baolin Wang wrote: >> On 2024/2/28 16:41, Oscar Salvador wrote: > >>> if (folio_test_hugetlb(src)) { >>> struct hstate *h = folio_hstate(src); >>> + bool allow_fallback = false; >>> + >>> + if ((1UL << reason) & HTLB_ALLOW_FALLBACK) >>> + allow_fallback = true; >> >> IMHO, users also should not be aware of these hugetlb logics. > > Note that what I wrote there was ugly, because it was just a PoC. > > It could be a helper e.g: > > if (hugetlb_reason_allow_alloc_fallback(reason)) (or whatever) > allow_fallback_alloc = true > >>> >>> gfp_mask = htlb_modify_alloc_mask(h, gfp_mask); >>> return alloc_hugetlb_folio_nodemask(h, nid, >>> - mtc->nmask, gfp_mask); >>> + mtc->nmask, gfp_mask, >>> + allow_fallback); >> >> 'allow_fallback' can be confusing, that means it is 'allow_fallback' for a >> new temporary hugetlb allocation, but not 'allow_fallback' for an available >> hugetlb allocation in alloc_hugetlb_folio_nodemask(). > > Well, you can pick "alloc_fallback_on_alloc" which is more descriptive I > guess. Seems better. > > Bottomline line is that I do not think that choosing to allow > fallbacking or not here is spreading more logic than having the > htlb_modify_alloc_mask() here and not directly in > alloc_hugetlb_folio_nodemask(). > > As I said, code-wise looks fine, it is just that having to pass > the 'reason' all the way down and making the decision there makes > me go "meh..". Well, fair enough:) let me respin it. Thanks.