From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE885C433FE for ; Wed, 13 Apr 2022 03:51:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC01C6B0072; Tue, 12 Apr 2022 23:51:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6E5F6B0073; Tue, 12 Apr 2022 23:51:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D359B6B0074; Tue, 12 Apr 2022 23:51:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id C42696B0072 for ; Tue, 12 Apr 2022 23:51:44 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6A295183D9823 for ; Wed, 13 Apr 2022 03:51:44 +0000 (UTC) X-FDA: 79350481728.26.8D8C3B8 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id BF24340005 for ; Wed, 13 Apr 2022 03:51:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA25413D5; Tue, 12 Apr 2022 20:51:42 -0700 (PDT) Received: from [10.163.39.141] (unknown [10.163.39.141]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E7D9C3F73B; Tue, 12 Apr 2022 20:51:37 -0700 (PDT) Message-ID: Date: Wed, 13 Apr 2022 09:22:13 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH V5 7/7] mm/mmap: Drop arch_vm_get_page_pgprot() Content-Language: en-US To: Christophe Leroy , "linux-mm@kvack.org" , "akpm@linux-foundation.org" Cc: "catalin.marinas@arm.com" , Christoph Hellwig , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "sparclinux@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220412043848.80464-1-anshuman.khandual@arm.com> <20220412043848.80464-8-anshuman.khandual@arm.com> <99d110d7-6c99-c42e-e93a-a6bc7cbde8d8@csgroup.eu> From: Anshuman Khandual In-Reply-To: <99d110d7-6c99-c42e-e93a-a6bc7cbde8d8@csgroup.eu> Content-Type: text/plain; charset=UTF-8 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BF24340005 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com X-Stat-Signature: x3p6qzyzjnj4yr13mqpeup3rsgnacyd9 X-HE-Tag: 1649821903-22906 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/12/22 18:00, Christophe Leroy wrote: >=20 >=20 > Le 12/04/2022 =C3=A0 06:38, Anshuman Khandual a =C3=A9crit=C2=A0: >> There are no platforms left which use arch_vm_get_page_prot(). Just dr= op >> generic arch_vm_get_page_prot(). >> >> Cc: Andrew Morton >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org >> Reviewed-by: Catalin Marinas >> Signed-off-by: Anshuman Khandual >> --- >> include/linux/mman.h | 4 ---- >> mm/mmap.c | 3 +-- >> 2 files changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/include/linux/mman.h b/include/linux/mman.h >> index b66e91b8176c..58b3abd457a3 100644 >> --- a/include/linux/mman.h >> +++ b/include/linux/mman.h >> @@ -93,10 +93,6 @@ static inline void vm_unacct_memory(long pages) >> #define arch_calc_vm_flag_bits(flags) 0 >> #endif >> =20 >> -#ifndef arch_vm_get_page_prot >> -#define arch_vm_get_page_prot(vm_flags) __pgprot(0) >> -#endif >> - >> #ifndef arch_validate_prot >> /* >> * This is called from mprotect(). PROT_GROWSDOWN and PROT_GROWSUP = have >> diff --git a/mm/mmap.c b/mm/mmap.c >> index edf2a5e38f4d..db7f33154206 100644 >> --- a/mm/mmap.c >> +++ b/mm/mmap.c >> @@ -110,8 +110,7 @@ pgprot_t protection_map[16] __ro_after_init =3D { >> pgprot_t vm_get_page_prot(unsigned long vm_flags) >> { >> pgprot_t ret =3D __pgprot(pgprot_val(protection_map[vm_flags & >> - (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)]) | >> - pgprot_val(arch_vm_get_page_prot(vm_flags))); >> + (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)])); >> =20 >> return ret; >> } >=20 > __pgprot(pgprot_val(x)) is a no-op. >=20 > You can simply do: >=20 > return protection_map[vm_flags & > (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED); Sure, will do.