From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 131DFC5475B for ; Fri, 1 Mar 2024 09:28:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D5E16B009C; Fri, 1 Mar 2024 04:28:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 985CA6B009E; Fri, 1 Mar 2024 04:28:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 874446B00A4; Fri, 1 Mar 2024 04:28:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7934E6B009C for ; Fri, 1 Mar 2024 04:28:06 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 15A241C1169 for ; Fri, 1 Mar 2024 09:28:06 +0000 (UTC) X-FDA: 81847943772.03.9B1335E Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf04.hostedemail.com (Postfix) with ESMTP id 37B3A40009 for ; Fri, 1 Mar 2024 09:28:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Bzk6hyKa; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf04.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709285284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WRSG9n/fjCqf/LwliFcoZegthrXLhBdvs4zsOFKgJMI=; b=EpaGZK8fXoYaK8Nl+83qklLxPOPD8TUzw6IFgDyygvp/OYdyGjWsN3fMbaR6aHUrt6fsOr jofcHuzKNOG0cvqgNgtXAnerK1cTSxf02bRj+MmkofbEqwB+aADYGNDOQSJjkrmdQ4+kji B9XxAsqXejbeYB+k/K+WcRMkPF04wkU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Bzk6hyKa; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf04.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709285284; a=rsa-sha256; cv=none; b=WPj8+wUButz48vLkLUvKg+5WufDm0agyy6xz1ZWFOJQBu26cZa7idv99eH7XkRRX48Z7lD s0Aqh2vooHhuj4nfS6+y2u2E5B7eaBs5aKyUg8uIouznEaN5HsSajw8H6Ae8cOFlG0rzlM /zp6MNCmMCqLKe5kC99rl3Ndl1DVg+o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709285282; bh=L5nqEaZ564iQomLzTksYYC3TTFf26qlS+Q0ueXvuHXo=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Bzk6hyKaK3hasC6i1scAlG78eYLWjj6OIWtqJMbLwQBZVYC0FpjhFJ3p6eFWTz+RL +1ZaqmvmNpnVwn/P1/ZfVUkJFIXVw+KvF5SdqB1YX1zKcSKybkLKeDF+daeaKFP5OQ LaT6R1Efisw/JFRFEJ/y5B0tcKgYnZSCiTUnBRnT1+8iTo4j3+S/K0lgprg++fzk6x BjY0h0Y+J80SbbY6DAyJZGP4pxKXYIlykYLmUr1BUNzs10dLhN9lQbkqCe4wpTTfMt gcQYe4wM7nWQiT8FU0kaLM3cr8K5MH5rjHD9zeqk7afl3Ubk7qZxbqK63x1yVsYI08 f96PA872lvPLg== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id B96AD37810CD; Fri, 1 Mar 2024 09:28:00 +0000 (UTC) Message-ID: Date: Fri, 1 Mar 2024 14:28:27 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , ben@decadent.org.uk, shuah@kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] selftests/mm: Dont fail testsuite due to a lack of hugepages Content-Language: en-US To: Nico Pache , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240301073300.287508-1-npache@redhat.com> From: Muhammad Usama Anjum In-Reply-To: <20240301073300.287508-1-npache@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 37B3A40009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: kzgci7e5xe4dc6hyghh6kp1ofm4hizzx X-HE-Tag: 1709285283-189349 X-HE-Meta: U2FsdGVkX19+dztJEQaMjHNqQ4bxre24uoBgs4PpTCJJxAbYFVcdudADHZKoozlRbKhpVSKA/yoDM5la9PVCRc6tY0cnbUAKBsG+dXvd3z3WsRjlQMH/eCSoIBGxNG7nUCDKR9No096/APbt4d8pdJ99dfgdNTmjGH/R98RkRTaW0PqqoQTUBswG4Z3mgZiavrvRUehjERqeMXWd/RD/2VNRYsBZJNMXpqZBjdhUke2LJWaFdSE0Cd3t/qWRKWHXW+nCm5iD+1oHEqdXmxlz23NOnybTYIrMh4Q2uCPtiu8GShRVV5+q1gon++Lh66Md9RhvQbbJFyJrsRlXEEZTXxHO8u+tQs/QsX/nqsFEwux2ZhfvTS8UcB1RYKxXYHskRALdYcM2qxSGfEwGzu7UPafLyz79kAs6tt21P95WOI8zWmkFQJ4ZF3XZsgEgK5kBu2m0urFTt1zRVypX0+h7mNNcA4xteF6KI1pcFT07jjArm0s9ze/wju31rWOkRWwPAov14h4jS4a+zCEybKVpQiazdVwm5IHsgd1zktvrt3zUOH3OUX5MDU90hsNJS1nH8p/rxYQbwIWIUQm0DBqziZlOxMmBRM76bRDYU9CmjCC9R10zKYxwCUqXK5eTKTm5qUybZO5xzWJ84pQXFY89hQQPF9dol0uNdAY/6W8pXa/3rdI7K3CAe5YtRB3hFlaswmj39+nWBZtAbD3Bb1Pkji/xKhfGEB7H3dpHGYtBv4ZqftGacffUSjwQJXAEix4gfZzxYxZt2fBRlNz3aq+uHu8AcLZmJvfZJlgK69XK73oGnlne3xHtJjHMbdJluRbM4W52UEiJTM6BLJ3LVNG2Zn30FnQGihY04epibNm4fun9p/teRHaQ48QkqSXwyOpXJ9f2nGKRWSXFUVpZZLuRqIVqKGCHmVadxF1LDmXeQroEx4TnDHOSi8eQnjFpmQWIUN+uwPy0qTeXvzHcsrI XCTCcGtj mjGFFyIFotudUbWONm16le26aEbse7E3LXpzBaVZTi9p6AiFKpOoQYALjapPhUG5I2I8+aZGT5TXAKvLQQ+DbFRJtCUnLoRbL3wxrAtAhz5+/99tFjDBSwTqTLwPKX+VUwlHPvJs1THSL5igCHk/vXzHSgBGqutf2F80QV1ppDA6pQbd2DdWVG+tO7/qTgWI3TzWKIDPgKfJlnfq3OeiKnC7h6hyEoJPC8JIij84b0UJm2QIaafq6AwT/VRy7beRgabMJyCFc3pHlw3w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000028, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/1/24 12:33 PM, Nico Pache wrote: > On systems that have large core counts and large page sizes, but limited > memory, the userfaultfd test hugepage requirement is too large. > > Exiting early due to missing one test's requirements is a rather aggressive > strategy, and prevents a lot of other tests from running. Remove the > early exit to prevent this. Why don't we only skip that particular test which requires huge number of pages instead? Thus the behavior of this script would remain same. > > Fixes: ee00479d6702 ("selftests: vm: Try harder to allocate huge pages") > Signed-off-by: Nico Pache > --- > tools/testing/selftests/mm/run_vmtests.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index 246d53a5d7f28..727ea22ba408e 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -173,7 +173,6 @@ if [ -n "$freepgs" ] && [ -n "$hpgsize_KB" ]; then > if [ "$freepgs" -lt "$needpgs" ]; then > printf "Not enough huge pages available (%d < %d)\n" \ > "$freepgs" "$needpgs" > - exit 1 > fi > else > echo "no hugetlbfs support in kernel?" -- BR, Muhammad Usama Anjum