From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA72C433ED for ; Thu, 20 May 2021 10:42:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 72C0261019 for ; Thu, 20 May 2021 10:42:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72C0261019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DBF856B00AF; Thu, 20 May 2021 06:42:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5C9B6B00B0; Thu, 20 May 2021 06:42:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD5E56B00B1; Thu, 20 May 2021 06:42:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 900E66B00AF for ; Thu, 20 May 2021 06:42:42 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 29A085831 for ; Thu, 20 May 2021 10:42:42 +0000 (UTC) X-FDA: 78161270964.34.48058D9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf26.hostedemail.com (Postfix) with ESMTP id F22E840002F1 for ; Thu, 20 May 2021 10:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621507361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fzKc8otL995FMgE/dY3Fv/l/KMH2QqAEASjB2RUM+o8=; b=aRKtstYYrNQyNZT8JCZAFGc9Q4LDzGQI2juFxUxx+dEgLZojjhvRe4ZqxEfSPIIMOmcPb2 +HL2fTK6ZhWFy6GGwvZSXQVbzZr32kKwDTEqT4nzwuenNMjVO0V0l4hMfNzdN+nnoRm2Si jrAyXvwF1Lm4QVwXpbR8RIaWrnXQZUA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361--Em6im0uPJ6_cD8xY5_Pvg-1; Thu, 20 May 2021 06:42:37 -0400 X-MC-Unique: -Em6im0uPJ6_cD8xY5_Pvg-1 Received: by mail-wr1-f70.google.com with SMTP id 22-20020adf82960000b02901115ae2f734so8499041wrc.5 for ; Thu, 20 May 2021 03:42:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fzKc8otL995FMgE/dY3Fv/l/KMH2QqAEASjB2RUM+o8=; b=EwPf684aq0k3dLHUbGfh8jI90KaJHG/P05Tx6LZM+YKyh27RDeY3CuxllLqKrziV/3 GibZRiKPoUPivr4gvyOx8Y7ke4J1VOYwkjo8nO0U6jXyZJLi07KoN8VK2qeq7VOdQh3Z 7fRM4Vq1Lz5OL4TdLxpjecXXoHMSGwzxzoS083dt+dRl5ZNpBVVTJ0DKxbG8VwujNab2 RPfH5LEAlYmRmmNcCxIkMYVdZwBlek8A9+MU+AfzbmWwSvv7WKxilQCIA0gDlRZHJ1kF rqFS2+/x5gDAqKjvzy2hqt81cFIga+r7UZHWQ5YaCGXjOljmZ1yWYyCMVHYaCx7VoEOd lIYg== X-Gm-Message-State: AOAM530bOBGaXt6vOvKoboUSl8SCx55FTk7PkibKadou4aXvW6D/keSi UjuVXzU3p/OZva3bW0ASScX+D/oQw23x8EbSO7oeHbKqsgvoLaBNauDlIsqO1/0BBu3hliTv6K9 9S3V2JzVgn8o= X-Received: by 2002:a1c:2985:: with SMTP id p127mr3011281wmp.165.1621507356221; Thu, 20 May 2021 03:42:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4soDFIHP99TZ0OevVyozD5GpuTFTtbX6eNOB1PPc1CU2RzPZsFsqTr73AZN5LSDi3G/zXOQ== X-Received: by 2002:a1c:2985:: with SMTP id p127mr3011256wmp.165.1621507355912; Thu, 20 May 2021 03:42:35 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6315.dip0.t-ipconnect.de. [91.12.99.21]) by smtp.gmail.com with ESMTPSA id d9sm2749745wrx.11.2021.05.20.03.42.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 May 2021 03:42:35 -0700 (PDT) Subject: Re: [PATCH 07/14] mm/memory_hotplug: Fix kerneldoc comment for __try_online_node To: Mel Gorman , Andrew Morton Cc: Michal Hocko , Vlastimil Babka , Dan Streetman , Yang Shi , Linux-MM , LKML References: <20210520084809.8576-1-mgorman@techsingularity.net> <20210520084809.8576-8-mgorman@techsingularity.net> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Thu, 20 May 2021 12:42:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210520084809.8576-8-mgorman@techsingularity.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aRKtstYY; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: F22E840002F1 X-Stat-Signature: 8xb9xq1gr7pq4onpr1o96moozeetibcn X-HE-Tag: 1621507360-124982 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.05.21 10:48, Mel Gorman wrote: > make W=1 generates the following warning for try_online_node > > mm/memory_hotplug.c:1087: warning: expecting prototype for try_online_node(). Prototype was for __try_online_node() instead > > Commit b9ff036082cd ("mm/memory_hotplug.c: make add_memory_resource use > __try_online_node") renamed the function but did not update the associated > kerneldoc. The function is static and somewhat specialised in nature > so it's not clear it warrants being a kerneldoc by moving the comment > to try_online_node. Hence, leave the comment of the internal helper in > place but leave it out of kerneldoc and correct the function name in > the comment. > > Fixes: Commit b9ff036082cd ("mm/memory_hotplug.c: make add_memory_resource use __try_online_node") > Signed-off-by: Mel Gorman > --- > mm/memory_hotplug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 70620d0dd923..e3266be1d020 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1072,8 +1072,8 @@ static void rollback_node_hotadd(int nid) > } > > > -/** > - * try_online_node - online a node if offlined > +/* > + * __try_online_node - online a node if offlined > * @nid: the node ID > * @set_node_online: Whether we want to online the node > * called by cpu_up() to online a node without onlined memory. > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb