linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: jane.chu@oracle.com
To: "David Hildenbrand (Red Hat)" <david@kernel.org>,
	muchun.song@linux.dev, osalvador@suse.de, linmiaohe@huawei.com,
	jiaqiyan@google.com, william.roche@oracle.com,
	rientjes@google.com, akpm@linux-foundation.org,
	lorenzo.stoakes@oracle.com, Liam.Howlett@Oracle.com,
	rppt@kernel.org, surenb@google.com, mhocko@suse.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memory-failure: teach kill_accessing_process to accept hugetlb tail page pfn
Date: Mon, 22 Dec 2025 10:42:02 -0800	[thread overview]
Message-ID: <d441011b-fe8e-46d3-a67b-6971a380b3cd@oracle.com> (raw)
In-Reply-To: <8b8dd99e-78b8-4786-a175-6131eb6b7c3e@kernel.org>


On 12/21/2025 12:49 AM, David Hildenbrand (Red Hat) wrote:
> On 12/19/25 07:28, Jane Chu wrote:
>> When a hugetlb folio is being poisoned again, 
>> try_memory_failure_hugetlb()
>> passed head pfn to kill_accessing_process(), that is not right.
>> The precise pfn of the poisoned page should be used in order to
>> determine the precise vaddr as the SIGBUS payload.
> 
> I don't think so? IIRC, for hugetlb folios we always reported the head 
> PFN. And user space must assume that the whole thing is poisoned and 
> will go away.
> 
> I recall that older QEMU even depended on that behavior, for example.
> 

What happens if non-head PFN of hugetlb is indicated in a SIGBUG to 
QEMU?  Because, the regular path, the path via hwpoison_user_mappings() 
already behave this way.

I'm not familiar with QEMU. AFAIK, the need for this patch came from our 
VM/QEMU team.

thanks,
-jane



      reply	other threads:[~2025-12-22 18:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19  6:28 Jane Chu
2025-12-19  8:01 ` Miaohe Lin
2025-12-19  8:06   ` jane.chu
2025-12-22  3:01     ` Miaohe Lin
2025-12-22 20:29       ` jane.chu
2025-12-19 17:27 ` Liam R. Howlett
2025-12-19 17:29   ` jane.chu
2025-12-20 23:13 ` Andrew Morton
2025-12-22 20:32   ` jane.chu
2025-12-23  0:36   ` jane.chu
2025-12-21  8:49 ` David Hildenbrand (Red Hat)
2025-12-22 18:42   ` jane.chu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d441011b-fe8e-46d3-a67b-6971a380b3cd@oracle.com \
    --to=jane.chu@oracle.com \
    --cc=Liam.Howlett@Oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=jiaqiyan@google.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    --cc=rientjes@google.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=william.roche@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox