From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D02E67480 for ; Thu, 31 Oct 2024 20:59:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30C996B0083; Thu, 31 Oct 2024 16:59:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BE616B0085; Thu, 31 Oct 2024 16:59:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AB356B0088; Thu, 31 Oct 2024 16:59:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F08896B0083 for ; Thu, 31 Oct 2024 16:59:01 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AAFED120BB2 for ; Thu, 31 Oct 2024 20:59:01 +0000 (UTC) X-FDA: 82735111788.02.2E50C35 Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) by imf26.hostedemail.com (Postfix) with ESMTP id 120C1140017 for ; Thu, 31 Oct 2024 20:58:38 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=KQItnnFo; dmarc=pass (policy=reject) header.from=acm.org; spf=pass (imf26.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730408283; a=rsa-sha256; cv=none; b=D+wxWZyN8tVxmrSBbnEckM3GqbEuoxEQ9r7Zc9j92f4hKtky5XG/AdLo5foZxgyVExwEQ4 gT0rzYS4arNMpyfgA0rKu5HIUP2PASTYuPVD//eNWO93mxZ4xBGn/uoIsDMIQzjtF2c2he 47QuG+05ShtvXBtJfRLHr1EAlECYfRE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=KQItnnFo; dmarc=pass (policy=reject) header.from=acm.org; spf=pass (imf26.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730408283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZlDdWjIwcF/8pUBLz0z5LqqxMf6+H+v/mtLue+A0j/A=; b=nlkp+CO6tA3hUstP5TBdpVeDBWBHoQubigqhmmgQZTsCEgw3GYQ20jA1OIQtE0pUktB6p5 lhSo1JHl9yPfEvWz+tH86Svaf2GkK67UquWBuVqndqLY+O/qQ4rq6Xzgy5cHXZRTmdBl9E O63Rmu5xAc8yvSSG8dPq14rA6mQh2Yk= Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4XfbvQ5NP0zlgMVV; Thu, 31 Oct 2024 20:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1730408329; x=1733000330; bh=ZlDdWjIwcF/8pUBLz0z5Lqqx Mf6+H+v/mtLue+A0j/A=; b=KQItnnFo7mG7FWlSn3t8mhT5t9clJf67jiW5lKnA ZppzqrwKZgP8zNGovmxHxm4CgKw1QIgMkZL2m/uWgA9EFnGppkBxNloFeY2nBD1s ZZ07cMTdtM3ysyJ9elPwZuRYvrT0OrA/gN1i6yMy2myCM+hqyS+zYZ+UjaGfu7R2 fngVCGsv9pCcGdCAX0ZD8Ou0QW/I9uJWEEMJX7Iy7N4DsjR03B2mVlP4fjVQ0dvh UJP2d9IJ4Ng9+UjXBh5e2JDMfcPA0PjQLHmFQzdvAtVj63xiEvvV2PLxyQOlpYxj pR/9i5KIYfJjjDVF135v4xvdMr5gQhkX72qeykrLw4SqHQ== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id fkPnSCZ1Z4-b; Thu, 31 Oct 2024 20:58:49 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4Xfbv36gp4zlgTWK; Thu, 31 Oct 2024 20:58:39 +0000 (UTC) Message-ID: Date: Thu, 31 Oct 2024 13:58:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/7] block: don't merge different kinds of P2P transfers in a single bio To: Leon Romanovsky , Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <34d44537a65aba6ede215a8ad882aeee028b423a.1730037261.git.leon@kernel.org> Content-Language: en-US From: Bart Van Assche In-Reply-To: <34d44537a65aba6ede215a8ad882aeee028b423a.1730037261.git.leon@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 120C1140017 X-Rspamd-Server: rspam11 X-Stat-Signature: s4ar11nztssmgcjdfyz99wu41roxijc6 X-HE-Tag: 1730408318-713798 X-HE-Meta: U2FsdGVkX195r5rUF8dVlfb7nShd7zHWWMVqVI97dfMrC/1mp1kxjGDDE1h7H7kXRq7XONqGKls6N5TcUI3p47/d3K04dC8hTzeHFlNe5tDAOIyL8RWOiqlmLHeQsUHYoVXIHWBowqDJyeQ9ntqcvNX7MLMLWnODczJOJft5kBiFXqLzTuFqiJKphqdZyIixlj288E2BAi8GLXZAHQuMqrraPaYgnB5SGrAQRkKZB/odvvShbfU70n4Y+TsgbOYDGdgFdYjBlAp3iNAR0YXAuy3Nh9gajvuRgiDgnz7UQ+ZPtSYSXLXMSyJFS++5k+8Q9G5doGb35wanXQZ9lVUzNeS3XbgAjXP4f/K9MoJd2BKt9nP7R00EDhCg9yW6eT+IMdrMu8gy0l/4E642hHpGNlAaD6NJHjkB8xgRg5loKEP8MXOeRiyexlTB7rrcKXl90Z4QdOj924tIAwBv61s/2XF3GtA9xqBU8x4wYCQSjL/3zvRpvgVupugmsx4SMwXORsBaowAngvZFOprNknDowizTDzAUK05fyPwd4YASxCsLWGNdXlnNoXwnqWr2rCLrfbRcaVAAThFHPqRBF77OaaY2g4GOvmKMIqL/DMg3c73fiPm4K4/cRua5geY23Wc18Q8Zutg9BYdM9QHoNWMMSgi3M0jEP/yQsXgF+gHwAO0Itdi8HgDAGjkgwdmBznH5I7py4vDLk+YZMhCi3Y8dHjFXSKspQSwkpXIQdETvCC3RYA+zrAtgc0k8XDRcLVxjl4rdMRHWeQugvwy/Dd8Wib0rlZPQ5z1uzgmWZRtQFcTdgEibEs4D0F5f9a6ZxlwyAvwRk4To1+XUmhbcrOMLKBJsocLBMgQv+VTTpoYvSzQaSvvI57AEW6CuIVK9QQl8EInXv/86uT5RIRoFFisHEdm7eEN/IC5vRwPkQUErKgLw0UmKM8Zq/Gp/UUKVTl99KB4xT4afoRBhj3TB6d2 hu46apPX d5eS4l3qHe8U/eXQatkqP9hYI731sOss608le2Hb9jNaUhMlu7Ky/ci+lOgP2nRdbClg3P3bhkrrqS8J0hxNC8AdnBgFcXdVU51Zco0yBcmgVRfyyB6ydIUMyUCQr0WBFKErRauWJzQcXHl6/wXifYR2zY4q5HpFc8j5+wT4ztWuUAcZEeb+m8YD6MtQTucpHLOg2NG2nbWQ7UWQDXbpFcfG0c943eWjPfBL+ydfly4RPjdM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/24 7:21 AM, Leon Romanovsky wrote: > + /* > + * When doing ZONE_DEVICE-based P2P transfers, all pages in a > + * bio must be P2P pages from the same device. > + */ > + if ((bio->bi_opf & REQ_P2PDMA) && > + !zone_device_pages_have_same_pgmap(bv->bv_page, page)) > + return 0; It's probably too late to change the "zone_device_" prefix into something that cannot be confused with a reference to zoned block devices? Thanks, Bart.