From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B6D4C4167B for ; Fri, 1 Dec 2023 20:18:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 999E36B04C1; Fri, 1 Dec 2023 15:18:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 949B16B04C4; Fri, 1 Dec 2023 15:18:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EA046B04C6; Fri, 1 Dec 2023 15:18:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 682A06B04C1 for ; Fri, 1 Dec 2023 15:18:29 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3C04B1402EF for ; Fri, 1 Dec 2023 20:18:29 +0000 (UTC) X-FDA: 81519361938.11.F87E543 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id EE1CEC0012 for ; Fri, 1 Dec 2023 20:18:26 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aF3b9wkP; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701461907; a=rsa-sha256; cv=none; b=n+o6NCrZJjUxw4LU3T18fnOqeIzsKM8CnR8bZApCexiqQTozKB9T12vsykn8yQHDkBkXAi D9p0XXDB5bjcrC9fzAcXFAUgzk4qVS+13h/PWyXI7sNoMaxzA9YhraL2bLGklSoq7KyZW7 nA0HLPMPpGpK4ay6Pl3CdBJDJwsywv4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aF3b9wkP; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701461907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qD5gq9we1e/BtziJPqZE+7iSPDN3dSftBDjUKyOY1uU=; b=5Ur043nZurauDo/b4dr0jUKsDFjNAU/h/r/JgPUWWBjnXPPTI0RNZpWSZ35ua9+2uHzu/y GLZ43mwP3Nqv85vh8Hgl6rVYVs32nDH/9pWfHfKJt+NwgO0gZHFhzw3O+nEkVmo/5M1uHy BktLNIGISlEYp5MJfuU1tsZMGFt6o6E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701461906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qD5gq9we1e/BtziJPqZE+7iSPDN3dSftBDjUKyOY1uU=; b=aF3b9wkPfm+z+XfiyyCKItk/cX2sWTpA+x40/pcOrCJKbz8+jnSNNmWNflKQOoKmmLaYZW uxj1+EqxZlycs/bhfXbG473gF+VbeajXVCtf39cdYPDUwj5+R9INPNhYF8WT7ZEp2X4AkP Wro6G6Ma3Uzu/FXWyUAjlMJmWd4yuAc= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-YWvwqfJMPr2r03cpFrJ2Xw-1; Fri, 01 Dec 2023 15:18:24 -0500 X-MC-Unique: YWvwqfJMPr2r03cpFrJ2Xw-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-50bcd1578c8so2775104e87.2 for ; Fri, 01 Dec 2023 12:18:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701461902; x=1702066702; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qD5gq9we1e/BtziJPqZE+7iSPDN3dSftBDjUKyOY1uU=; b=oIb6vwx7FPUvSW+K7qxRvaUtGwWUi11CbT4QQ3xQ08tDa+CdwUO2IoAvB+ZLGc40RK d3MmYNiKWOuse/4Gd1iJzieDsLN/jS3TZZTpmvtF9MGNevTn4sjrmENDMwQ6l581pNHE tJg2w4RjYw1FUFY9l6AzIn+ehworLbkpiNj2WCNyV84MQGVxjEJ1VtSoCbdM5L5kvGev 1Ogk9rWMMvYrw6CS0pGiMBA6um7RdJgYXF8VI78e+fuNue1DaNQQiuLiE8YpNTHEM2YX iQ2VQsuP6YW3EfQd2Risxwpn5/5uCmfzhI8iycHa5mLjVFng1wnG+A1Ex7D8lReFMRgi d4kA== X-Gm-Message-State: AOJu0Yz7W6jPBoSoQHuScMr2shSsXntuJc6xId871nRKHdlc65zq8k10 Jz6rnwozhoKHYfaLf4lzwEyTBC0837L+lMJzz+WRv3QdsgtfJPQRH/IwTdSEN73N1uyGZMnjC5s 8/x3U4MOU/z8= X-Received: by 2002:ac2:5303:0:b0:509:1033:c53e with SMTP id c3-20020ac25303000000b005091033c53emr1118388lfh.62.1701461902597; Fri, 01 Dec 2023 12:18:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IECFshDnF8a/QJJWL4RQoDJ51tSCDGCFR3aJ3lkdtRRqT2DymMlxudwcPoyvclc+AeuCKKcEw== X-Received: by 2002:ac2:5303:0:b0:509:1033:c53e with SMTP id c3-20020ac25303000000b005091033c53emr1118384lfh.62.1701461902171; Fri, 01 Dec 2023 12:18:22 -0800 (PST) Received: from ?IPV6:2003:d8:2f28:7800:30d7:645a:7306:e437? (p200300d82f28780030d7645a7306e437.dip0.t-ipconnect.de. [2003:d8:2f28:7800:30d7:645a:7306:e437]) by smtp.gmail.com with ESMTPSA id o18-20020a05600c511200b004064e3b94afsm10022155wms.4.2023.12.01.12.18.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Dec 2023 12:18:21 -0800 (PST) Message-ID: Date: Fri, 1 Dec 2023 21:18:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/rmap: Fix misplaced parenthesis of a likely() To: Steven Rostedt Cc: LKML , linux-mm@kvack.org, Vlastimil Babka , Andrew Morton References: <20231201145936.5ddfdb50@gandalf.local.home> <2d691c11-fa97-4f56-a4c4-c7f466c81d3a@redhat.com> <20231201151535.06c7aaaf@gandalf.local.home> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231201151535.06c7aaaf@gandalf.local.home> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EE1CEC0012 X-Stat-Signature: nxh4pqqj98738kez3zh7pdhxynb3spca X-Rspam-User: X-HE-Tag: 1701461906-772474 X-HE-Meta: U2FsdGVkX18G9FfVMTGz89boRQ+ZUX162vtQ+MxvoJzso4497dX0XxZGbO3/16+5mWZZJDKMbjASHLF09BPEKGcTYbM4z/bWGSCeIFPO5GDR4c1uu5/RajH0QsxjKKAqaFX7LFofjCyqf8pl25QsqwC2gFgYUgAtHoicGBjDqrs+pSXkph9vPiR0TVurdxmrNzaeS/bs498144yi0euTNK639QFmxAAsZ8w7ZLHN0+Q/Hvi86Ibv1AuDBsuzyPA6JOqWL9BoZgGSHb49P7mM1BQT0Oe+ygO/nzEKQpWX++hu7o2V60An5Ln2m/C1dFh5dqQKUr5rpbyXKmMscID5VLRytAQACkMccpje4xOPZa3YhMou4AXE45tj1P4rDVsnLW1KS8SDjLzDbQTTpV4N5QLcmLSq660aMMRk3np4oiJnl0tneoxrANfqPQ2++FV1b0eYBCxIc3epIQ/laCHp5UdaUCUWzpuBPa3CjXaJTV74l3Mw2z7cHLWEWvHtZjRNP8JDK3AYi6j3Lb9pfFOSNpeSIXOQmoKud9wWSCwwDvbi+GpF/L4cwzfswTct5pbJk+KnKIJ8zyWGVFkwDE/fVsTK5wiS75/wGv9MfRvizcxUCeJ0koVUYqNuPUMZeJBpNlZ6imKdqaLF7RbKJ6ZlqiawLmmO0f9pB98KL+hElXkM0IQzhRg+jXndG265FIax58Nvf2CXkn5d/uGKf20/VKtIHnrHVcCQNaeWHnEYxnO8nTHCOpiCADeug9CDR7VVdnz5exep27Fpr8HReMVqoz+6tp+p9FBH6MdJttnk4vmQIe4y3Rk+ykmP2aWK5xbK0kMM7paALa7okZK/5I2MLu1177Qjrevqrg1uqf2vli3NvBeY9L5Mm4glxsKJhuarGVs9YaUgdWOSUn0GOnuKo3qmsXTeGJrlxRJTzPeH1Y31ZIEGFeKWj0dz2btG9v9kGWzbRIjak/fxxBhHJO3 dg/xLeIQ A6U7M1zvjsZLd4Es3YWEiwwwRqphebUyzxI7aUa/Pv8vWNIhSdNCUK/7+oWbeKthd/G4eh8+7GPQgDnhc03bmzinYVua2VtndEQQLjS8JEsZpST/XtFpJ0tgaN3plU2Kp+SBPiNyzbQfCjfWUp9zovR2ONKeJz42IX0qrqnyZm/Rj7X/eZfujA/mhGAyl8/zv3CArUwhJG+PRgwvaNqYLEp4Fl118mnWNMVUVZVDEbqhrQVwXQ34whP7wmHQ418tRD1OtbDlnFlT+Eekjcsy5oifTv0R/KWqpMcqBICXGQmdQi7HG0NMp9/9yY/szjsjez8nT9qEUo2o4IAPVHVMTLMYnAzbR7s0oMxTceJKIZQCOjbxUGjom462x5Lwh5NJ/rQnFRO8xttbkfjQrUWqMpAYV2d7YvL8mNPDN4IKQqUCEzJo5ecn2J0OXqPDKyZ9j5D0htcr231fZ1jM32A9Tr40qMu/odT5WUdjMNUgOs2W7nBcOEOpTTeT06Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.12.23 21:15, Steven Rostedt wrote: > On Fri, 1 Dec 2023 21:06:22 +0100 > David Hildenbrand wrote: > >> But >> >>> Cc: stable@vger.kernel.org >> >> stable, really? Why? >> >>> Fixes:fb3d824d1a46c ("mm/rmap: split page_dup_rmap() into page_dup_file_rmap() and page_try_dup_anon_rmap()") >> >> and does it even fix a real bug? > > As a performance person, who measures likely and unlikely results (the > ftrace ring buffer was sped up by over 50% with strategically placed > likely/unlikely annotation). I find this to be a real bug, and something I > would want backported to the kernels we maintain in ChromeOS (which uses > upstream stable kernels). Okay, I don't care that much about a "Fixes" annotation. But I am *pretty* sure that this is not stable material, looking once again at the stable rules. Anyhow, thanks for catching this! -- Cheers, David / dhildenb