From: David Hildenbrand <david@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/rmap: Fix misplaced parenthesis of a likely()
Date: Fri, 1 Dec 2023 21:18:21 +0100 [thread overview]
Message-ID: <d426976d-4446-40a0-9088-82d9f4ebb950@redhat.com> (raw)
In-Reply-To: <20231201151535.06c7aaaf@gandalf.local.home>
On 01.12.23 21:15, Steven Rostedt wrote:
> On Fri, 1 Dec 2023 21:06:22 +0100
> David Hildenbrand <david@redhat.com> wrote:
>
>> But
>>
>>> Cc: stable@vger.kernel.org
>>
>> stable, really? Why?
>>
>>> Fixes:fb3d824d1a46c ("mm/rmap: split page_dup_rmap() into page_dup_file_rmap() and page_try_dup_anon_rmap()")
>>
>> and does it even fix a real bug?
>
> As a performance person, who measures likely and unlikely results (the
> ftrace ring buffer was sped up by over 50% with strategically placed
> likely/unlikely annotation). I find this to be a real bug, and something I
> would want backported to the kernels we maintain in ChromeOS (which uses
> upstream stable kernels).
Okay, I don't care that much about a "Fixes" annotation.
But I am *pretty* sure that this is not stable material, looking once
again at the stable rules.
Anyhow, thanks for catching this!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-12-01 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 19:59 Steven Rostedt
2023-12-01 20:06 ` David Hildenbrand
2023-12-01 20:15 ` Steven Rostedt
2023-12-01 20:18 ` David Hildenbrand [this message]
2023-12-04 15:28 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d426976d-4446-40a0-9088-82d9f4ebb950@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox