From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1DA3CF6491 for ; Mon, 30 Sep 2024 08:47:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 629338001D; Mon, 30 Sep 2024 04:47:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D91B80017; Mon, 30 Sep 2024 04:47:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 404B98001D; Mon, 30 Sep 2024 04:47:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 22A3880017 for ; Mon, 30 Sep 2024 04:47:34 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9274A416E6 for ; Mon, 30 Sep 2024 08:47:33 +0000 (UTC) X-FDA: 82620775986.08.24BAEB7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id 2DDC8A000F for ; Mon, 30 Sep 2024 08:47:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UUwHR4aM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jj+K4dpe; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UUwHR4aM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jj+K4dpe; dmarc=none; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727686013; a=rsa-sha256; cv=none; b=FGZNZijVgWg9b05WWujWNiohMSa+s7rlZl8KtrfaqZGuZOt1xGRgqGqRRhwn60XAZjMd0O UOTH+RcqJD2t66H/+L2nt5MNe0WjKho88lLB7ssN5QqVjIgSewKSD57Z/pawPGz3/Qdk1z yBN9SC/RP9z7D9rutvraG+bqcYdm4ZM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UUwHR4aM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jj+K4dpe; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UUwHR4aM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jj+K4dpe; dmarc=none; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727686013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7zXY/Cj2mSI/UmuMlsXE2MqaHNmLVHdLxVvW5hpvAls=; b=qcLYU7ZqZrFOZWdC12r78mF6yaFGtzmX7GtOU7WI6SFmC6KFCSOgwlVxt2R7g3fN8HOdGJ POA6NWFzNZrOp+ps1OeRKoH1Yrm+Hy2gjfkLfI6nEiwQiypkuMAYNoBGrxhmDSVVadYdtR y4HHmw1FD+jc7aGBxqAQQOq56SzdWak= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6CB2D219DE; Mon, 30 Sep 2024 08:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727686049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7zXY/Cj2mSI/UmuMlsXE2MqaHNmLVHdLxVvW5hpvAls=; b=UUwHR4aM9u8+NBSBg0q5gO1LyYMh/jsgjQAHf/ji4G4+e6yWdEt1mM83f2jWOErDnWCeYo Gl01jYMr/fbV7l5l8YFGBkm2ybXAjPT7oTKTg0kvMefiOwwWzeVgE9p58YRGkiyNztTE4k AXxHuU4NwSOEh+mlLTeWSugjb7Gk4d0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727686049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7zXY/Cj2mSI/UmuMlsXE2MqaHNmLVHdLxVvW5hpvAls=; b=jj+K4dpeucr4orWLTC5CLhqACeli1Pq2c42s+4B5YwFJz5LJV5K5ha9tYMfoKSZSS9Do4p iMvI9QZ5EEY6V0Bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727686049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7zXY/Cj2mSI/UmuMlsXE2MqaHNmLVHdLxVvW5hpvAls=; b=UUwHR4aM9u8+NBSBg0q5gO1LyYMh/jsgjQAHf/ji4G4+e6yWdEt1mM83f2jWOErDnWCeYo Gl01jYMr/fbV7l5l8YFGBkm2ybXAjPT7oTKTg0kvMefiOwwWzeVgE9p58YRGkiyNztTE4k AXxHuU4NwSOEh+mlLTeWSugjb7Gk4d0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727686049; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7zXY/Cj2mSI/UmuMlsXE2MqaHNmLVHdLxVvW5hpvAls=; b=jj+K4dpeucr4orWLTC5CLhqACeli1Pq2c42s+4B5YwFJz5LJV5K5ha9tYMfoKSZSS9Do4p iMvI9QZ5EEY6V0Bw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 32A1F136CB; Mon, 30 Sep 2024 08:47:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FML4C6Fl+mY/IgAAD6G6ig (envelope-from ); Mon, 30 Sep 2024 08:47:29 +0000 Message-ID: Date: Mon, 30 Sep 2024 10:47:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] kunit, slub: add test_kfree_rcu() and test_leak_destroy() Content-Language: en-US From: Vlastimil Babka To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Guenter Roeck Cc: KUnit Development , Brendan Higgins , David Gow , "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Christoph Lameter , David Rientjes , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Julia Lawall , Jakub Kicinski , "Jason A. Donenfeld" , "Uladzislau Rezki (Sony)" , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Jann Horn , Mateusz Guzik References: <20240807-b4-slab-kfree_rcu-destroy-v2-0-ea79102f428c@suse.cz> <20240807-b4-slab-kfree_rcu-destroy-v2-7-ea79102f428c@suse.cz> <6fcb1252-7990-4f0d-8027-5e83f0fb9409@roeck-us.net> <07d5a214-a6c2-4444-8122-0a7b1cdd711f@suse.cz> <73f9e6d7-f5c0-4cdc-a9c4-dde3e2fb057c@roeck-us.net> <474b0519-b354-4370-84ac-411fd3d6d14b@suse.cz> Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 2DDC8A000F X-Rspamd-Server: rspam01 X-Stat-Signature: hj6t63gtntbxuypokiwj3nebbgfq9f54 X-HE-Tag: 1727686050-38907 X-HE-Meta: U2FsdGVkX1/H8YzJEBSLL/yBWGDxrmxmIbM1Cw2yviSvs+DT/yZEX3yyVVXV1PVUQ3UupQy2s3xCzaZ/0sCDkbifnoUfx0guozAcZC8hxSK8F117XnkNKZ7qtZ6khVRJUkwR76hiIRDYfQituJQvHAhxZlOa3y5y8mxKg3kFPu3wNn5c89PsF1wsUVl2hD7H/O1Cu5bQWP5sFG78M5Zob67EBmN4TaIuRkjLf67pcMQkxId7JDZYXeGxQpcFdr8uEZ2L5h3Y9/8RW43tyYANVZDcFjFmU5nHo7VIidMMEbXfoHon9ZZr0m6xPtizWfvxLEJw/hnQ3XwbiK14A3LshcImcyDjX5T4uOFmKA/heMPyIrv1ZSEjOVh0P+LGT4Tu2RneA+Ihv6eRIWQ3J2b7UIBw3HgMYfcOfBMndtOFqF+RPd6tngTFStxVpLKsGsRJ5RPuPa3KOSZknrns5TwGAwKmdOYlNmiPcSSST/ZMTzTEzjTzJz8jAPzHtbfc5xFqoXRTZb7b9jZPgqWTbgdiGdrSOuzO3PTTLUihlkYSIjcu0cEPZYAkSdFYcJMmTQQQPc5n3Qv+7I0mP0QgAHnqotI2UF2alObHiyFD8FyUYzDKyBJS1wcGM1wfKtqaYtTJmrcXcNMZQto8ZZWMSWawBG5vo0m53EE+AB79aBoilNNf9J/qMvKKhwfsj+oNwA7pxFoBVVW90SOYyPMF9zOe4nGv+DY3hj4+K/G09f5ed6Dy0oCQby7muNp6Z/wEOEmAbmZq3ztT39o4BYZQN25Wv6gIj4v/HEAGR4h0EI3VYmhJF5zXya0vz462+wbSwjzwkoLAAOMyCEq9i3OfFuFE1JAmH/FX31fti0T7UF+WmBNCco2gvqb75LVpbR3MHeE91m3AUQVpyu2z3R7skYniEki2raRPNXT0mhqrTrF2UT8Zo/9ga/s9IJf3RCziiPvk6MOVUVYBvtYxmXGc224 wGQfLA09 siUJ86AxEE4ljUFBIhLJLiDd5yP/hT2Domf9L6VszDIYogYkyg4Uage+0RG4CVlvja6GoNn8IrW4n47lqG2ZVNUtMu19c9FLBIQtK8zgC23F8cJuHDG0jhV0YNIS0032UmdI9ddlJWalYKXEYINmsOEDzd3SsjLPMKWHQUxTFs6JDpLGRaJ8VZDzn2tpwHrUeHU8jJQoF6/Llp50bA+HBjbjcP9hfmUmY6GnIvLeJPPX3O8sHyJjRAGO2QNbs9b53anURQbZM44HC3Z9G+SGeP9nVQTe2965+phvos4bH1H/YkYnXKCLNeOVryS9+hWTAMOw9NtZFoeLZOy/ADY5lWWqwYJPgQYk2RAYgOiAYZpiw3GYILhjZqmhPKVtnULZl1Q1rgjc0NWaiD6k+EWT2sM5Bn8W3MUnru29U79kcw7Z/7sc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/26/24 14:54, Vlastimil Babka wrote: > On 9/25/24 14:56, Hyeonggon Yoo wrote: >> >> I don't think this was a noise :) IMO some people want to see WARNING >> during testing to catch errors, >> but not for the slub_kunit test case. I think a proper approach here >> would be suppressing >> warnings while running slub_kunit test cases, but print WARNING when >> it is not running slub_kunit test cases. >> >> That would require some work changing the slub error reporting logic >> to print WARNING on certain errors. >> Any opinions, Vlastimil? > > Yes, we should suppress the existing warning on kmem_cache_destroy() in Done here: https://lore.kernel.org/all/20240930-b4-slub-kunit-fix-v1-0-32ca9dbbbc11@suse.cz/ > kunit test context, and separately we can change pr_err() to WARN() as long > as they are still suppressed in kunit test context. Can be done later separately as it would be out of the scope for a rcX fix. >> Thanks, >> Hyeonggon >