From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D51C433EF for ; Wed, 24 Nov 2021 18:04:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5AB6B6B0078; Wed, 24 Nov 2021 13:04:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5338D6B007B; Wed, 24 Nov 2021 13:04:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D6056B007D; Wed, 24 Nov 2021 13:04:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id 2BAAD6B0078 for ; Wed, 24 Nov 2021 13:04:16 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E0E51181FA8C5 for ; Wed, 24 Nov 2021 18:04:05 +0000 (UTC) X-FDA: 78844597650.04.269FF98 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf27.hostedemail.com (Postfix) with ESMTP id 2B66A70000B6 for ; Wed, 24 Nov 2021 18:04:04 +0000 (UTC) Received: by mail-wm1-f48.google.com with SMTP id d72-20020a1c1d4b000000b00331140f3dc8so2804296wmd.1 for ; Wed, 24 Nov 2021 10:04:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=12nEyDPdQY104trlboJVHkikF9Dqv57os2czAFrCZIo=; b=EWT891/xnPr3AzkA9NCXrBzT4jMG2SI+P3YiQtSDLMIEZUC6FrUGvjHQBS9HI1IO1T S2EZ+hBOhOjtt1aPKTckeilQNma4fksOS64j/jIW0u1ZLIKbq5nMr0QCj6M2HozMOkyL wptA2QOnzWIa4WA24+d97sxi6mQfaI0ice0A2+C/BJnFA+J8m7RhA63AnDQ63xywsYjV fItXa3a2AxsR1lnqnmaiYQZ8GCJzocQqOx7dfareXf2uJHb4zwC65fJGfhBT+IYnMjsu cs6oMKATYxfR/f4OVrVrNnCfuNQUk/LPM1gYGpTO2jZ6NR9xb6J5PNC5GQE4CGRacn9f lOIQ== X-Gm-Message-State: AOAM531w4ythIHVSr1JycaGuBt3cCx+cUw1lyvRM0D3jmsPExP1Y1sLV p1BSHGI9n58E6ASg7632kpA= X-Google-Smtp-Source: ABdhPJw1n+UVyU6j0GU6WvHoGyUBZQxkTlsL7kk+SxeJSHAJbtKfJomtiuBkh6LclpXUFjH5xvacGA== X-Received: by 2002:a05:600c:202:: with SMTP id 2mr18093671wmi.134.1637777044293; Wed, 24 Nov 2021 10:04:04 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id y7sm472211wrw.55.2021.11.24.10.04.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 10:04:03 -0800 (PST) Message-ID: Date: Wed, 24 Nov 2021 19:04:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] kasan: distinguish kasan report from generic BUG() Content-Language: en-US To: Jiri Kosina , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrew Morton Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Jiri Slaby In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2B66A70000B6 X-Stat-Signature: j59ptu5k76r6mrzpo197wdgqxt9oqz9f Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=jirislaby@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-HE-Tag: 1637777044-697344 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24. 11. 21, 18:41, Jiri Kosina wrote: > From: Jiri Kosina > > The typical KASAN report always begins with > > BUG: KASAN: .... > > in kernel log. That 'BUG:' prefix creates a false impression that it's an > actual BUG() codepath being executed, and as such things like > 'panic_on_oops' etc. would work on it as expected; but that's obviously > not the case. > > Switch the order of prefixes to make this distinction clear and avoid > confusion. Thinking about it more in the scope of panic_on_oops above: wouldn't it make more sense to emit "KASAN: WARNING:" instead? All that provided the fact the code explicitly does "if (panic_on_warn) { panic(); }"? > Signed-off-by: Jiri Kosina > --- > mm/kasan/report.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 0bc10f452f7e..ead714c844e9 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -86,7 +86,7 @@ __setup("kasan_multi_shot", kasan_set_multi_shot); > > static void print_error_description(struct kasan_access_info *info) > { > - pr_err("BUG: KASAN: %s in %pS\n", > + pr_err("KASAN: BUG: %s in %pS\n", > kasan_get_bug_type(info), (void *)info->ip); > if (info->access_size) > pr_err("%s of size %zu at addr %px by task %s/%d\n", > @@ -366,7 +366,7 @@ void kasan_report_invalid_free(void *object, unsigned long ip) > #endif /* IS_ENABLED(CONFIG_KUNIT) */ > > start_report(&flags); > - pr_err("BUG: KASAN: double-free or invalid-free in %pS\n", (void *)ip); > + pr_err("KASAN: BUG: double-free or invalid-free in %pS\n", (void *)ip); > kasan_print_tags(tag, object); > pr_err("\n"); > print_address_description(object, tag); > @@ -386,7 +386,7 @@ void kasan_report_async(void) > #endif /* IS_ENABLED(CONFIG_KUNIT) */ > > start_report(&flags); > - pr_err("BUG: KASAN: invalid-access\n"); > + pr_err("KASAN: BUG: invalid-access\n"); > pr_err("Asynchronous mode enabled: no access details available\n"); > pr_err("\n"); > dump_stack_lvl(KERN_ERR); > > -- js suse labs