From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B925C61DB2 for ; Fri, 13 Jun 2025 08:31:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCAAF6B0089; Fri, 13 Jun 2025 04:31:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA22A6B008A; Fri, 13 Jun 2025 04:31:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB7416B008C; Fri, 13 Jun 2025 04:31:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 931DC6B0089 for ; Fri, 13 Jun 2025 04:31:51 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 367C816152C for ; Fri, 13 Jun 2025 08:31:51 +0000 (UTC) X-FDA: 83549709222.23.4BB6927 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf16.hostedemail.com (Postfix) with ESMTP id C487C180003 for ; Fri, 13 Jun 2025 08:31:47 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=D5HWdmk3; spf=pass (imf16.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749803509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/zpxuRuJmPn3ahp7hwRkm7xFO27FEKZTXq9h+P0KHC8=; b=RGt/N1g13dSl1shj3PeTmdyk6KTPgr10VzXzeXUS5FAVVX3Ei8/cnQ/qbKaiszT6oMPeyK vKZOH7P8tfJSmInXVMww2YJq2vsJqZsH+Wxdq8zZjQq+d1pZ1EGCB6hkyM1g9Hfxz+WKcH 2nX7r1C3LrGCS9NsVNqPaPUm0YRKNWE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=D5HWdmk3; spf=pass (imf16.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749803509; a=rsa-sha256; cv=none; b=uOxx6Avbui8kbPhUpuEtjryCz9lDNR62nTTxSmpQSovApaAwW+kYTVbSRUYGI4l8csmUY7 7eAp8oP/nW4xoYEVaBlXU/0CzTPfr7vriktcOkX1v+CAV/lnraWb4Cc1a2irvkS9iUa46k uJOZNAIGap2u+32DdiGOP4EUOMJsJ1I= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1749803503; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=/zpxuRuJmPn3ahp7hwRkm7xFO27FEKZTXq9h+P0KHC8=; b=D5HWdmk3Q8/oZS99AL0uLPc1XxlmCrNcJMFSln5RIdxWLol4ja2DRW3kSf25bBH+vL5gPWLUvnOffL2RDXREIBfc+rrWa/oWffPlEConRTOBXs0zTUt72aXtWJpCgY85XQBiPcGnNlnxScEWfHzN4iPsMg/w1SZohUfwbeFcqlo= Received: from 30.74.144.147(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WdjutEn_1749803501 cluster:ay36) by smtp.aliyun-inc.com; Fri, 13 Jun 2025 16:31:41 +0800 Message-ID: Date: Fri, 13 Jun 2025 16:31:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] mm: stop passing a writeback_control structure to shmem_writeout To: Christoph Hellwig , Andrew Morton , Hugh Dickins , Johannes Weiner , Yosry Ahmed , Nhat Pham Cc: Matthew Wilcox , Chengming Zhou , linux-mm@kvack.org References: <20250610054959.2057526-1-hch@lst.de> <20250610054959.2057526-3-hch@lst.de> From: Baolin Wang In-Reply-To: <20250610054959.2057526-3-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: xw5as6mwuqsgwm6o3nrgtd8ut1t5g973 X-Rspamd-Queue-Id: C487C180003 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749803507-140870 X-HE-Meta: U2FsdGVkX1+B2Ck3fdssqiGigkGaRJpsfxoxoKiysi9tBEz3GUMU03YQwDH6kn5rcUZMdAha5I478qoxC85ecpvHTfxyZtQCQBEr3zcFydpOvTVOLp2Wz6ifBlzkQ/Ni9vmBJisYgfx+JDU/S2znKsTyj4TgUZMLufr2zaEG9O9DL7Jm4Rbz8NDlH/J+2i0P+1Gk3hF2AWvf1mfieD7dnc8sZ53iuYvZq00EFcXdHL3JmuqGTY8DH528vXBLlQgwI13siBelyypEzr973MCR8w38/HTl6H+Sg6jiBPaCrRVhn7bqczYS8BLOs00IEhJCQvT8fTEKR2YAl0cFRT++Irco3846FzeZTGz/CT7z5jTFRFdpHRTdr8trnAoEE/oaGubVVWyrNb1Vbg8wLriA2rtjZoI2kVuyzsDhVRvrinnumVrtO8Ri/zqdB2E4MKyFWvmhCs72/VvdLEYPW99GiR1//fxEi3JaWEDDpQOzXt42+syR/x9MeWn+6eWyOlBnR/01KMTQmurfB5YeAyxx9pVBDLNudN5UGmwb3Cu0qcAmaIqMyU043edRgR27U1xjTSYbc1DZYNCM/pSR6Q4iCxjkggAWCnYF2mm4TfjzzHkKjJ+VsxGqGP+qVCvPkuhDk0hVaj/UBGvQqcYDHFjAJJCf7hcJHFMaRoYUfkkRZqtgp87ALJmWL/NAK0nAHsB+ZeFYGEF47PPaJvgNeeUaq/jqJpW2GOJ19EYRPKACLVhfgx8EqZdHyi1DRx4uVCZXIJi/bqlPAEjhQOBXvpuIkScgWz5WFNkWMLt3ojdFtJLOTW/wDkTl+rRBBNI8K0KHhzC/zLZ6aTSvPsNyBXjBrtS05giWbY7wMUypWsuJLT9e0CSAzfAmBy2zVT/7S8aBOI0qPzb+sYyFb/S3oMzDhU1P6zLl6RKNMY5H+4Q81bQc7oJ/gdTtHoJf9BUCgwuwWl5gNcvie1Oth4NpbSp EIEqDHcA jXKCpawxVjegjJOw7i7C5tkx4w6M8e2sXMLJiBIQcfPMYk0hArMUo6tAUnPU/5UlP7slNpB0l/nUhshkumWOyle0BayC2Dc/vlttx7om3OX4AzkWAdSXEBs2v4AYZcb4qf2DyaU87V0VLGh6KIdvhAx5vABXcdK3cgJAs0vBD3ou4m6XryboZtf3y3T990DR0fSsj9x4LUkXpY8zcyOp5dA2NhobdRRkjB+fMyAgkJ9b5ivOmAOP9QQoyiQxbUqFmomojAX4VAZ5VsZmojbw9AmjW3HL2v/G/KIH0BN1oJ+8TKTpj+lc9Vp8ovdH7ssuwxv/Zdd8ijJBItB17WUqGrTjWIMemiHaox31S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/10 13:49, Christoph Hellwig wrote: > shmem_writeout only needs the swap_iocb cookie and the split folio > list. Pass those explicitly and remove the now unused list member > from struct writeback_control. > > Signed-off-by: Christoph Hellwig Thanks for the cleaning up, and I did a quick shmem swap-out/in test, and no issues found. Reviewed-by: Baolin Wang Tested-by: Baolin Wang