From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6AAC021B8 for ; Sat, 1 Mar 2025 05:54:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCD526B007B; Sat, 1 Mar 2025 00:54:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA4766B0082; Sat, 1 Mar 2025 00:54:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6CBB6B0083; Sat, 1 Mar 2025 00:54:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 97B2E6B007B for ; Sat, 1 Mar 2025 00:54:14 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 43B231CB762 for ; Sat, 1 Mar 2025 05:54:14 +0000 (UTC) X-FDA: 83171916828.10.8AF55D7 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf03.hostedemail.com (Postfix) with ESMTP id BBE2720006 for ; Sat, 1 Mar 2025 05:54:10 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=FkSNu3gG; spf=pass (imf03.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740808452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u2eBPXUoeE47ene7JxTrxiOlqV8Ez8vfqaaOsrJND8Q=; b=XqptgZ5AD1HgsBK9Im/3hN9sgVum6xAjewXD9LplMIz7VthjkNZRmf3s0EGlxrSUAFM5W6 3zEg06daig9KM7pUAgGmzUsHrYxy+h46FITOsLsd6euZlgeaW+0A3qDcEjy13YvwNleNRK Aepi2FeyJtgABfrhrFvUR3qP2c5IQXY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740808452; a=rsa-sha256; cv=none; b=cuRsk9kkw/IrNIhBIEPtyysKS2oP1139ER7C36Dwjb37/3MLXJnDcTcWIJ9SHDJ3A0mDK3 7Kux8DKVKRJPD37Qo7Ow7paRRz14Ml6MG8GDIpEhZ/1lWuk79GOdROGRcb6C3flqmsArVk M/JPq+OOcP0aXcny/kzEZPviBRPM62o= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=FkSNu3gG; spf=pass (imf03.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1740808447; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=u2eBPXUoeE47ene7JxTrxiOlqV8Ez8vfqaaOsrJND8Q=; b=FkSNu3gGpjGVDtF8m0YtrfiXqTow0lnwduRq7u2M5VDp6QjU+4AuS6cu2Ujl5Xq3n64yj/sxtG/gWxlwH/s8F1joWWaJ1SS3+7ZdlcFVh7oqkHMyywUDRH64zbJpxs/s9f7yQ7U/9cWoX4Kn+BaJgyyeBjfaT2lbREaKdB/MCbw= Received: from 30.246.161.128(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WQRfULE_1740808444 cluster:ay36) by smtp.aliyun-inc.com; Sat, 01 Mar 2025 13:54:05 +0800 Message-ID: Date: Sat, 1 Mar 2025 13:54:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] mm/hwpoison: Fix regressions in memory failure handling To: Borislav Petkov Cc: "Luck, Tony" , "nao.horiguchi@gmail.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "linmiaohe@huawei.com" , "akpm@linux-foundation.org" , "peterz@infradead.org" , "jpoimboe@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "baolin.wang@linux.alibaba.com" , "tianruidong@linux.alibaba.com" References: <7393bcfb-fe94-4967-b664-f32da19ae5f9@linux.alibaba.com> <20250218122417.GHZ7R78fPm32jKYUlx@fat_crate.local> <20250219081037.GAZ7WR_YmRtRvN_LKA@fat_crate.local> <20250220111903.GDZ7cPp1qVq3t9Jgs6@fat_crate.local> <4e13bef2-7402-4f75-8f0c-4a3cc210c5a6@linux.alibaba.com> <20250224220146.GBZ7zsSnXLftyqWzW_@fat_crate.local> <6f34c17c-4113-46d9-aa66-53ff5a1feed5@linux.alibaba.com> <20250228123553.GCZ8GtqbSq9kaYOaCi@fat_crate.local> From: Shuai Xue In-Reply-To: <20250228123553.GCZ8GtqbSq9kaYOaCi@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: keyts3hzcecimrkuu4ys1dum1fietayz X-Rspamd-Queue-Id: BBE2720006 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740808450-788284 X-HE-Meta: U2FsdGVkX1/rEaBHe/oIZA4j7hPwI9qq7FEvVUoyo6d31FXF3Z/Phy6UD/+5zdrbpfuUjelJFtb5qWdzHuVFRLZlMlgk4/fbrIbqRNp+gwe3DdCCOUlSr0nucPQlkZEVdrFGkUzjBH1x4m+9qLvM+HqwOGW4bGtIJLpq7z/Ntq4ncJfXsKN1LG2N57FupSaftdDzKOlyPCJVLP92jL0ceGb984+mAfS5SH5hn1ym9v8BW3UAFjLkefKE1Gv/s2WCjNl4eFbUMVyybDo7S2cv0UTLBdiZfhhatdG8Upq4Rr+91HI7X2lfxNrNrSYfjTCBk5NxuprDkXEE5BmtlOZJBCvB2fY35pwBSzkYrKJz7IEoLljg6JUhVyWPPZxWATr97x+l+RU5Ju+Iks8T1Huc08vhmYkK8RZnV3kCDN6It2pFoz3KzbneHkWJ4OyKTpz9UYCnSwYVslJbnar2/KL8FrjELCdCPx6GPkktcomq4qyv/nUQtTCe2ctkAkLOpOWb3icLonHHJyK/fNHEqTKcIpZPnnJLWEdpdozYnFvnbwHFJsoMFbota5md6HoTZmulPxGxzMIk9OiTYAwh02xfu7XQagXYyNZx1mO/zsFR7vOq3pWqdVEtEf7i6vZ2vXo886EcgFUsjPrXhsyrI+vCWqK/IfQUJgPeIdyny6T6Gi5AvFQHUaGqnWJnuKOJ8prU4ghMsnMTAeLYDTPZ3dQKB9NnnWrw38PLfUPKrj+C5KCkcnu7nGsqZk6TxlwC13GC1xKD/u+PUw3mv1K5gNXikxJ0MyGrdNOmlu1zOSzrgpq3gEpxpL7MhYkYZOxr9Nu+IcHe5HOQvo+xTxylPO81Dbw/nb3IKltPQY+caMUlYIjnVwUB6TWTT4CbpuTSAmwRSP0To6aWDp4FHK4HkKfWV5AMsRjIEwxRPRubVftTgiWmcdqVce1n5lnyHAQHs/EfTkc40Ib8SBew45ibfrp iZVlE5wd VCgssSGjCTiAe2vYzoudAHgFVctQZG57eZnxsMTNkuho/4Izf0z+2RkPQpwAlJIRVOHu59cCKkQlON159cM2RV7yEOPGY/DoAKJuAWWjQ423VavKFc1r9Sz/23swFpc3Vsu12Q9F2DaAyH03dKHvTwJrE3uLysOrIcvNRpjJEMX+UAcGxXYC8earwPj16+PrqoQV3vnAqiYeLW90wSt5vQiZgMtVQEGgCldw/wJHP4edrUk1wLZvoT4c/bAbxh9w8s/4lm4OYhxYulZy1cLqdrHB7YbHM2qzo7Ur0k6Ey8Uca4SCINwfkmM7QcHeKVWl/wEF3VRRzk4CxqvckyuxAgdGegyRu8diHTxIG/FQree2d+dh40nWQbQbiFWn3lFp1VeQchcjjst3FlxGLclce7sV71YAsE5nFDSWfsKyt7jCbyD+l0gOYjYLNvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.065545, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/28 20:35, Borislav Petkov 写道: > On Tue, Feb 25, 2025 at 09:51:25AM +0800, Shuai Xue wrote: >> It depends on the forked process which trying to read the poison. > > And? Can you try creating more processes and see what happens then? > Sure. The experimental model includes: 1. inject UE to a memory buffer 2. create 10 processes 3. all 10 process read the posioned buffer 4. 10 MCEs and 1 UCNA will be triggered 5. each process receives a SIGBUS Some details: #perf record -e probe:memory_failure -agR -- ./einj_mem_uc thread 0: thread vaddr = 0x7f65f08da400 paddr = 82702ec400 injecting ... >> trigger_thread >> trigger_thread >> trigger_thread >> trigger_thread >> trigger_thread >> trigger_thread >> trigger_thread >> trigger_thread >> trigger_thread >> trigger_thread signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 signal 7 code 4 addr 0x7f65f08da000 page not present Unusual number of MCEs seen: 10 Test passed [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.640 MB perf.data (11 samples) ] #perf script einj_mem_uc 1722254 [151] 695128.161644: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) einj_mem_uc 1722255 [014] 695128.161712: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) einj_mem_uc 1722256 [153] 695128.161716: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) einj_mem_uc 1722257 [124] 695128.161759: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) einj_mem_uc 1722258 [154] 695128.161782: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) einj_mem_uc 1722259 [026] 695128.161819: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) einj_mem_uc 1722260 [157] 695128.161852: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) einj_mem_uc 1722261 [158] 695128.161895: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) kworker/50:3-mm 1714430 [050] 695128.168736: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa25aa93 uc_decode_notifier+0x73 ([kernel.kallsyms]) ffffffffaa3068bb notifier_call_chain+0x5b ([kernel.kallsyms]) ffffffffaa306ae1 blocking_notifier_call_chain+0x41 ([kernel.kallsyms]) ffffffffaa25bbfe mce_gen_pool_process+0x3e ([kernel.kallsyms]) ffffffffaa2f455f process_one_work+0x19f ([kernel.kallsyms]) ffffffffaa2f509c worker_thread+0x20c ([kernel.kallsyms]) ffffffffaa2fec89 kthread+0xd9 ([kernel.kallsyms]) ffffffffaa245131 ret_from_fork+0x31 ([kernel.kallsyms]) ffffffffaa2076ca ret_from_fork_asm+0x1a ([kernel.kallsyms]) einj_mem_uc 1722252 [050] 695128.183025: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) einj_mem_uc 1722253 [051] 695128.191348: probe:memory_failure: (ffffffffaa622db4) ffffffffaa622db5 memory_failure+0x5 ([kernel.kallsyms]) ffffffffaa2594fb kill_me_maybe+0x5b ([kernel.kallsyms]) ffffffffaa2fac29 task_work_run+0x59 ([kernel.kallsyms]) ffffffffaaf52347 irqentry_exit_to_user_mode+0x1c7 ([kernel.kallsyms]) ffffffffaaf50bce noist_exc_machine_check+0x3e ([kernel.kallsyms]) ffffffffaa001303 asm_exc_machine_check+0x33 ([kernel.kallsyms]) 405046 thread+0xe (/home/shawn.xs/ras-tools/einj_mem_uc) >> IMHO, we should send a SIGBUS signal to the processes running on the CPUs that >> detect a memory error for dirty page, which is the current behavior in the >> memory_failure. > > And for all those other processes which do get to see the already > poisoned/clean page, they should continue on their merry way instead of > getting killed by a SIGBUS? > Yes, memory_failure() only sends a SIGBUS signal to the process that is actively reading a poisoned page. Other processes that share the poisoned page will not receive a SIGBUS signal unless they have the PF_MCE_EARLY flag set.[1] [1]https://lkml.kernel.org/r/20220218090118.1105-4-linmiaohe@huawei.com Thanks. Shuai