From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A28CEEE3F2F for ; Fri, 15 Sep 2023 06:47:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEAE76B031D; Fri, 15 Sep 2023 02:47:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9A176B031E; Fri, 15 Sep 2023 02:47:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D61CE6B031F; Fri, 15 Sep 2023 02:47:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C6CAA6B031D for ; Fri, 15 Sep 2023 02:47:33 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 97A8CC0929 for ; Fri, 15 Sep 2023 06:47:33 +0000 (UTC) X-FDA: 81237900786.23.E8B151F Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by imf04.hostedemail.com (Postfix) with ESMTP id 3555E40019 for ; Fri, 15 Sep 2023 06:47:30 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=X1cyTYhZ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of xiaoyao.li@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694760451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KFwmST+28+JQuI4fAhoCg0WB+pIidCQMHgLH54IRLXg=; b=VNZb++N9gqdwKrFAqZyNvdHOpE66+jDlgnOzNdih5vPNpOaMiwyI5qzS9m+mAVtQLsVG57 1a9I58XzEP5cHHXa3la2BWo7J/U/Yph90xi6Hr8fVde8QkRtT5NLhzzcmQ3N5+iZSkeBgC WDAvOu97ZtmFZ0ZT1To4DrkqNFLYgAs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=X1cyTYhZ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf04.hostedemail.com: domain of xiaoyao.li@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694760451; a=rsa-sha256; cv=none; b=6xn+Y+/dkvmnhmwuAuhOUqkTUEeHNEhjTvuVr+IP/N514Th9X7mA3FUpn8umlUYesWvOOz zc/Q9JEZCftcARhPxsPCE7wi40P9SINUDWd0NnzTF7UqlckESn5k7UJyfE/XWlKo4hmLFW sQvUwoZxa8mKXl6WS8qeeK0bK4FsHIg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694760451; x=1726296451; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nbiNTtCye3B4MOA9keAnL3jGRC3Z0ZFqO6c5ckMzgn4=; b=X1cyTYhZFxuHSkhMCRNlilWkk4sGhucEw7AmevSdjyt7HWs/JW7SGBu7 DzTHhctlzRoqnRBbbaQ4TxqDvyUuEQkzwXgLrnVcz2FARVqJQLhjpdz5c 7jGSDlGRgZAXAcohyzN39ycwipah2yCGuBU9ZKQ4V09gs+68NSVjiQI3F SEqLz+7DHuWd7EM6C2QjxCaDeSASidK3NSrDjg+1QnLUjIWpdYFHpKLWL 00/GtQFFMInx28sS2WEzikxqHgSAGULPXtvNo+/w1IPkkiMr0DVqnH6D3 S4uEnO3AgE1tTONfupfTBUfvcyw+PsJvv2VYqHp4CYWGHhN5QiNg0HF7M g==; X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="383000917" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="383000917" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 23:47:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="744857575" X-IronPort-AV: E=Sophos;i="6.02,148,1688454000"; d="scan'208";a="744857575" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.93.29.154]) ([10.93.29.154]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 23:47:16 -0700 Message-ID: Date: Fri, 15 Sep 2023 14:47:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v12 01/33] KVM: Tweak kvm_hva_range and hva_handler_t to allow reusing for gfn ranges Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , Xu Yilun , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230914015531.1419405-1-seanjc@google.com> <20230914015531.1419405-2-seanjc@google.com> From: Xiaoyao Li In-Reply-To: <20230914015531.1419405-2-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3555E40019 X-Stat-Signature: gkxkki6uu51c7fpe1zjank5sesphjznb X-Rspam-User: X-HE-Tag: 1694760450-160864 X-HE-Meta: U2FsdGVkX1/JMZ9DQyFhzz2Wd4G7mUQJmE8n6DexmYdPMxMDBnNKEXUFnGJJ99EVyJFJHT2CbG8WO83CiKEVHDhY6n6qUY4U1TwMJcjpPvp6issURKkLYGCNm7ZUyDMaBUOsh8AzbtGiuwIC/Ifo7Y//r26PvjfQwgScOIZWT13mQJ8I/B8GVmvEQH6KjnxDnJVvscgtKcUgNaoFBHi5pHHYN78W/DQkXipcnl6L4gqZ2cwx4XQKIWGh/VV0RUFcrslQVlh2t8hkDMF3fq0qgJ/E+stv3FCyrzE91PYMaL6WqWmbq8J7YjyuS/OpooWzFsjvaSxaZ4vvuOLPcRJ5PaTQke7vtgKMJQFUWySH5GUDjf9lu4fqCd7I99NwvT0LWRDGhogAx/JFv32/XCsQSscPFsxc23KhOylw0N+O1WQDGsYRfDw1dG/7OgBcV1KoFeuoojQsORQmxzknCK7svDooENFs9uOSFDqghR2lZuSg7ISzwYKU7muLiPgShAs7Z68RbJr5/O0jE/v94xEnfOMxWw7Glbs03mdgnDVpPGlvxWE/wUPETOs35YIHnmCrDHwoIAbS19HxrhuGGkggRFD1Ftf+lLvVFFqLhHiuydF6QDRzTStYsHKjCRp1iOzijsVIpkFWx95BR/eZHKKKtS9cX3limHl0eYsC0VW9lTOykD1QK2Ha2bLa9GiO6/BTXYgkfn2UOYewIa2pLa4ZnM/XPMw1+QBo1zIEYXPszxIFjc6yesu4BZW9Bm433MT/Ax0qVRzWGrXmhTnfztLDpVran3grsNySLJO1HBzmVpU+MDY7ccXxTxg6PpDN7wR82qj5qg7Bu4Fpr2SWa1RQwK9uuJB37JYct1G1hxLJ/6L2xvg8ifiRbqldw4MD3llDmH46CSxxY6pnggSRD14wHsGdYDGnFz1bK0Sdqeo7aeQKR+cQsbtmEMPkA3AA7kQ0WAQhUjiXCaD9uzqJoSl GNggyo+D 1I+BdSrZy3SvivFUK2VVKwLr5mjL0HfmYDRAJs0v180Zh3sst9DoiCxxZjDcNBYFFDNySgk0tUhkOOsDaCd+g3HfYD1w6EJeWyv88wPukv4chV2vgPjkjC96+YpuGRaSoAiTX8EFXnak0UXLq1CPmgxlSJvL3nfLuKM7vBLxM/M/8NaKTdPuuhkBRVNQd1LrtP55k9mucvbT8HXIdm9xeDPWbgd0ymV8uTTxhVUOohJs3Y8WzozCgbHYtSeVXSJyZGHysbiI2F2yhd4gZUGaPoBdRveDtK4XU+Dwa6mAa+S+OWl1DeVn8Re0G1titQf9SjWeWkOIpF+Q6pRw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/14/2023 9:54 AM, Sean Christopherson wrote: > Rework and rename "struct kvm_hva_range" into "kvm_mmu_notifier_range" so > that the structure can be used to handle notifications that operate on gfn > context, i.e. that aren't tied to a host virtual address. > > Practically speaking, this is a nop for 64-bit kernels as the only > meaningful change is to store start+end as u64s instead of unsigned longs. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Sean Christopherson > --- > virt/kvm/kvm_main.c | 34 +++++++++++++++++++--------------- > 1 file changed, 19 insertions(+), 15 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 486800a7024b..0524933856d4 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -541,18 +541,22 @@ static inline struct kvm *mmu_notifier_to_kvm(struct mmu_notifier *mn) > return container_of(mn, struct kvm, mmu_notifier); > } > > -typedef bool (*hva_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); > +typedef bool (*gfn_handler_t)(struct kvm *kvm, struct kvm_gfn_range *range); Is it worth mentioning the rename of it as well in changelog? Anyway, Reviewed-by: Xiaoyao Li