From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00DD4ECAAD3 for ; Fri, 9 Sep 2022 11:27:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 735BD8D0003; Fri, 9 Sep 2022 07:27:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E70F8D0002; Fri, 9 Sep 2022 07:27:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 587D78D0003; Fri, 9 Sep 2022 07:27:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4B1F88D0002 for ; Fri, 9 Sep 2022 07:27:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 176AAC136E for ; Fri, 9 Sep 2022 11:27:31 +0000 (UTC) X-FDA: 79892321502.06.2A596C0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id A37F31400A2 for ; Fri, 9 Sep 2022 11:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662722850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+wfYy6ZeUFGo0evauzx0o3lnmHqWq7O1ZHI0jQhIckQ=; b=fD2ZVx5vrb7o7MbOWm7FAYxniulNWlx7tLQV1AXvcNFLkaTdIM6TwMw7BPIzC3i7Rqmt9j sv7NZCYNs5mfqFzd2Kq/VUeXYHP3xlikRbtECnrPXz3XcFjPPAv6tMA64Lgqs+g7C7pqGF pen1u5x7RPnjheuCCrhDVXfhjgEAmyM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-517-PxDVl22EN1O0KFfIh9cZ-A-1; Fri, 09 Sep 2022 07:27:29 -0400 X-MC-Unique: PxDVl22EN1O0KFfIh9cZ-A-1 Received: by mail-wm1-f72.google.com with SMTP id f18-20020a05600c4e9200b003a5f81299caso714174wmq.7 for ; Fri, 09 Sep 2022 04:27:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=+wfYy6ZeUFGo0evauzx0o3lnmHqWq7O1ZHI0jQhIckQ=; b=4OQFW/VElFXABQcByk73Ih7vDnBqwY2n61317lu2d7KnWWZVWtrk+MRvrt5DLYO0/x Pz4fEgAMBi2QzeGLAQetgTJ4IDPDg05FPQ3H6V+kg+Mr6lELZUxz7dmYsMBKan2KfxMF 5rzNk6O4ywIYvA6f/GWVdDJShYQDQbMC1KCF+bapIHrzvnfYmHfUNLYCr/72bBFAyx3o 7+1ufQIexHawkdw0JQ4RBCDxAcWUO2buaGnU9m2Mdd0Z4xrMEsG/3kcdgx6+f8tLDY24 8FqdgaHvGUYg1GuYU0SBnbjlBScM0jVUhLl2tO39ixZmnKuymkERVysUxYViYY8jK70S WOwQ== X-Gm-Message-State: ACgBeo1ULcoPudAKRnm2PCzWI2clsdtDM8NNRVhBrfbzyHiZ3DSYmKas NVCAxaSGaDN9CPxqmo3VPsuinYr5X6TssndSIui55nBp1KVpCf3v5KAvqUOtdIgqCA2BDRE+hiS rc4rEzjEvAgw= X-Received: by 2002:a5d:4e0a:0:b0:228:a2d7:f474 with SMTP id p10-20020a5d4e0a000000b00228a2d7f474mr7680973wrt.286.1662722848119; Fri, 09 Sep 2022 04:27:28 -0700 (PDT) X-Google-Smtp-Source: AA6agR4gaaUiKkxNMVR9UES/pb1gukqOYoJZGBneYbkpS1MRHWiLR5yBTYRJnq/SoGI6M6S4T8cElw== X-Received: by 2002:a5d:4e0a:0:b0:228:a2d7:f474 with SMTP id p10-20020a5d4e0a000000b00228a2d7f474mr7680961wrt.286.1662722847884; Fri, 09 Sep 2022 04:27:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:6300:1fe0:42e1:62c5:91b6? (p200300cbc70463001fe042e162c591b6.dip0.t-ipconnect.de. [2003:cb:c704:6300:1fe0:42e1:62c5:91b6]) by smtp.gmail.com with ESMTPSA id k36-20020a05600c1ca400b003a5260b8392sm526951wms.23.2022.09.09.04.27.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 04:27:27 -0700 (PDT) Message-ID: Date: Fri, 9 Sep 2022 13:27:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 04/16] mm/page_alloc: remove obsolete comment in zone_statistics() To: Miaohe Lin , akpm@linux-foundation.org Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-5-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220909092451.24883-5-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662722850; a=rsa-sha256; cv=none; b=d3xEKmCiZ3cQncr5qa4xCyE6r/StZW7mEbEH8/L8SJlEIkRqCtdwCRYB42ay2UXtbUMDvu UdATa5L9HNYc1KguzrZhtnJkgg0OPZCXFe8X5ILYmirUdnFD4rHtB6fxo17Csj7CARzdvz OSaN5vSkk9i4l3Y8cJEcbdFU1EqhN9g= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fD2ZVx5v; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662722850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+wfYy6ZeUFGo0evauzx0o3lnmHqWq7O1ZHI0jQhIckQ=; b=VgQ9/VLiJut7tZLtJiUnUuHpGZUymlOKPpGiusuj/DLSsDuQXKXe24yGgFDWH3I0Xj682c t46H8yoBpg4yBNjQFQbdElYeu+k9Y4GkoutOBf5PG/wu9SlzfohzJHXNvYDmMzz3jzjWJT ad+e6TffPw8jBAYVusAAaJ7MlVBzJQs= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fD2ZVx5v; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Queue-Id: A37F31400A2 X-Rspamd-Server: rspam09 X-Stat-Signature: fumbtohb1ey5bdjpn77xyhq5aqih5tkt X-HE-Tag: 1662722850-746409 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.09.22 11:24, Miaohe Lin wrote: > Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs > are disabled for VM counters"), zone_statistics() is not called with > interrupts disabled. Update the corresponding comment. > > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2deac2fe3372..c81f06d8a4f5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt) > > /* > * Update NUMA hit/miss statistics > - * > - * Must be called with interrupts disabled. > */ > static inline void zone_statistics(struct zone *preferred_zone, struct zone *z, > long nr_account) Acked-by: David Hildenbrand -- Thanks, David / dhildenb