From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Matthew Wilcox" <willy@infradead.org>,
"Tamir Duberstein" <tamird@gmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
linux-mm@kvack.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Take ARCH_KMALLOC_MINALIGN into account for build-time XArray check
Date: Tue, 12 Aug 2025 13:41:37 -0400 [thread overview]
Message-ID: <d3vt33v5jkhv7xp2yvl65sc2n6uiytrojgyj63voz7oilxxvr2@c6niknhbfiep> (raw)
In-Reply-To: <20250811-align-min-allocator-v2-0-3386cc94f4fc@google.com>
* Alice Ryhl <aliceryhl@google.com> [250811 08:32]:
> The Rust bindings for XArray include a build-time check to ensure that
> you can only use the XArray with pointers that are 4-byte aligned.
> Because of that, there is currently a build failure if you attempt to
> create an XArray<KBox<T>> where T is a 1-byte or 2-byte aligned type.
> However, this error is incorrect as KBox<_> is guaranteed to be a
> pointer that comes from kmalloc, and kmalloc always produces pointers
> that are at least 4-byte aligned.
>
> To fix this, we augment the compile-time logic that computes the
> alignment of KBox<_> to take the minimum alignment of its allocator into
> account.
>
> Intended to land through alloc-next under the RUST [ALLOC] entry.
>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Acked-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> Changes in v2:
> - Reword guarantee on `const MIN_ALIGN`.
> - Change formatting of if/else in kbox.rs.
> - Rebase on v6.17-rc1.
> - Link to v1: https://lore.kernel.org/r/20250715-align-min-allocator-v1-0-3e1b2a5516c0@google.com
>
> ---
> Alice Ryhl (2):
> rust: alloc: specify the minimum alignment of each allocator
> rust: alloc: take the allocator into account for FOREIGN_ALIGN
>
> rust/kernel/alloc.rs | 8 ++++++++
> rust/kernel/alloc/allocator.rs | 8 ++++++++
> rust/kernel/alloc/kbox.rs | 13 +++++++++----
> rust/kernel/sync/arc.rs | 6 +++---
> 4 files changed, 28 insertions(+), 7 deletions(-)
> ---
> base-commit: 062b3e4a1f880f104a8d4b90b767788786aa7b78
> change-id: 20250715-align-min-allocator-b31aee53cbda
>
> Best regards,
> --
> Alice Ryhl <aliceryhl@google.com>
>
next prev parent reply other threads:[~2025-08-12 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <pR7yUSHMm_04sw7FqBeN5OaFASLq1MTrX5ojLG2yZx9IXByhp6Lyf1dSzUB3tArhQZoxOYITWVixYBaM_mZLyQ==@protonmail.internalid>
2025-08-11 12:31 ` Alice Ryhl
2025-08-11 12:31 ` [PATCH v2 1/2] rust: alloc: specify the minimum alignment of each allocator Alice Ryhl
2025-08-12 17:52 ` Danilo Krummrich
2025-08-13 7:52 ` Alice Ryhl
2025-08-13 9:14 ` Danilo Krummrich
2025-08-13 9:32 ` Alice Ryhl
2025-08-13 10:19 ` Danilo Krummrich
2025-08-13 10:43 ` Alice Ryhl
2025-08-11 12:31 ` [PATCH v2 2/2] rust: alloc: take the allocator into account for FOREIGN_ALIGN Alice Ryhl
2025-08-11 13:38 ` [PATCH v2 0/2] Take ARCH_KMALLOC_MINALIGN into account for build-time XArray check Andreas Hindborg
2025-08-12 17:41 ` Liam R. Howlett [this message]
2025-08-15 19:12 ` Danilo Krummrich
2025-08-18 11:09 ` Thorsten Leemhuis
2025-08-18 11:18 ` Miguel Ojeda
2025-08-18 12:03 ` Danilo Krummrich
2025-08-24 11:38 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3vt33v5jkhv7xp2yvl65sc2n6uiytrojgyj63voz7oilxxvr2@c6niknhbfiep \
--to=liam.howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox