From: Alex Shi <alex.shi@linux.alibaba.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>,
syzbot <syzbot+826543256ed3b8c37f62@syzkaller.appspotmail.com>
Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mhocko@kernel.org,
syzkaller-bugs@googlegroups.com, vdavydov.dev@gmail.com
Subject: Re: linux-next test error: BUG: using __this_cpu_read() in preemptible code in __mod_memcg_state
Date: Mon, 9 Mar 2020 21:26:59 +0800 [thread overview]
Message-ID: <d3fb0593-e483-3b69-bf2c-99ad6cd03567@linux.alibaba.com> (raw)
In-Reply-To: <5b1196be-09ce-51f7-f5e7-63f2e597f91e@linux.alibaba.com>
在 2020/3/9 下午5:56, Alex Shi 写道:
>
>
> 在 2020/3/9 下午5:24, Kirill A. Shutemov 写道:
>>> check_preemption_disabled: 3 callbacks suppressed
>>> BUG: using __this_cpu_read() in preemptible [00000000] code: syz-fuzzer/9432
>>> caller is __mod_memcg_state+0x27/0x1a0 mm/memcontrol.c:689
>>> CPU: 1 PID: 9432 Comm: syz-fuzzer Not tainted 5.6.0-rc4-next-20200306-syzkaller #0
>>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
>>> Call Trace:
>>> __dump_stack lib/dump_stack.c:77 [inline]
>>> dump_stack+0x188/0x20d lib/dump_stack.c:118
>>> check_preemption_disabled lib/smp_processor_id.c:47 [inline]
>>> __this_cpu_preempt_check.cold+0x84/0x90 lib/smp_processor_id.c:64
>>> __mod_memcg_state+0x27/0x1a0 mm/memcontrol.c:689
>>> __split_huge_page mm/huge_memory.c:2575 [inline]
>>> split_huge_page_to_list+0x124b/0x3380 mm/huge_memory.c:2862
>>> split_huge_page include/linux/huge_mm.h:167 [inline]
>> It looks like a regression due to c8cba0cc2a80 ("mm/thp: narrow lru
>> locking").
>
> yes, I guess so.
Yes, it is a stupid mistake to pull out lock for __mod_memcg_state which
should be in a lock.
revert this patch should be all fine, since ClearPageCompound and page_ref_inc
later may related with lru_list valid issue in release_pges.
Sorry for the disaster!
Alex
next prev parent reply other threads:[~2020-03-09 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 21:05 syzbot
2020-03-09 9:24 ` Kirill A. Shutemov
2020-03-09 9:56 ` Alex Shi
2020-03-09 13:26 ` Alex Shi [this message]
2020-04-18 7:04 ` Dmitry Vyukov
2020-04-18 7:43 ` Stephen Rothwell
2020-04-18 7:50 ` Stephen Rothwell
2020-04-18 8:02 ` Dmitry Vyukov
2020-04-18 8:13 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3fb0593-e483-3b69-bf2c-99ad6cd03567@linux.alibaba.com \
--to=alex.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=syzbot+826543256ed3b8c37f62@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox